| Message ID | 1385031857-13351-2-git-send-email-luis.henriques@canonical.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Nov 21, 2013 at 11:04:17AM +0000, Luis Henriques wrote: > From: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > BugLink: http://launchpad.net/bugs/1244505 > > Some weird remotes are not correctly creating the input device. Their > report descriptor starts with: > 0x06, 0x00, 0xff, // Usage Page (Vendor Defined Page 1) 0 > 0xa1, 0x01, // Collection (Application) 3 > > whereas others (which are correctly handled) start with: > 0x05, 0x0c, // Usage Page (Consumer Devices) 0 > 0x09, 0x01, // Usage (Consumer Control) 2 > 0xa1, 0x01, // Collection (Application) 4 > > The rest of the report descriptor is the same. > > Adding the quirk HID_QUIRK_HIDINPUT_FORCE forces hid-input to allocate > the inputs, and everything should be ok. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Tested-by: James Henstridge <james.henstridge@canonical.com> > Signed-off-by: Jiri Kosina <jkosina@suse.cz> > (cherry picked from 3d18bd41a82fac69c82e1725c7beea25b17a0190 in > git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git) > Signed-off-by: Luis Henriques <luis.henriques@canonical.com> > --- > drivers/hid/hid-appleir.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hid/hid-appleir.c b/drivers/hid/hid-appleir.c > index a42e6a3..0e6a42d 100644 > --- a/drivers/hid/hid-appleir.c > +++ b/drivers/hid/hid-appleir.c > @@ -297,6 +297,9 @@ static int appleir_probe(struct hid_device *hid, const struct hid_device_id *id) > > appleir->hid = hid; > > + /* force input as some remotes bypass the input registration */ > + hid->quirks |= HID_QUIRK_HIDINPUT_FORCE; > + > spin_lock_init(&appleir->lock); > setup_timer(&appleir->key_up_timer, > key_up_tick, (unsigned long) appleir); > -- Looks to do what is claimed. Limited to a single device. Acked-by: Andy Whitcroft <apw@canonical.com> -apw
diff --git a/drivers/hid/hid-appleir.c b/drivers/hid/hid-appleir.c index a42e6a3..0e6a42d 100644 --- a/drivers/hid/hid-appleir.c +++ b/drivers/hid/hid-appleir.c @@ -297,6 +297,9 @@ static int appleir_probe(struct hid_device *hid, const struct hid_device_id *id) appleir->hid = hid; + /* force input as some remotes bypass the input registration */ + hid->quirks |= HID_QUIRK_HIDINPUT_FORCE; + spin_lock_init(&appleir->lock); setup_timer(&appleir->key_up_timer, key_up_tick, (unsigned long) appleir);