diff mbox

UBUNTU: [Config] highbank: ecx1000: CPU_IDLE causes instabilities, disable it

Message ID 1378888565-14848-2-git-send-email-paolo.pisati@canonical.com
State New
Headers show

Commit Message

Paolo Pisati Sept. 11, 2013, 8:36 a.m. UTC 
The highbank cpuidle driver has some stability problems. Disable it for
now.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 debian.master/config/armhf/config.flavour.generic      | 1 +
 debian.master/config/armhf/config.flavour.generic-lpae | 1 +
 debian.master/config/config.common.ubuntu              | 1 -
 3 files changed, 2 insertions(+), 1 deletion(-)

Comments

Andy Whitcroft Sept. 11, 2013, 11:18 a.m. UTC | #1 
On Wed, Sep 11, 2013 at 10:36:05AM +0200, Paolo Pisati wrote:
> The highbank cpuidle driver has some stability problems. Disable it for
> now.
> 
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

> --- a/debian.master/config/armhf/config.flavour.generic
> +++ b/debian.master/config/armhf/config.flavour.generic
[...]
> +# CONFIG_CPU_IDLE_CALXEDA is not set
[...]
> --- a/debian.master/config/armhf/config.flavour.generic-lpae
> +++ b/debian.master/config/armhf/config.flavour.generic-lpae
> +CONFIG_CPU_IDLE_CALXEDA=y

Can you confirm you are intending to only turn this off for generic, I
thought generic-lpae was primarily for these machines at the current
time.

-apw
Paolo Pisati Sept. 11, 2013, 12:29 p.m. UTC | #2 
On Wed, Sep 11, 2013 at 12:18:18PM +0100, Andy Whitcroft wrote:
> On Wed, Sep 11, 2013 at 10:36:05AM +0200, Paolo Pisati wrote:
> > The highbank cpuidle driver has some stability problems. Disable it for
> > now.
> > 
> > Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> > Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> 
> > --- a/debian.master/config/armhf/config.flavour.generic
> > +++ b/debian.master/config/armhf/config.flavour.generic
> [...]
> > +# CONFIG_CPU_IDLE_CALXEDA is not set
> [...]
> > --- a/debian.master/config/armhf/config.flavour.generic-lpae
> > +++ b/debian.master/config/armhf/config.flavour.generic-lpae
> > +CONFIG_CPU_IDLE_CALXEDA=y
> 
> Can you confirm you are intending to only turn this off for generic, I
> thought generic-lpae was primarily for these machines at the current
> time.

yes, that's only for generic:

generic is targetting the "old" ECX1000 core (but it works on the new one
too), while generic-lpae works only on the new ECX2000 core (that has the LPAE
extension indeed).
diff mbox

Patch

diff --git a/debian.master/config/armhf/config.flavour.generic b/debian.master/config/armhf/config.flavour.generic
index a9d43f1..4259a57 100644
--- a/debian.master/config/armhf/config.flavour.generic
+++ b/debian.master/config/armhf/config.flavour.generic
@@ -12,6 +12,7 @@  CONFIG_ARCH_TEGRA=y
 CONFIG_ARM_ATAG_DTB_COMPAT=y
 # CONFIG_ARM_LPAE is not set
 # CONFIG_COMPACTION is not set
+# CONFIG_CPU_IDLE_CALXEDA is not set
 CONFIG_FB_BACKLIGHT=y
 CONFIG_FB_DDC=m
 CONFIG_FB_SVGALIB=m
diff --git a/debian.master/config/armhf/config.flavour.generic-lpae b/debian.master/config/armhf/config.flavour.generic-lpae
index 2c655c4..8ea0d6e 100644
--- a/debian.master/config/armhf/config.flavour.generic-lpae
+++ b/debian.master/config/armhf/config.flavour.generic-lpae
@@ -12,6 +12,7 @@  CONFIG_ARCH_PHYS_ADDR_T_64BIT=y
 # CONFIG_ARM_ATAG_DTB_COMPAT is not set
 CONFIG_ARM_LPAE=y
 CONFIG_COMPACTION=y
+CONFIG_CPU_IDLE_CALXEDA=y
 # CONFIG_FB_BACKLIGHT is not set
 # CONFIG_FB_DDC is not set
 # CONFIG_FB_SVGALIB is not set
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index cccb684..1c14ee5 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -1133,7 +1133,6 @@  CONFIG_CPU_FREQ_TABLE=y
 CONFIG_CPU_HAS_ASID=y
 # CONFIG_CPU_ICACHE_DISABLE is not set
 CONFIG_CPU_IDLE=y
-CONFIG_CPU_IDLE_CALXEDA=y
 CONFIG_CPU_IDLE_GOV_LADDER=y
 CONFIG_CPU_IDLE_GOV_MENU=y
 CONFIG_CPU_IDLE_MULTIPLE_DRIVERS=y