mbox series

[0/1,SRU,F] Fix __u64 not defined build issue

Message ID cover.1632340794.git.luke.nowakowskikrijger@canonical.com
Headers show
Series Fix __u64 not defined build issue | expand

Message

Luke Nowakowski-Krijger Sept. 22, 2021, 8:33 p.m. UTC 
[Impact]
BugLink: https://bugs.launchpad.net/bugs/1944613

There are build issues in selftests/memfd/fuse_test.c where __u64 is not 
defined. This is issue is probably due to the fact that in 5.4 there is
a type include in one of the includes in the file, however this include
probably was not there for 4.15. Regardless we fix this by including the 
type file directly. 

[Fix]
* selftests/memfd: fix __u64 not defined build issue
Add #include <asm/types.h> to define the type

[Test Plan]
Recompile tests to make sure they build and tests pass.

[Where problems could occur]
Should be no problems since we are adding an include file that userspace
files always have access to. 

Luke Nowakowski-Krijger (1):
  selftests/memfd: fix __u64 not defined build issue

 tools/testing/selftests/memfd/fuse_test.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Bader Sept. 24, 2021, 7:27 a.m. UTC | #1 
On 24.09.21 00:38, Luke Nowakowski-Krijger wrote:
> [Impact]
> BugLink: https://bugs.launchpad.net/bugs/1944613
> 
> There are build issues in selftests/memfd/fuse_test.c where __u64 is not
> defined that seems to be affecting most B/5.4 kernels.
> 
> [Fix]
> * selftests/memfd: fix __u64 not defined build issue
> Add #include <asm/types.h> to define the type
> 
> [Test Plan]
> Recompile tests to make sure they build and tests pass.
> 
> [Where problems could occur]
> Should be no problems since we are adding an include file that userspace
> files always have access to.
> 
> Luke Nowakowski-Krijger (1):
>    selftests/memfd: fix __u64 not defined build issue
> 
>   tools/testing/selftests/memfd/fuse_test.c | 1 +
>   1 file changed, 1 insertion(+)
> 
Not sure how this happened but the patch became a reply to the initial thread 
and the cover email sits on its own. Could you please send again as v3 and be 
sure that no old files sit around.

Thanks,
Stefan