mbox series

[SRU,Xenial,Bionic,Cosmic,0/2] Fixes for LP:1800641

Message ID cover.1540909345.git.joseph.salisbury@canonical.com
Headers show
Series Fixes for LP:1800641 | expand

Message

Joseph Salisbury Oct. 31, 2018, 5:54 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1800641

== SRU Justification ==
IBM is requesting these commits in s390 for X, B and C.  The bug
description the commits fix is as follows:

Description: qeth: Fix potential array overrun in cmd/rc lookup Symptom: 
Infinite loop when processing a received cmd.  
Problem: qeth_get_ipa_cmd_name() and qeth_get_ipa_msg() are used to build 
human-readable messages for received cmd data.



== Fixes ==
065a2cdcbdf8 ("s390: qeth_core_mpc: Use ARRAY_SIZE instead of reimplementing its function")
048a7f8b4ec0 ("s390: qeth: Fix potential array overrun in cmd/rc lookup")

== Regression Potential ==
Low.  Limited to s390.

== Test Case ==
A test kernel was built with these two patches and tested by IBM.
The bug reporter states the test kernel resolved the bug.

Jean Delvare (1):
  s390: qeth: Fix potential array overrun in cmd/rc lookup

zhong jiang (1):
  s390: qeth_core_mpc: Use ARRAY_SIZE instead of reimplementing its
    function

 drivers/s390/net/qeth_core_main.c |  2 +-
 drivers/s390/net/qeth_core_mpc.c  | 33 ++++++++++++++++-----------------
 drivers/s390/net/qeth_core_mpc.h  |  4 ++--
 3 files changed, 19 insertions(+), 20 deletions(-)

Comments

Stefan Bader Nov. 6, 2018, 11:07 a.m. UTC | #1
On 31.10.18 18:54, Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1800641
> 
> == SRU Justification ==
> IBM is requesting these commits in s390 for X, B and C.  The bug
> description the commits fix is as follows:
> 
> Description: qeth: Fix potential array overrun in cmd/rc lookup Symptom: 
> Infinite loop when processing a received cmd.  
> Problem: qeth_get_ipa_cmd_name() and qeth_get_ipa_msg() are used to build 
> human-readable messages for received cmd data.
> 
> 
> 
> == Fixes ==
> 065a2cdcbdf8 ("s390: qeth_core_mpc: Use ARRAY_SIZE instead of reimplementing its function")
> 048a7f8b4ec0 ("s390: qeth: Fix potential array overrun in cmd/rc lookup")
> 
> == Regression Potential ==
> Low.  Limited to s390.
> 
> == Test Case ==
> A test kernel was built with these two patches and tested by IBM.
> The bug reporter states the test kernel resolved the bug.
> 
> Jean Delvare (1):
>   s390: qeth: Fix potential array overrun in cmd/rc lookup
> 
> zhong jiang (1):
>   s390: qeth_core_mpc: Use ARRAY_SIZE instead of reimplementing its
>     function
> 
>  drivers/s390/net/qeth_core_main.c |  2 +-
>  drivers/s390/net/qeth_core_mpc.c  | 33 ++++++++++++++++-----------------
>  drivers/s390/net/qeth_core_mpc.h  |  4 ++--
>  3 files changed, 19 insertions(+), 20 deletions(-)
> 
Rather small and self-contained.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza Nov. 6, 2018, 4:53 p.m. UTC | #2
On 10/31/18 18:54, Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1800641
>
> == SRU Justification ==
> IBM is requesting these commits in s390 for X, B and C.  The bug
> description the commits fix is as follows:
>
> Description: qeth: Fix potential array overrun in cmd/rc lookup Symptom: 
> Infinite loop when processing a received cmd.  
> Problem: qeth_get_ipa_cmd_name() and qeth_get_ipa_msg() are used to build 
> human-readable messages for received cmd data.
>
>
>
> == Fixes ==
> 065a2cdcbdf8 ("s390: qeth_core_mpc: Use ARRAY_SIZE instead of reimplementing its function")
> 048a7f8b4ec0 ("s390: qeth: Fix potential array overrun in cmd/rc lookup")
>
> == Regression Potential ==
> Low.  Limited to s390.
>
> == Test Case ==
> A test kernel was built with these two patches and tested by IBM.
> The bug reporter states the test kernel resolved the bug.
>
> Jean Delvare (1):
>   s390: qeth: Fix potential array overrun in cmd/rc lookup
>
> zhong jiang (1):
>   s390: qeth_core_mpc: Use ARRAY_SIZE instead of reimplementing its
>     function
>
>  drivers/s390/net/qeth_core_main.c |  2 +-
>  drivers/s390/net/qeth_core_mpc.c  | 33 ++++++++++++++++-----------------
>  drivers/s390/net/qeth_core_mpc.h  |  4 ++--
>  3 files changed, 19 insertions(+), 20 deletions(-)
>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Khalid Elmously Nov. 7, 2018, 6:57 a.m. UTC | #3
On 2018-10-31 13:54:14 , Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1800641
> 
> == SRU Justification ==
> IBM is requesting these commits in s390 for X, B and C.  The bug
> description the commits fix is as follows:
> 
> Description: qeth: Fix potential array overrun in cmd/rc lookup Symptom: 
> Infinite loop when processing a received cmd.  
> Problem: qeth_get_ipa_cmd_name() and qeth_get_ipa_msg() are used to build 
> human-readable messages for received cmd data.
> 
> 
> 
> == Fixes ==
> 065a2cdcbdf8 ("s390: qeth_core_mpc: Use ARRAY_SIZE instead of reimplementing its function")
> 048a7f8b4ec0 ("s390: qeth: Fix potential array overrun in cmd/rc lookup")
> 
> == Regression Potential ==
> Low.  Limited to s390.
> 
> == Test Case ==
> A test kernel was built with these two patches and tested by IBM.
> The bug reporter states the test kernel resolved the bug.
> 
> Jean Delvare (1):
>   s390: qeth: Fix potential array overrun in cmd/rc lookup
> 
> zhong jiang (1):
>   s390: qeth_core_mpc: Use ARRAY_SIZE instead of reimplementing its
>     function
> 
>  drivers/s390/net/qeth_core_main.c |  2 +-
>  drivers/s390/net/qeth_core_mpc.c  | 33 ++++++++++++++++-----------------
>  drivers/s390/net/qeth_core_mpc.h  |  4 ++--
>  3 files changed, 19 insertions(+), 20 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team