mbox series

[0/1,bionic,hwe,kernel] scsi: Revert "target/core: Inline transport_lun_remove_cmd()"

Message ID DC2C07C9-556A-41B7-AECE-07667B5D89F8@delphix.com
Headers show
Series scsi: Revert "target/core: Inline transport_lun_remove_cmd()" | expand

Message

Pavel Zakharov Feb. 28, 2020, 9:16 p.m. UTC 
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-hwe/+bug/1862682

Disclaimer: First time submitting patch to Ubuntu kernel team, so apologies if
the formatting is not correct. I’ve used the mailing list archives and
https://wiki.ubuntu.com/Kernel/Dev/KernelPatches for reference.

iSCSI LUN deletion hangs because a reference is not dropped on the LUN being
deleted until another command is sent from the same initiator. This was
introduced in 5.3 because of code simplification. Note: this patch is for
the hwe kernel for bionic.

[Impact]
This greatly affects iSCSI Target workflows that regularly create and destroy
LUNs.

[Fix]
Revert the code simplification as it is incompatible with the iSCSI target
driver.

[Test]
Verified that reverting the original code resolves the hang when deleting iSCSI
LUNs.

[Regression Risk]
Very low. There are no code dependencies on the original code simplification.


Bart Van Assche:
  scsi: Revert "target/core: Inline transport_lun_remove_cmd()"
 
 drivers/target/target_core_transport.c | 31 ++++++++++++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)

Comments

Kleber Sacilotto de Souza March 13, 2020, 12:22 p.m. UTC | #1 
On 28.02.20 22:16, Pavel Zakharov wrote:
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-hwe/+bug/1862682
> 
> Disclaimer: First time submitting patch to Ubuntu kernel team, so apologies if
> the formatting is not correct. I’ve used the mailing list archives and
> https://wiki.ubuntu.com/Kernel/Dev/KernelPatches for reference.
> 
> iSCSI LUN deletion hangs because a reference is not dropped on the LUN being
> deleted until another command is sent from the same initiator. This was
> introduced in 5.3 because of code simplification. Note: this patch is for
> the hwe kernel for bionic.
> 
> [Impact]
> This greatly affects iSCSI Target workflows that regularly create and destroy
> LUNs.
> 
> [Fix]
> Revert the code simplification as it is incompatible with the iSCSI target
> driver.
> 
> [Test]
> Verified that reverting the original code resolves the hang when deleting iSCSI
> LUNs.
> 
> [Regression Risk]
> Very low. There are no code dependencies on the original code simplification.
> 
> 
> Bart Van Assche:
>   scsi: Revert "target/core: Inline transport_lun_remove_cmd()"
>  
>  drivers/target/target_core_transport.c | 31 ++++++++++++++++++++++++++++---
>  1 file changed, 28 insertions(+), 3 deletions(-)
> 

Applied to eoan/linux.

Thanks,
Kleber