| Message ID | 20240326161637.274890-1-roxana.nicolescu@canonical.com |
|---|---|
| Headers | show |
| Series | Remove getabis scripts | expand |
On Tue, Mar 26, 2024 at 05:16:36PM +0100, Roxana Nicolescu wrote: > BugLink: https://bugs.launchpad.net/bugs/2059143 > > SRU Justification > > [Impact] > With ABI checks removed from the tree (#LP2055685), there's no need to > download the buildinfo from a previous version. > > [Fix] > This is needed only in the main kernels. > 1. remove the common getabis script > 2. remove per kernel getabis file (this will be done with cranky fix) > > [Test] > Build test on cbd. No issue found. Also cranked the kernels in advance to > see if there were issues, but no issue was found. > > [Regression potential] > In the current cycle, the ABI checks have been removed and this is not > used anymore. No issues have been found. Now we're just removing an unused > feature, therefore the regression potential is none. Thanks for doing this cleanup. I think we can also remove debian.master/etc/getabis at this point, but overall this looks good to me. Acked-by: Andrea Righi <andrea.righi@canonical.com>
On 27/03/2024 07:35, Andrea Righi wrote: > On Tue, Mar 26, 2024 at 05:16:36PM +0100, Roxana Nicolescu wrote: >> BugLink: https://bugs.launchpad.net/bugs/2059143 >> >> SRU Justification >> >> [Impact] >> With ABI checks removed from the tree (#LP2055685), there's no need to >> download the buildinfo from a previous version. >> >> [Fix] >> This is needed only in the main kernels. >> 1. remove the common getabis script >> 2. remove per kernel getabis file (this will be done with cranky fix) >> >> [Test] >> Build test on cbd. No issue found. Also cranked the kernels in advance to >> see if there were issues, but no issue was found. >> >> [Regression potential] >> In the current cycle, the ABI checks have been removed and this is not >> used anymore. No issues have been found. Now we're just removing an unused >> feature, therefore the regression potential is none. > Thanks for doing this cleanup. > > I think we can also remove debian.master/etc/getabis at this point, but > overall this looks good to me. This will be done with cranky fix. Initially I wanted to do this here for the main kernels but I would have sent different patches for each series because the file differs a bit. So I chose the easy route. > Acked-by: Andrea Righi <andrea.righi@canonical.com>
On Wed, Mar 27, 2024 at 10:35:10AM +0100, Roxana Nicolescu wrote: > > On 27/03/2024 07:35, Andrea Righi wrote: > > On Tue, Mar 26, 2024 at 05:16:36PM +0100, Roxana Nicolescu wrote: > > > BugLink: https://bugs.launchpad.net/bugs/2059143 > > > > > > SRU Justification > > > > > > [Impact] > > > With ABI checks removed from the tree (#LP2055685), there's no need to > > > download the buildinfo from a previous version. > > > > > > [Fix] > > > This is needed only in the main kernels. > > > 1. remove the common getabis script > > > 2. remove per kernel getabis file (this will be done with cranky fix) > > > > > > [Test] > > > Build test on cbd. No issue found. Also cranked the kernels in advance to > > > see if there were issues, but no issue was found. > > > > > > [Regression potential] > > > In the current cycle, the ABI checks have been removed and this is not > > > used anymore. No issues have been found. Now we're just removing an unused > > > feature, therefore the regression potential is none. > > Thanks for doing this cleanup. > > > > I think we can also remove debian.master/etc/getabis at this point, but > > overall this looks good to me. > This will be done with cranky fix. Initially I wanted to do this here for > the main kernels but I > would have sent different patches for each series because the file differs a > bit. > So I chose the easy route. Sounds good, thanks for clarifying this. -Andrea
On 26.03.24 17:16, Roxana Nicolescu wrote: > BugLink: https://bugs.launchpad.net/bugs/2059143 > > SRU Justification > > [Impact] > With ABI checks removed from the tree (#LP2055685), there's no need to > download the buildinfo from a previous version. > > [Fix] > This is needed only in the main kernels. > 1. remove the common getabis script > 2. remove per kernel getabis file (this will be done with cranky fix) > > [Test] > Build test on cbd. No issue found. Also cranked the kernels in advance to > see if there were issues, but no issue was found. > > [Regression potential] > In the current cycle, the ABI checks have been removed and this is not > used anymore. No issues have been found. Now we're just removing an unused > feature, therefore the regression potential is none. > > Roxana Nicolescu (1): > UBUNTU: [Packaging] Remove getabis > > debian/scripts/misc/getabis | 222 ------------------------------------ > 1 file changed, 222 deletions(-) > delete mode 100755 debian/scripts/misc/getabis > Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 26.03.24 17:16, Roxana Nicolescu wrote: > BugLink: https://bugs.launchpad.net/bugs/2059143 > > SRU Justification > > [Impact] > With ABI checks removed from the tree (#LP2055685), there's no need to > download the buildinfo from a previous version. > > [Fix] > This is needed only in the main kernels. > 1. remove the common getabis script > 2. remove per kernel getabis file (this will be done with cranky fix) > > [Test] > Build test on cbd. No issue found. Also cranked the kernels in advance to > see if there were issues, but no issue was found. > > [Regression potential] > In the current cycle, the ABI checks have been removed and this is not > used anymore. No issues have been found. Now we're just removing an unused > feature, therefore the regression potential is none. > > Roxana Nicolescu (1): > UBUNTU: [Packaging] Remove getabis > > debian/scripts/misc/getabis | 222 ------------------------------------ > 1 file changed, 222 deletions(-) > delete mode 100755 debian/scripts/misc/getabis > Applied to mantic,jammy,focal:linux/master-next. Thanks. -Stefan
On Tue, Mar 26, 2024 at 05:16:36PM +0100, Roxana Nicolescu wrote: > BugLink: https://bugs.launchpad.net/bugs/2059143 > > SRU Justification > > [Impact] > With ABI checks removed from the tree (#LP2055685), there's no need to > download the buildinfo from a previous version. > > [Fix] > This is needed only in the main kernels. > 1. remove the common getabis script > 2. remove per kernel getabis file (this will be done with cranky fix) > > [Test] > Build test on cbd. No issue found. Also cranked the kernels in advance to > see if there were issues, but no issue was found. > > [Regression potential] > In the current cycle, the ABI checks have been removed and this is not > used anymore. No issues have been found. Now we're just removing an unused > feature, therefore the regression potential is none. > > Roxana Nicolescu (1): > UBUNTU: [Packaging] Remove getabis > > debian/scripts/misc/getabis | 222 ------------------------------------ > 1 file changed, 222 deletions(-) > delete mode 100755 debian/scripts/misc/getabis > > -- > 2.34.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team Applied to trusty,xenial,bionic:linux/master-next. Thanks!