| Message ID | 20240222163800.1467822-1-philip.cox@canonical.com |
|---|---|
| Headers | show |
| Series | x86: performance: tsc: Extend watchdog check exemption to 4-Sockets platform | expand |
On 22/02/2024 17:37, Philip Cox wrote: > BugLink: BugLink: https://bugs.launchpad.net/bugs/2054699 > > SRU Justification: > > [Impact] > Fix tsc clocksource on 4 sockets x86 servers was wrongly > judged as 'unstable' by 'jiffies' and other watchdogs, > and disabled > > [Fix] > cherry-pick > 233756a640be x86/tsc: Extend watchdog check exemption to 4-Sockets platform > from upstream fixes this > > [Test Plan] > This has been tested by intel, and has been upstreamed for a while. > > [Where problems could occur] > This is a fairly narrow change, and extends a behaviour > correction to cover up to 4-socket machines, rather > than just 2 socket machines > > -- > > > Feng Tang (1): > x86/tsc: Extend watchdog check exemption to 4-Sockets platform > > arch/x86/kernel/tsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Is it worth porting this to mantic as well? Acked-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
On Fri, 2024-02-23 at 11:12 +0100, Roxana Nicolescu wrote: > > On 22/02/2024 17:37, Philip Cox wrote: > > BugLink: BugLink: https://bugs.launchpad.net/bugs/2054699 > > ... > > -- > > > > > > Feng Tang (1): > > x86/tsc: Extend watchdog check exemption to 4-Sockets platform > > > > arch/x86/kernel/tsc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > Is it worth porting this to mantic as well? > Yes it is. I'll be sending out the mantic review shortly.
On 2/22/24 9:37 AM, Philip Cox wrote: > BugLink: BugLink: https://bugs.launchpad.net/bugs/2054699 > > SRU Justification: > > [Impact] > Fix tsc clocksource on 4 sockets x86 servers was wrongly > judged as 'unstable' by 'jiffies' and other watchdogs, > and disabled > > [Fix] > cherry-pick > 233756a640be x86/tsc: Extend watchdog check exemption to 4-Sockets platform > from upstream fixes this > > [Test Plan] > This has been tested by intel, and has been upstreamed for a while. > > [Where problems could occur] > This is a fairly narrow change, and extends a behaviour > correction to cover up to 4-socket machines, rather > than just 2 socket machines > > -- > > > Feng Tang (1): > x86/tsc: Extend watchdog check exemption to 4-Sockets platform > > arch/x86/kernel/tsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
On 22.02.24 17:37, Philip Cox wrote: > BugLink: BugLink: https://bugs.launchpad.net/bugs/2054699 > > SRU Justification: > > [Impact] > Fix tsc clocksource on 4 sockets x86 servers was wrongly > judged as 'unstable' by 'jiffies' and other watchdogs, > and disabled > > [Fix] > cherry-pick > 233756a640be x86/tsc: Extend watchdog check exemption to 4-Sockets platform > from upstream fixes this > > [Test Plan] > This has been tested by intel, and has been upstreamed for a while. > > [Where problems could occur] > This is a fairly narrow change, and extends a behaviour > correction to cover up to 4-socket machines, rather > than just 2 socket machines > > -- > > > Feng Tang (1): > x86/tsc: Extend watchdog check exemption to 4-Sockets platform > > arch/x86/kernel/tsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to jammy:linux/master-next. Thanks. -Stefan
BugLink: BugLink: https://bugs.launchpad.net/bugs/2054699 SRU Justification: [Impact] Fix tsc clocksource on 4 sockets x86 servers was wrongly judged as 'unstable' by 'jiffies' and other watchdogs, and disabled [Fix] cherry-pick 233756a640be x86/tsc: Extend watchdog check exemption to 4-Sockets platform from upstream fixes this [Test Plan] This has been tested by intel, and has been upstreamed for a while. [Where problems could occur] This is a fairly narrow change, and extends a behaviour correction to cover up to 4-socket machines, rather than just 2 socket machines -- Feng Tang (1): x86/tsc: Extend watchdog check exemption to 4-Sockets platform arch/x86/kernel/tsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)