mbox series

[SRU,Mantic,Jammy,0/1] CVE-2024-22705

Message ID 20240205203402.28665-1-bethany.jamison@canonical.com
Headers show
Series CVE-2024-22705 | expand

Message

Bethany Jamison Feb. 5, 2024, 8:34 p.m. UTC 
[Impact]

An issue was discovered in ksmbd in the Linux kernel before 6.6.10.
smb2_get_data_area_len in fs/smb/server/smb2misc.c can cause an
smb_strndup_from_utf16 out-of-bounds access because the relationship
between Name data and CreateContexts data is mishandled.

[Fix]

Clean cherry-pick.

[Test Case]

Compile and boot test.

[Regression Potential]

Issues could occur when opening smb2.

Namjae Jeon (1):
  ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()

 fs/smb/server/smb2misc.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

Comments

Stefan Bader Feb. 6, 2024, 8:03 a.m. UTC | #1 
On 05.02.24 21:34, Bethany Jamison wrote:
> [Impact]
> 
> An issue was discovered in ksmbd in the Linux kernel before 6.6.10.
> smb2_get_data_area_len in fs/smb/server/smb2misc.c can cause an
> smb_strndup_from_utf16 out-of-bounds access because the relationship
> between Name data and CreateContexts data is mishandled.
> 
> [Fix]
> 
> Clean cherry-pick.

A short explanation why there are 2 patches both claiming to be cherry 
picks would help. Assuming this is a case where git does some context 
fixing by magic.

> 
> [Test Case]
> 
> Compile and boot test.
> 
> [Regression Potential]
> 
> Issues could occur when opening smb2.
> 
> Namjae Jeon (1):
>    ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
> 
>   fs/smb/server/smb2misc.c | 15 ++++++++++++---
>   1 file changed, 12 insertions(+), 3 deletions(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Thibault Ferrante Feb. 6, 2024, 12:36 p.m. UTC | #2 
On 05-02-2024 21:34, Bethany Jamison wrote:
> [Impact]
> 
> An issue was discovered in ksmbd in the Linux kernel before 6.6.10.
> smb2_get_data_area_len in fs/smb/server/smb2misc.c can cause an
> smb_strndup_from_utf16 out-of-bounds access because the relationship
> between Name data and CreateContexts data is mishandled.
> 
> [Fix]
> 
> Clean cherry-pick.
> 
> [Test Case]
> 
> Compile and boot test.
> 
> [Regression Potential]
> 
> Issues could occur when opening smb2.
> 
> Namjae Jeon (1):
>    ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
> 
>   fs/smb/server/smb2misc.c | 15 ++++++++++++---
>   1 file changed, 12 insertions(+), 3 deletions(-)
> 

Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>

--
Thibault
Andrei Gherzan Feb. 6, 2024, 1:20 p.m. UTC | #3 
On 24/02/05 02:34PM, Bethany Jamison wrote:
> [Impact]
> 
> An issue was discovered in ksmbd in the Linux kernel before 6.6.10.
> smb2_get_data_area_len in fs/smb/server/smb2misc.c can cause an
> smb_strndup_from_utf16 out-of-bounds access because the relationship
> between Name data and CreateContexts data is mishandled.
> 
> [Fix]
> 
> Clean cherry-pick.
> 
> [Test Case]
> 
> Compile and boot test.
> 
> [Regression Potential]
> 
> Issues could occur when opening smb2.
> 
> Namjae Jeon (1):
>   ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
> 
>  fs/smb/server/smb2misc.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Roxana Nicolescu Feb. 12, 2024, 8 a.m. UTC | #4 
On 05/02/2024 21:34, Bethany Jamison wrote:
> [Impact]
>
> An issue was discovered in ksmbd in the Linux kernel before 6.6.10.
> smb2_get_data_area_len in fs/smb/server/smb2misc.c can cause an
> smb_strndup_from_utf16 out-of-bounds access because the relationship
> between Name data and CreateContexts data is mishandled.
>
> [Fix]
>
> Clean cherry-pick.
>
> [Test Case]
>
> Compile and boot test.
>
> [Regression Potential]
>
> Issues could occur when opening smb2.
>
> Namjae Jeon (1):
>    ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
>
>   fs/smb/server/smb2misc.c | 15 ++++++++++++---
>   1 file changed, 12 insertions(+), 3 deletions(-)
>
Applied to mantic, jammy master-next branches. Thanks!