mbox series

[SRU,M,0/1] The display becomes frozen after some time when a HDMI device is connected

Message ID 20240131104647.40374-1-roxana.nicolescu@canonical.com
Headers show
Series The display becomes frozen after some time when a HDMI device is connected | expand

Message

Roxana Nicolescu Jan. 31, 2024, 10:46 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2049027

SRU Justification:

[Impact]

Multiple users have reported frozen displays when external HDMI device
is connected on systems with intel graphics chipsets.

[Fix]

* backport 49e0a85ec344: "drm/i915/dmc: Don't enable any pipe DMC events"
from 6.6.9

[Test Plan]

* Tested on Intel TigerLake with iris Xe Graphics and no issues so far.
It seems it affects mostly Alder Lake though, but at least it does not
cause any issues on other models.
* It has also been tested upstream https://gitlab.freedesktop.org/drm/intel/-/issues/8685

[Where problems could occur]
* We could see issues on systems with Intel Graphics when HDMI devices
are connected during power state changes.

Ville Syrjälä (1):
  drm/i915/dmc: Don't enable any pipe DMC events

 drivers/gpu/drm/i915/display/intel_dmc.c | 43 ++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 2 deletions(-)

Comments

Thibault Ferrante Jan. 31, 2024, 1:55 p.m. UTC | #1
On 31-01-2024 11:46, Roxana Nicolescu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2049027
> 
> SRU Justification:
> 
> [Impact]
> 
> Multiple users have reported frozen displays when external HDMI device
> is connected on systems with intel graphics chipsets.
> 
> [Fix]
> 
> * backport 49e0a85ec344: "drm/i915/dmc: Don't enable any pipe DMC events"
> from 6.6.9
> 
> [Test Plan]
> 
> * Tested on Intel TigerLake with iris Xe Graphics and no issues so far.
> It seems it affects mostly Alder Lake though, but at least it does not
> cause any issues on other models.
> * It has also been tested upstream https://gitlab.freedesktop.org/drm/intel/-/issues/8685
> 
> [Where problems could occur]
> * We could see issues on systems with Intel Graphics when HDMI devices
> are connected during power state changes.
> 
> Ville Syrjälä (1):
>    drm/i915/dmc: Don't enable any pipe DMC events
> 
>   drivers/gpu/drm/i915/display/intel_dmc.c | 43 ++++++++++++++++++++++--
>   1 file changed, 41 insertions(+), 2 deletions(-)
> 

Is there a specific reason to cherry-pick the already cherry-picked commit ?

Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>

--
Thibault
Roxana Nicolescu Jan. 31, 2024, 2:04 p.m. UTC | #2
On 31/01/2024 14:55, Thibault Ferrante wrote:
> On 31-01-2024 11:46, Roxana Nicolescu wrote:
>> BugLink: https://bugs.launchpad.net/bugs/2049027
>>
>> SRU Justification:
>>
>> [Impact]
>>
>> Multiple users have reported frozen displays when external HDMI device
>> is connected on systems with intel graphics chipsets.
>>
>> [Fix]
>>
>> * backport 49e0a85ec344: "drm/i915/dmc: Don't enable any pipe DMC 
>> events"
>> from 6.6.9
>>
>> [Test Plan]
>>
>> * Tested on Intel TigerLake with iris Xe Graphics and no issues so far.
>> It seems it affects mostly Alder Lake though, but at least it does not
>> cause any issues on other models.
>> * It has also been tested upstream 
>> https://gitlab.freedesktop.org/drm/intel/-/issues/8685
>>
>> [Where problems could occur]
>> * We could see issues on systems with Intel Graphics when HDMI devices
>> are connected during power state changes.
>>
>> Ville Syrjälä (1):
>>    drm/i915/dmc: Don't enable any pipe DMC events
>>
>>   drivers/gpu/drm/i915/display/intel_dmc.c | 43 ++++++++++++++++++++++--
>>   1 file changed, 41 insertions(+), 2 deletions(-)
>>
>
> Is there a specific reason to cherry-pick the already cherry-picked 
> commit ?
>
> Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>
>
> -- 
> Thibault
>
I cherry picked the wrong commit. I'll fix it when applying it. Thanks 
for spotting this.
Stefan Bader Feb. 1, 2024, 8:33 a.m. UTC | #3
On 31.01.24 15:04, Roxana Nicolescu wrote:
> 
> On 31/01/2024 14:55, Thibault Ferrante wrote:
>> On 31-01-2024 11:46, Roxana Nicolescu wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/2049027
>>>
>>> SRU Justification:
>>>
>>> [Impact]
>>>
>>> Multiple users have reported frozen displays when external HDMI device
>>> is connected on systems with intel graphics chipsets.
>>>
>>> [Fix]
>>>
>>> * backport 49e0a85ec344: "drm/i915/dmc: Don't enable any pipe DMC 
>>> events"
>>> from 6.6.9
>>>
>>> [Test Plan]
>>>
>>> * Tested on Intel TigerLake with iris Xe Graphics and no issues so far.
>>> It seems it affects mostly Alder Lake though, but at least it does not
>>> cause any issues on other models.
>>> * It has also been tested upstream 
>>> https://gitlab.freedesktop.org/drm/intel/-/issues/8685
>>>
>>> [Where problems could occur]
>>> * We could see issues on systems with Intel Graphics when HDMI devices
>>> are connected during power state changes.
>>>
>>> Ville Syrjälä (1):
>>>    drm/i915/dmc: Don't enable any pipe DMC events
>>>
>>>   drivers/gpu/drm/i915/display/intel_dmc.c | 43 ++++++++++++++++++++++--
>>>   1 file changed, 41 insertions(+), 2 deletions(-)
>>>
>>
>> Is there a specific reason to cherry-pick the already cherry-picked 
>> commit ?
>>
>> Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>
>>
>> -- 
>> Thibault
>>
> I cherry picked the wrong commit. I'll fix it when applying it. Thanks 
> for spotting this.
> 

Actually I think this is correct. Just that the first cherry picked is 
already the way it is in upstream Linus...
Stefan Bader Feb. 1, 2024, 4:43 p.m. UTC | #4
On 31.01.24 11:46, Roxana Nicolescu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2049027
> 
> SRU Justification:
> 
> [Impact]
> 
> Multiple users have reported frozen displays when external HDMI device
> is connected on systems with intel graphics chipsets.
> 
> [Fix]
> 
> * backport 49e0a85ec344: "drm/i915/dmc: Don't enable any pipe DMC events"
> from 6.6.9
> 
> [Test Plan]
> 
> * Tested on Intel TigerLake with iris Xe Graphics and no issues so far.
> It seems it affects mostly Alder Lake though, but at least it does not
> cause any issues on other models.
> * It has also been tested upstream https://gitlab.freedesktop.org/drm/intel/-/issues/8685
> 
> [Where problems could occur]
> * We could see issues on systems with Intel Graphics when HDMI devices
> are connected during power state changes.
> 
> Ville Syrjälä (1):
>    drm/i915/dmc: Don't enable any pipe DMC events
> 
>   drivers/gpu/drm/i915/display/intel_dmc.c | 43 ++++++++++++++++++++++--
>   1 file changed, 41 insertions(+), 2 deletions(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Roxana Nicolescu Feb. 2, 2024, 6:05 a.m. UTC | #5
On 31-01-2024 11:46, Roxana Nicolescu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2049027
>
> SRU Justification:
>
> [Impact]
>
> Multiple users have reported frozen displays when external HDMI device
> is connected on systems with intel graphics chipsets.
>
> [Fix]
>
> * backport 49e0a85ec344: "drm/i915/dmc: Don't enable any pipe DMC events"
> from 6.6.9
>
> [Test Plan]
>
> * Tested on Intel TigerLake with iris Xe Graphics and no issues so far.
> It seems it affects mostly Alder Lake though, but at least it does not
> cause any issues on other models.
> * It has also been tested upstream https://gitlab.freedesktop.org/drm/intel/-/issues/8685
>
> [Where problems could occur]
> * We could see issues on systems with Intel Graphics when HDMI devices
> are connected during power state changes.
>
> Ville Syrjälä (1):
>    drm/i915/dmc: Don't enable any pipe DMC events
>
>   drivers/gpu/drm/i915/display/intel_dmc.c | 43 ++++++++++++++++++++++--
>   1 file changed, 41 insertions(+), 2 deletions(-)
>
Applied to mantic master-next branch. Thanks!