mbox series

[0/1,SRU,J] Add quirk to disable i915 fastboot on B&R PC

Message ID 20231229013824.7215-1-ivan.hu@canonical.com
Headers show
Series Add quirk to disable i915 fastboot on B&R PC | expand

Message

Ivan Hu Dec. 29, 2023, 1:38 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2047630

[Impact]
Some displays connect to the B&R PC device got the garbled display

[Fix]
The issue will disappear after commit 5ac860cc52540df8bca27e0bb25b6744df67e8f0,
but these patches cannot be backported from 5.19 to 5.15. So add quirk
to force disable the i915 fastboot on the device to fix the abnormal display

[Test Case]
1. Connect the display and power on the B&R PC device
2. Check the display for boot up

[Where problems could occur]
Quirk only on the B&R PCs. Risk of regression is low

Ivan Hu (1):
  i915: force disable fastboot quirk

 drivers/gpu/drm/i915/display/intel_display.c |  3 +++
 drivers/gpu/drm/i915/display/intel_quirks.c  | 25 ++++++++++++++++++++
 drivers/gpu/drm/i915/i915_drv.h              |  1 +
 3 files changed, 29 insertions(+)

Comments

Jose Ogando Jan. 2, 2024, 8:56 a.m. UTC | #1
Seems straightforward.

Acked-by: Jose Ogando <jose.ogando@canonical.com>

On Fri, 2023-12-29 at 09:38 +0800, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2047630
> 
> [Impact]
> Some displays connect to the B&R PC device got the garbled display
> 
> [Fix]
> The issue will disappear after commit
> 5ac860cc52540df8bca27e0bb25b6744df67e8f0,
> but these patches cannot be backported from 5.19 to 5.15. So add
> quirk
> to force disable the i915 fastboot on the device to fix the abnormal
> display
> 
> [Test Case]
> 1. Connect the display and power on the B&R PC device
> 2. Check the display for boot up
> 
> [Where problems could occur]
> Quirk only on the B&R PCs. Risk of regression is low
> 
> Ivan Hu (1):
>   i915: force disable fastboot quirk
> 
>  drivers/gpu/drm/i915/display/intel_display.c |  3 +++
>  drivers/gpu/drm/i915/display/intel_quirks.c  | 25
> ++++++++++++++++++++
>  drivers/gpu/drm/i915/i915_drv.h              |  1 +
>  3 files changed, 29 insertions(+)
> 
> -- 
> 2.34.1
> 
>
Manuel Diewald Jan. 3, 2024, 1:33 p.m. UTC | #2
On Fri, Dec 29, 2023 at 09:38:23AM +0800, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2047630
> 
> [Impact]
> Some displays connect to the B&R PC device got the garbled display
> 
> [Fix]
> The issue will disappear after commit 5ac860cc52540df8bca27e0bb25b6744df67e8f0,
> but these patches cannot be backported from 5.19 to 5.15. So add quirk
> to force disable the i915 fastboot on the device to fix the abnormal display
> 
> [Test Case]
> 1. Connect the display and power on the B&R PC device
> 2. Check the display for boot up
> 
> [Where problems could occur]
> Quirk only on the B&R PCs. Risk of regression is low
> 
> Ivan Hu (1):
>   i915: force disable fastboot quirk
> 
>  drivers/gpu/drm/i915/display/intel_display.c |  3 +++
>  drivers/gpu/drm/i915/display/intel_quirks.c  | 25 ++++++++++++++++++++
>  drivers/gpu/drm/i915/i915_drv.h              |  1 +
>  3 files changed, 29 insertions(+)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Roxana Nicolescu Jan. 4, 2024, 7:45 p.m. UTC | #3
On 29/12/2023 02:38, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2047630
>
> [Impact]
> Some displays connect to the B&R PC device got the garbled display
>
> [Fix]
> The issue will disappear after commit 5ac860cc52540df8bca27e0bb25b6744df67e8f0,
> but these patches cannot be backported from 5.19 to 5.15. So add quirk
> to force disable the i915 fastboot on the device to fix the abnormal display
>
> [Test Case]
> 1. Connect the display and power on the B&R PC device
> 2. Check the display for boot up
>
> [Where problems could occur]
> Quirk only on the B&R PCs. Risk of regression is low
>
> Ivan Hu (1):
>    i915: force disable fastboot quirk
>
>   drivers/gpu/drm/i915/display/intel_display.c |  3 +++
>   drivers/gpu/drm/i915/display/intel_quirks.c  | 25 ++++++++++++++++++++
>   drivers/gpu/drm/i915/i915_drv.h              |  1 +
>   3 files changed, 29 insertions(+)
>
Applied to jammy master-next branch. Thanks!