mbox series

[SRU,Focal/Jammy/Lunar,0/1] CVE-2023-4881

Message ID 20230918213135.50180-1-yuxuan.luo@canonical.com
Headers show
Series CVE-2023-4881 | expand

Message

Yuxuan Luo Sept. 18, 2023, 9:31 p.m. UTC
[Impact]
A stack based out-of-bounds write flaw was found in the netfilter
subsystem in the Linux kernel. If the expression length is a multiple of
4 (register size), the `nft_exthdr_eval` family of functions writes 4
NULL bytes past the end of the `regs` argument, leading to stack
corruption and potential information disclosure or a denial of service.

[Backport]
The fix commit fixes four occurrences introduced by different break
commits. Since not all break commits are present in the Focal tree, some
hunks are ignored and the rest are backported.
For Jammy and Lunar, it is a clean cherry pick.

[Test]
Only boot test is performed so far, more comprehensive tests will come
in few days.

[Potential Regression]
The regression should be limited within the modified file.

Florian Westphal (1):
  netfilter: nftables: exthdr: fix 4-byte stack OOB write

 net/netfilter/nft_exthdr.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

Comments

Tim Gardner Sept. 19, 2023, 12:40 p.m. UTC | #1
On 9/18/23 3:31 PM, Yuxuan Luo wrote:
> [Impact]
> A stack based out-of-bounds write flaw was found in the netfilter
> subsystem in the Linux kernel. If the expression length is a multiple of
> 4 (register size), the `nft_exthdr_eval` family of functions writes 4
> NULL bytes past the end of the `regs` argument, leading to stack
> corruption and potential information disclosure or a denial of service.
> 
> [Backport]
> The fix commit fixes four occurrences introduced by different break
> commits. Since not all break commits are present in the Focal tree, some
> hunks are ignored and the rest are backported.
> For Jammy and Lunar, it is a clean cherry pick.
> 
> [Test]
> Only boot test is performed so far, more comprehensive tests will come
> in few days.
> 
> [Potential Regression]
> The regression should be limited within the modified file.
> 
> Florian Westphal (1):
>    netfilter: nftables: exthdr: fix 4-byte stack OOB write
> 
>   net/netfilter/nft_exthdr.c | 22 ++++++++++++++--------
>   1 file changed, 14 insertions(+), 8 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Roxana Nicolescu Sept. 20, 2023, 8:03 a.m. UTC | #2
On 18/09/2023 23:31, Yuxuan Luo wrote:
> [Impact]
> A stack based out-of-bounds write flaw was found in the netfilter
> subsystem in the Linux kernel. If the expression length is a multiple of
> 4 (register size), the `nft_exthdr_eval` family of functions writes 4
> NULL bytes past the end of the `regs` argument, leading to stack
> corruption and potential information disclosure or a denial of service.
>
> [Backport]
> The fix commit fixes four occurrences introduced by different break
> commits. Since not all break commits are present in the Focal tree, some
> hunks are ignored and the rest are backported.
> For Jammy and Lunar, it is a clean cherry pick.
>
> [Test]
> Only boot test is performed so far, more comprehensive tests will come
> in few days.
>
> [Potential Regression]
> The regression should be limited within the modified file.
>
> Florian Westphal (1):
>    netfilter: nftables: exthdr: fix 4-byte stack OOB write
>
>   net/netfilter/nft_exthdr.c | 22 ++++++++++++++--------
>   1 file changed, 14 insertions(+), 8 deletions(-)
>
Acked-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
Roxana Nicolescu Sept. 20, 2023, 8:39 a.m. UTC | #3
On 18/09/2023 23:31, Yuxuan Luo wrote:
> [Impact]
> A stack based out-of-bounds write flaw was found in the netfilter
> subsystem in the Linux kernel. If the expression length is a multiple of
> 4 (register size), the `nft_exthdr_eval` family of functions writes 4
> NULL bytes past the end of the `regs` argument, leading to stack
> corruption and potential information disclosure or a denial of service.
>
> [Backport]
> The fix commit fixes four occurrences introduced by different break
> commits. Since not all break commits are present in the Focal tree, some
> hunks are ignored and the rest are backported.
> For Jammy and Lunar, it is a clean cherry pick.
>
> [Test]
> Only boot test is performed so far, more comprehensive tests will come
> in few days.
>
> [Potential Regression]
> The regression should be limited within the modified file.
>
> Florian Westphal (1):
>    netfilter: nftables: exthdr: fix 4-byte stack OOB write
>
>   net/netfilter/nft_exthdr.c | 22 ++++++++++++++--------
>   1 file changed, 14 insertions(+), 8 deletions(-)
>
Applied to focal,jammy,lunar:master-next. Thanks! CVE reference was 
missing in the focal patch.

Roxana
Yuxuan Luo Sept. 27, 2023, 1:51 p.m. UTC | #4
This patch also applies to Jammy-OEM-6.1. Sorry for the inconvenience.

On 9/20/23 04:39, Roxana Nicolescu wrote:
>
> On 18/09/2023 23:31, Yuxuan Luo wrote:
>> [Impact]
>> A stack based out-of-bounds write flaw was found in the netfilter
>> subsystem in the Linux kernel. If the expression length is a multiple of
>> 4 (register size), the `nft_exthdr_eval` family of functions writes 4
>> NULL bytes past the end of the `regs` argument, leading to stack
>> corruption and potential information disclosure or a denial of service.
>>
>> [Backport]
>> The fix commit fixes four occurrences introduced by different break
>> commits. Since not all break commits are present in the Focal tree, some
>> hunks are ignored and the rest are backported.
>> For Jammy and Lunar, it is a clean cherry pick.
>>
>> [Test]
>> Only boot test is performed so far, more comprehensive tests will come
>> in few days.
>>
>> [Potential Regression]
>> The regression should be limited within the modified file.
>>
>> Florian Westphal (1):
>>    netfilter: nftables: exthdr: fix 4-byte stack OOB write
>>
>>   net/netfilter/nft_exthdr.c | 22 ++++++++++++++--------
>>   1 file changed, 14 insertions(+), 8 deletions(-)
>>
> Applied to focal,jammy,lunar:master-next. Thanks! CVE reference was 
> missing in the focal patch.
>
> Roxana
>
Roxana Nicolescu Sept. 28, 2023, 7:46 a.m. UTC | #5
On 27/09/2023 15:51, Yuxuan Luo wrote:
> This patch also applies to Jammy-OEM-6.1. Sorry for the inconvenience.
>
> On 9/20/23 04:39, Roxana Nicolescu wrote:
>>
>> On 18/09/2023 23:31, Yuxuan Luo wrote:
>>> [Impact]
>>> A stack based out-of-bounds write flaw was found in the netfilter
>>> subsystem in the Linux kernel. If the expression length is a 
>>> multiple of
>>> 4 (register size), the `nft_exthdr_eval` family of functions writes 4
>>> NULL bytes past the end of the `regs` argument, leading to stack
>>> corruption and potential information disclosure or a denial of service.
>>>
>>> [Backport]
>>> The fix commit fixes four occurrences introduced by different break
>>> commits. Since not all break commits are present in the Focal tree, 
>>> some
>>> hunks are ignored and the rest are backported.
>>> For Jammy and Lunar, it is a clean cherry pick.
>>>
>>> [Test]
>>> Only boot test is performed so far, more comprehensive tests will come
>>> in few days.
>>>
>>> [Potential Regression]
>>> The regression should be limited within the modified file.
>>>
>>> Florian Westphal (1):
>>>    netfilter: nftables: exthdr: fix 4-byte stack OOB write
>>>
>>>   net/netfilter/nft_exthdr.c | 22 ++++++++++++++--------
>>>   1 file changed, 14 insertions(+), 8 deletions(-)
>>>
>> Applied to focal,jammy,lunar:master-next. Thanks! CVE reference was 
>> missing in the focal patch.
>>
>> Roxana
>>
>
Adding Timo as CC.
Timo Aaltonen Sept. 28, 2023, 11:38 a.m. UTC | #6
Yuxuan Luo kirjoitti 19.9.2023 klo 0.31:
> [Impact]
> A stack based out-of-bounds write flaw was found in the netfilter
> subsystem in the Linux kernel. If the expression length is a multiple of
> 4 (register size), the `nft_exthdr_eval` family of functions writes 4
> NULL bytes past the end of the `regs` argument, leading to stack
> corruption and potential information disclosure or a denial of service.
> 
> [Backport]
> The fix commit fixes four occurrences introduced by different break
> commits. Since not all break commits are present in the Focal tree, some
> hunks are ignored and the rest are backported.
> For Jammy and Lunar, it is a clean cherry pick.
> 
> [Test]
> Only boot test is performed so far, more comprehensive tests will come
> in few days.
> 
> [Potential Regression]
> The regression should be limited within the modified file.
> 
> Florian Westphal (1):
>    netfilter: nftables: exthdr: fix 4-byte stack OOB write
> 
>   net/netfilter/nft_exthdr.c | 22 ++++++++++++++--------
>   1 file changed, 14 insertions(+), 8 deletions(-)
> 

applied to oem-6.1, thanks