mbox series

[SRU,F,J:linux-bluefield,0/1] Enable CONFIG_EFI_VARS_PSTORE as build-in

Message ID 20230726042634.3773-1-witu@nvidia.com
Headers show
Series Enable CONFIG_EFI_VARS_PSTORE as build-in | expand

Message

William Tu July 26, 2023, 4:26 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1978079

There is an issue that pstore doesn't get loaded so it doesn't clean up stale
logs when system boots, causing EFI-back storage overflow. This problem affects
Ubuntu 20.04 and 22.04. A quick fix would be to configure CONFIG_EFI_VARS_PSTORE=y
so that it's always available.

William Tu (1):
  UBUNTU: [Config] bluefield: Enable CONFIG_EFI_VARS_PSTORE as build-in

 debian.bluefield/config/annotations | 1 +
 1 file changed, 1 insertion(+)

Comments

Tim Gardner July 26, 2023, 12:44 p.m. UTC | #1 
On 7/25/23 10:26 PM, William Tu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1978079
> 
> There is an issue that pstore doesn't get loaded so it doesn't clean up stale
> logs when system boots, causing EFI-back storage overflow. This problem affects
> Ubuntu 20.04 and 22.04. A quick fix would be to configure CONFIG_EFI_VARS_PSTORE=y
> so that it's always available.
> 
> William Tu (1):
>    UBUNTU: [Config] bluefield: Enable CONFIG_EFI_VARS_PSTORE as build-in
> 
>   debian.bluefield/config/annotations | 1 +
>   1 file changed, 1 insertion(+)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

You need to target linux-bluefield in the LP bug.
William Tu July 26, 2023, 2:53 p.m. UTC | #2 
Hi Tim,
I reuse the old buglink, should I create a new LP bug targeting linux-bluefield?
Thanks
William

From: Tim Gardner <tim.gardner@canonical.com>
Date: Wednesday, July 26, 2023 at 5:44 AM
To: William Tu <witu@nvidia.com>, kernel-team@lists.ubuntu.com <kernel-team@lists.ubuntu.com>
Cc: dann.frazier@canonical.com <dann.frazier@canonical.com>, Vladimir Sokolovsky <vlad@nvidia.com>, Tony Duan <yifeid@nvidia.com>, Bodong Wang <bodong@nvidia.com>, Chris Mi <cmi@nvidia.com>
Subject: ACK/Cmnt: [SRU][F, J:linux-bluefield][PATCH 0/1] Enable CONFIG_EFI_VARS_PSTORE as build-in
External email: Use caution opening links or attachments


On 7/25/23 10:26 PM, William Tu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1978079
>
> There is an issue that pstore doesn't get loaded so it doesn't clean up stale
> logs when system boots, causing EFI-back storage overflow. This problem affects
> Ubuntu 20.04 and 22.04. A quick fix would be to configure CONFIG_EFI_VARS_PSTORE=y
> so that it's always available.
>
> William Tu (1):
>    UBUNTU: [Config] bluefield: Enable CONFIG_EFI_VARS_PSTORE as build-in
>
>   debian.bluefield/config/annotations | 1 +
>   1 file changed, 1 insertion(+)
>
Acked-by: Tim Gardner <tim.gardner@canonical.com>

You need to target linux-bluefield in the LP bug.
--
-----------
Tim Gardner
Canonical, Inc
Tim Gardner July 26, 2023, 3:38 p.m. UTC | #3 
On 7/26/23 8:53 AM, William Tu wrote:
> Hi Tim,
> 
> I reuse the old buglink, should I create a new LP bug targeting 
> linux-bluefield?
> 
> Thanks
> 
> William
> 

Since the kernel patch is related, just add linux-bluefield as a target 
to the bug.
Bartlomiej Zolnierkiewicz Aug. 4, 2023, 4:13 p.m. UTC | #4 
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>

On Wed, Jul 26, 2023 at 6:27 AM William Tu <witu@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1978079
>
> There is an issue that pstore doesn't get loaded so it doesn't clean up stale
> logs when system boots, causing EFI-back storage overflow. This problem affects
> Ubuntu 20.04 and 22.04. A quick fix would be to configure CONFIG_EFI_VARS_PSTORE=y
> so that it's always available.
>
> William Tu (1):
>   UBUNTU: [Config] bluefield: Enable CONFIG_EFI_VARS_PSTORE as build-in
>
>  debian.bluefield/config/annotations | 1 +
>  1 file changed, 1 insertion(+)
>
Bartlomiej Zolnierkiewicz Aug. 7, 2023, 2:19 p.m. UTC | #5 
Hi William,

NAK for focal:bluefield as you need to provide a separate patch for it
(this one applies only to jammy:bluefield). Sorry for not noticing
this earlier.

Please also note that for the focal kernel both
debian.bluefield/config/annotations and
debian.bluefield/config/config.common.ubuntu files need to be
modified.

ACK holds for jammy:bluefield.

--
Best regards,
Bartlomiej

On Fri, Aug 4, 2023 at 6:13 PM Bartlomiej Zolnierkiewicz
<bartlomiej.zolnierkiewicz@canonical.com> wrote:
>
> Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>
>
> On Wed, Jul 26, 2023 at 6:27 AM William Tu <witu@nvidia.com> wrote:
> >
> > BugLink: https://bugs.launchpad.net/bugs/1978079
> >
> > There is an issue that pstore doesn't get loaded so it doesn't clean up stale
> > logs when system boots, causing EFI-back storage overflow. This problem affects
> > Ubuntu 20.04 and 22.04. A quick fix would be to configure CONFIG_EFI_VARS_PSTORE=y
> > so that it's always available.
> >
> > William Tu (1):
> >   UBUNTU: [Config] bluefield: Enable CONFIG_EFI_VARS_PSTORE as build-in
> >
> >  debian.bluefield/config/annotations | 1 +
> >  1 file changed, 1 insertion(+)
> >
William Tu Aug. 7, 2023, 6:37 p.m. UTC | #6 
Hi Bartlomiej,

Thanks, I will send another patch for focal.
William

From: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>
Date: Monday, August 7, 2023 at 7:19 AM
To: William Tu <witu@nvidia.com>
Cc: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>, Dann Frazier <dann.frazier@canonical.com>, Vladimir Sokolovsky <vlad@nvidia.com>, Tony Duan <yifeid@nvidia.com>, Bodong Wang <bodong@nvidia.com>, Chris Mi <cmi@nvidia.com>
Subject: Re: ACK: [SRU][F, J:linux-bluefield][PATCH 0/1] Enable CONFIG_EFI_VARS_PSTORE as build-in
External email: Use caution opening links or attachments


Hi William,

NAK for focal:bluefield as you need to provide a separate patch for it
(this one applies only to jammy:bluefield). Sorry for not noticing
this earlier.

Please also note that for the focal kernel both
debian.bluefield/config/annotations and
debian.bluefield/config/config.common.ubuntu files need to be
modified.

ACK holds for jammy:bluefield.

--
Best regards,
Bartlomiej

On Fri, Aug 4, 2023 at 6:13 PM Bartlomiej Zolnierkiewicz
<bartlomiej.zolnierkiewicz@canonical.com> wrote:
>
> Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>
>
> On Wed, Jul 26, 2023 at 6:27 AM William Tu <witu@nvidia.com> wrote:
> >
> > BugLink: https://bugs.launchpad.net/bugs/1978079
> >
> > There is an issue that pstore doesn't get loaded so it doesn't clean up stale
> > logs when system boots, causing EFI-back storage overflow. This problem affects
> > Ubuntu 20.04 and 22.04. A quick fix would be to configure CONFIG_EFI_VARS_PSTORE=y
> > so that it's always available.
> >
> > William Tu (1):
> >   UBUNTU: [Config] bluefield: Enable CONFIG_EFI_VARS_PSTORE as build-in
> >
> >  debian.bluefield/config/annotations | 1 +
> >  1 file changed, 1 insertion(+)
> >
Bartlomiej Zolnierkiewicz Aug. 17, 2023, 3:24 p.m. UTC | #7 
Applied to jammy:linux-bluefield/master-next. Thanks.

--
Best regards,
Bartlomiej

On Wed, Jul 26, 2023 at 6:27 AM William Tu <witu@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1978079
>
> There is an issue that pstore doesn't get loaded so it doesn't clean up stale
> logs when system boots, causing EFI-back storage overflow. This problem affects
> Ubuntu 20.04 and 22.04. A quick fix would be to configure CONFIG_EFI_VARS_PSTORE=y
> so that it's always available.
>
> William Tu (1):
>   UBUNTU: [Config] bluefield: Enable CONFIG_EFI_VARS_PSTORE as build-in
>
>  debian.bluefield/config/annotations | 1 +
>  1 file changed, 1 insertion(+)
>