mbox series

[SRU,Jammy:linux-intel-iotg,0/2] remove debug kernel notice in dmesg caused by trace_printk()

Message ID 20230718123740.74512-1-jianhui.lee@canonical.com
Headers show
Series remove debug kernel notice in dmesg caused by trace_printk() | expand

Message

Jian Hui Lee July 18, 2023, 12:37 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2028059

[Impact]
a test kernel notice in dmesg would confuse users.

[Test Plan]
1. compile test.
2. install the kernel and boot into it.
3. check there is no test kernel notice in dmesg.

[Regression potential]
low. remove/replace trace_printk does not affect the functions.

----------------------------------------------------------------
Jian Hui Lee (2):
  UBUNTU: SAUCE: (no-up) net: stmmac: replace trace_printk with
    netif_dbg
  Revert "igc: Enable trace for HW TX Timestamp AF_XDP ZC"

 drivers/net/ethernet/intel/igc/igc_main.c         | 5 -----
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

Comments

Tim Gardner July 18, 2023, 1:20 p.m. UTC | #1 
On 7/18/23 6:37 AM, Jian Hui Lee wrote:
> BugLink: https://bugs.launchpad.net/bugs/2028059
> 
> [Impact]
> a test kernel notice in dmesg would confuse users.
> 
> [Test Plan]
> 1. compile test.
> 2. install the kernel and boot into it.
> 3. check there is no test kernel notice in dmesg.
> 
> [Regression potential]
> low. remove/replace trace_printk does not affect the functions.
> 
> ----------------------------------------------------------------
> Jian Hui Lee (2):
>    UBUNTU: SAUCE: (no-up) net: stmmac: replace trace_printk with
>      netif_dbg
>    Revert "igc: Enable trace for HW TX Timestamp AF_XDP ZC"
> 
>   drivers/net/ethernet/intel/igc/igc_main.c         | 5 -----
>   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>   2 files changed, 1 insertion(+), 6 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Philip Cox July 21, 2023, 3:01 p.m. UTC | #2 
On Tue, 2023-07-18 at 20:37 +0800, Jian Hui Lee wrote:
> BugLink: https://bugs.launchpad.net/bugs/2028059
> 
> [Impact]
> a test kernel notice in dmesg would confuse users.
> 
> [Test Plan]
> 1. compile test.
> 2. install the kernel and boot into it.
> 3. check there is no test kernel notice in dmesg.
> 
> [Regression potential]
> low. remove/replace trace_printk does not affect the functions.
> 
> ----------------------------------------------------------------
> Jian Hui Lee (2):
>   UBUNTU: SAUCE: (no-up) net: stmmac: replace trace_printk with
>     netif_dbg
>   Revert "igc: Enable trace for HW TX Timestamp AF_XDP ZC"
> 
>  drivers/net/ethernet/intel/igc/igc_main.c         | 5 -----
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>  2 files changed, 1 insertion(+), 6 deletions(-)
> 
> -- 
> 2.34.1
> 
>
Jian Hui Lee July 24, 2023, 6:33 a.m. UTC | #3 
applied. thanks.

On Tue, Jul 18, 2023 at 8:38 PM Jian Hui Lee <jianhui.lee@canonical.com>
wrote:

> BugLink: https://bugs.launchpad.net/bugs/2028059
>
> [Impact]
> a test kernel notice in dmesg would confuse users.
>
> [Test Plan]
> 1. compile test.
> 2. install the kernel and boot into it.
> 3. check there is no test kernel notice in dmesg.
>
> [Regression potential]
> low. remove/replace trace_printk does not affect the functions.
>
> ----------------------------------------------------------------
> Jian Hui Lee (2):
>   UBUNTU: SAUCE: (no-up) net: stmmac: replace trace_printk with
>     netif_dbg
>   Revert "igc: Enable trace for HW TX Timestamp AF_XDP ZC"
>
>  drivers/net/ethernet/intel/igc/igc_main.c         | 5 -----
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>  2 files changed, 1 insertion(+), 6 deletions(-)
>
> --
> 2.34.1
>
>