mbox series

[0/3,v2,j/k,linux-azure] Azure: smb3: allow deferred close timeout to be configurable

Message ID 20230330182710.1141816-1-tim.gardner@canonical.com
Headers show
Series Azure: smb3: allow deferred close timeout to be configurable | expand

Message

Tim Gardner March 30, 2023, 6:27 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2013349

v2: Added 2 more patches as requested by MSFT

SRU Justification

[Impact]

Microsoft has requested the ability to set a deferred close timeout to SMB3 connections.

Upstream commit 5efdd9122eff772eae2feae9f0fc0ec02d4846a3 ('smb3: allow deferred close timeout to be configurable')
Upstream commit 7e0e76d99079be13c9961dde7c93b2d1ee665af4 ('smb3: lower default deferred close timeout to address perf regression')

Not strictly required, but requested by MSFT nonetheless, and also applied to lunar/linux-azure:

Upstream commit 47f9e4c924025c5be87959d3335e66fcbb7f6b5c ('keys: Do not cache key in task struct if key is requested from kernel thread')

[ Regression Potential ]

Possible regressions include connections not closing,
or closing later then the timeout would indicate.

[ Test Plan ]

Microsoft tested.

[ Other Info ]

SF: #00357322

Comments

Andrei Gherzan April 3, 2023, 10:27 a.m. UTC | #1 
On 23/03/30 12:27PM, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/2013349
> 
> v2: Added 2 more patches as requested by MSFT
> 
> SRU Justification
> 
> [Impact]
> 
> Microsoft has requested the ability to set a deferred close timeout to SMB3 connections.
> 
> Upstream commit 5efdd9122eff772eae2feae9f0fc0ec02d4846a3 ('smb3: allow deferred close timeout to be configurable')
> Upstream commit 7e0e76d99079be13c9961dde7c93b2d1ee665af4 ('smb3: lower default deferred close timeout to address perf regression')
> 
> Not strictly required, but requested by MSFT nonetheless, and also applied to lunar/linux-azure:
> 
> Upstream commit 47f9e4c924025c5be87959d3335e66fcbb7f6b5c ('keys: Do not cache key in task struct if key is requested from kernel thread')
> 
> [ Regression Potential ]
> 
> Possible regressions include connections not closing,
> or closing later then the timeout would indicate.
> 
> [ Test Plan ]
> 
> Microsoft tested.
> 
> [ Other Info ]
> 
> SF: #00357322
Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Tim Gardner April 3, 2023, 5:02 p.m. UTC | #2 
On 3/30/23 12:27 PM, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/2013349
> 
> v2: Added 2 more patches as requested by MSFT
> 
> SRU Justification
> 
> [Impact]
> 
> Microsoft has requested the ability to set a deferred close timeout to SMB3 connections.
> 
> Upstream commit 5efdd9122eff772eae2feae9f0fc0ec02d4846a3 ('smb3: allow deferred close timeout to be configurable')
> Upstream commit 7e0e76d99079be13c9961dde7c93b2d1ee665af4 ('smb3: lower default deferred close timeout to address perf regression')
> 
> Not strictly required, but requested by MSFT nonetheless, and also applied to lunar/linux-azure:
> 
> Upstream commit 47f9e4c924025c5be87959d3335e66fcbb7f6b5c ('keys: Do not cache key in task struct if key is requested from kernel thread')
> 
> [ Regression Potential ]
> 
> Possible regressions include connections not closing,
> or closing later then the timeout would indicate.
> 
> [ Test Plan ]
> 
> Microsoft tested.
> 
> [ Other Info ]
> 
> SF: #00357322
> 
> 
Applied to Jammy/Kinetic linux-azure/master-next. Thanks.

-rtg