mbox series

[SRU,K,0/1] enable CONFIG_SERIAL_8250_MID=y

Message ID 20230310183657.209971-1-andrea.righi@canonical.com
Headers show
Series enable CONFIG_SERIAL_8250_MID=y | expand

Message

Andrea Righi March 10, 2023, 6:36 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2009283

[Impact]

CONFIG_SERIAL_8250_MID=y is required to properly use the serial console
on some platforms that are using the "mid" serial driver (such as some
Intel SoC platforms).

The generic kernel should build this driver statically to make sure we
properly support these platforms.

[Test case]

Boot the Ubuntu generic kernel on a system that is using the "mid"
serial driver (e.g, no PCI serial).

[Fix]

Enable CONFIG_SERIAL_8250_MID=y.

[Regression potential]

Kernel footprint is increased a bit with this change (around +9K), so we
may see little performance regressions at boot time in really small
platforms (additional memory usage is probably negligible), but it is
worth it, otherwise we won't be able to properly support these
platforms.

NOTE: we may want to disable this option in the could kernels and
derivatives and keep it only for the generic.

----------------------------------------------------------------
Andrea Righi (1):
      UBUNTU: [Config] enable CONFIG_SERIAL_8250_MID=y

 debian.master/config/annotations          | 5 ++++-
 debian.master/config/config.common.ubuntu | 4 ++--
 2 files changed, 6 insertions(+), 3 deletions(-)

Comments

Luke Nowakowski-Krijger March 10, 2023, 8:42 p.m. UTC | #1
Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>

On Fri, Mar 10, 2023 at 10:37 AM Andrea Righi <andrea.righi@canonical.com>
wrote:

> BugLink: https://bugs.launchpad.net/bugs/2009283
>
> [Impact]
>
> CONFIG_SERIAL_8250_MID=y is required to properly use the serial console
> on some platforms that are using the "mid" serial driver (such as some
> Intel SoC platforms).
>
> The generic kernel should build this driver statically to make sure we
> properly support these platforms.
>
> [Test case]
>
> Boot the Ubuntu generic kernel on a system that is using the "mid"
> serial driver (e.g, no PCI serial).
>
> [Fix]
>
> Enable CONFIG_SERIAL_8250_MID=y.
>
> [Regression potential]
>
> Kernel footprint is increased a bit with this change (around +9K), so we
> may see little performance regressions at boot time in really small
> platforms (additional memory usage is probably negligible), but it is
> worth it, otherwise we won't be able to properly support these
> platforms.
>
> NOTE: we may want to disable this option in the could kernels and
> derivatives and keep it only for the generic.
>
> ----------------------------------------------------------------
> Andrea Righi (1):
>       UBUNTU: [Config] enable CONFIG_SERIAL_8250_MID=y
>
>  debian.master/config/annotations          | 5 ++++-
>  debian.master/config/config.common.ubuntu | 4 ++--
>  2 files changed, 6 insertions(+), 3 deletions(-)
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Stefan Bader March 13, 2023, 10:04 a.m. UTC | #2
On 10.03.23 19:36, Andrea Righi wrote:
> BugLink: https://bugs.launchpad.net/bugs/2009283
> 
> [Impact]
> 
> CONFIG_SERIAL_8250_MID=y is required to properly use the serial console
> on some platforms that are using the "mid" serial driver (such as some
> Intel SoC platforms).
> 
> The generic kernel should build this driver statically to make sure we
> properly support these platforms.
> 
> [Test case]
> 
> Boot the Ubuntu generic kernel on a system that is using the "mid"
> serial driver (e.g, no PCI serial).
> 
> [Fix]
> 
> Enable CONFIG_SERIAL_8250_MID=y.
> 
> [Regression potential]
> 
> Kernel footprint is increased a bit with this change (around +9K), so we
> may see little performance regressions at boot time in really small
> platforms (additional memory usage is probably negligible), but it is
> worth it, otherwise we won't be able to properly support these
> platforms.
> 
> NOTE: we may want to disable this option in the could kernels and
> derivatives and keep it only for the generic.
> 
> ----------------------------------------------------------------
> Andrea Righi (1):
>        UBUNTU: [Config] enable CONFIG_SERIAL_8250_MID=y
> 
>   debian.master/config/annotations          | 5 ++++-
>   debian.master/config/config.common.ubuntu | 4 ++--
>   2 files changed, 6 insertions(+), 3 deletions(-)
> 
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Luke Nowakowski-Krijger March 14, 2023, 6:08 p.m. UTC | #3
Applied to kinetic:linux master-next

Thanks!
- Luke

On Fri, Mar 10, 2023 at 10:37 AM Andrea Righi <andrea.righi@canonical.com>
wrote:

> BugLink: https://bugs.launchpad.net/bugs/2009283
>
> [Impact]
>
> CONFIG_SERIAL_8250_MID=y is required to properly use the serial console
> on some platforms that are using the "mid" serial driver (such as some
> Intel SoC platforms).
>
> The generic kernel should build this driver statically to make sure we
> properly support these platforms.
>
> [Test case]
>
> Boot the Ubuntu generic kernel on a system that is using the "mid"
> serial driver (e.g, no PCI serial).
>
> [Fix]
>
> Enable CONFIG_SERIAL_8250_MID=y.
>
> [Regression potential]
>
> Kernel footprint is increased a bit with this change (around +9K), so we
> may see little performance regressions at boot time in really small
> platforms (additional memory usage is probably negligible), but it is
> worth it, otherwise we won't be able to properly support these
> platforms.
>
> NOTE: we may want to disable this option in the could kernels and
> derivatives and keep it only for the generic.
>
> ----------------------------------------------------------------
> Andrea Righi (1):
>       UBUNTU: [Config] enable CONFIG_SERIAL_8250_MID=y
>
>  debian.master/config/annotations          | 5 ++++-
>  debian.master/config/config.common.ubuntu | 4 ++--
>  2 files changed, 6 insertions(+), 3 deletions(-)
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>