mbox series

[SRU,K,v2,0/8] Rest of the bugfixes from oem-5.17

Message ID 20230210085052.3083756-1-tjaalton@ubuntu.com
Headers show
Series Rest of the bugfixes from oem-5.17 | expand

Message

Timo Aaltonen Feb. 10, 2023, 8:50 a.m. UTC
From: Timo Aaltonen <timo.aaltonen@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1981173
BugLink: https://bugs.launchpad.net/bugs/1981773
BugLink: https://bugs.launchpad.net/bugs/1991366

Hi,

Here are all the remaining bugfixes from oem-5.17 that haven't been
submitted for the kinetic kernel yet. They are all clean cherry-picks
from mainline.

Dropped the commits that have landed or have been submitted separately.

Kai-Heng Feng (2):
  PCI: Clear PCI_STATUS when setting up device
  iio: light: cm32181: Add PM support

Mika Westerberg (6):
  PCI: Fix used_buses calculation in pci_scan_child_bus_extend()
  PCI: Pass available buses even if the bridge is already configured
  PCI: Move pci_assign_unassigned_root_bus_resources()
  PCI: Distribute available resources for root buses, too
  PCI: Fix whitespace and indentation
  PCI: Fix typo in pci_scan_child_bus_extend()

 drivers/iio/light/cm32181.c |  22 +++
 drivers/pci/probe.c         |  16 +-
 drivers/pci/setup-bus.c     | 290 ++++++++++++++++++++++--------------
 3 files changed, 206 insertions(+), 122 deletions(-)

Comments

Stefan Bader Feb. 10, 2023, 9:51 a.m. UTC | #1
On 10.02.23 09:50, Timo Aaltonen wrote:
> From: Timo Aaltonen <timo.aaltonen@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1981173
> BugLink: https://bugs.launchpad.net/bugs/1981773
> BugLink: https://bugs.launchpad.net/bugs/1991366
> 
> Hi,
> 
> Here are all the remaining bugfixes from oem-5.17 that haven't been
> submitted for the kinetic kernel yet. They are all clean cherry-picks
> from mainline.
> 
> Dropped the commits that have landed or have been submitted separately.
> 
> Kai-Heng Feng (2):
>    PCI: Clear PCI_STATUS when setting up device
>    iio: light: cm32181: Add PM support
> 
> Mika Westerberg (6):
>    PCI: Fix used_buses calculation in pci_scan_child_bus_extend()
>    PCI: Pass available buses even if the bridge is already configured
>    PCI: Move pci_assign_unassigned_root_bus_resources()
>    PCI: Distribute available resources for root buses, too
>    PCI: Fix whitespace and indentation
>    PCI: Fix typo in pci_scan_child_bus_extend()
> 
>   drivers/iio/light/cm32181.c |  22 +++
>   drivers/pci/probe.c         |  16 +-
>   drivers/pci/setup-bus.c     | 290 ++++++++++++++++++++++--------------
>   3 files changed, 206 insertions(+), 122 deletions(-)
> 
All cherry picks from upstream and linked to bugs. The question I would 
have is whether these are long enough in upstream that they naturally 
will be in lunar or have been added there already. So we will not loose 
things moving from lunar to the next series.

Acked-by: Stefan Bader <stefan.bader@canonical.com>

- Stefan
Timo Aaltonen Feb. 10, 2023, 9:55 a.m. UTC | #2
Stefan Bader kirjoitti 10.2.2023 klo 11.51:
> On 10.02.23 09:50, Timo Aaltonen wrote:
>> From: Timo Aaltonen <timo.aaltonen@canonical.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1981173
>> BugLink: https://bugs.launchpad.net/bugs/1981773
>> BugLink: https://bugs.launchpad.net/bugs/1991366
>>
>> Hi,
>>
>> Here are all the remaining bugfixes from oem-5.17 that haven't been
>> submitted for the kinetic kernel yet. They are all clean cherry-picks
>> from mainline.
>>
>> Dropped the commits that have landed or have been submitted separately.
>>
>> Kai-Heng Feng (2):
>>    PCI: Clear PCI_STATUS when setting up device
>>    iio: light: cm32181: Add PM support
>>
>> Mika Westerberg (6):
>>    PCI: Fix used_buses calculation in pci_scan_child_bus_extend()
>>    PCI: Pass available buses even if the bridge is already configured
>>    PCI: Move pci_assign_unassigned_root_bus_resources()
>>    PCI: Distribute available resources for root buses, too
>>    PCI: Fix whitespace and indentation
>>    PCI: Fix typo in pci_scan_child_bus_extend()
>>
>>   drivers/iio/light/cm32181.c |  22 +++
>>   drivers/pci/probe.c         |  16 +-
>>   drivers/pci/setup-bus.c     | 290 ++++++++++++++++++++++--------------
>>   3 files changed, 206 insertions(+), 122 deletions(-)
>>
> All cherry picks from upstream and linked to bugs. The question I would 
> have is whether these are long enough in upstream that they naturally 
> will be in lunar or have been added there already. So we will not loose 
> things moving from lunar to the next series.
> 
> Acked-by: Stefan Bader <stefan.bader@canonical.com>

Yeah absolutely, 1981173 and 1981773 are both in 6.0 and up, 1991366 is 
in 6.1 and up.

thanks,
Stefan Bader Feb. 10, 2023, 10:30 a.m. UTC | #3
On 10.02.23 10:55, Timo Aaltonen wrote:
> Stefan Bader kirjoitti 10.2.2023 klo 11.51:
>> On 10.02.23 09:50, Timo Aaltonen wrote:
>>> From: Timo Aaltonen <timo.aaltonen@canonical.com>
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1981173
>>> BugLink: https://bugs.launchpad.net/bugs/1981773
>>> BugLink: https://bugs.launchpad.net/bugs/1991366
>>>
>>> Hi,
>>>
>>> Here are all the remaining bugfixes from oem-5.17 that haven't been
>>> submitted for the kinetic kernel yet. They are all clean cherry-picks
>>> from mainline.
>>>
>>> Dropped the commits that have landed or have been submitted separately.
>>>
>>> Kai-Heng Feng (2):
>>>    PCI: Clear PCI_STATUS when setting up device
>>>    iio: light: cm32181: Add PM support
>>>
>>> Mika Westerberg (6):
>>>    PCI: Fix used_buses calculation in pci_scan_child_bus_extend()
>>>    PCI: Pass available buses even if the bridge is already configured
>>>    PCI: Move pci_assign_unassigned_root_bus_resources()
>>>    PCI: Distribute available resources for root buses, too
>>>    PCI: Fix whitespace and indentation
>>>    PCI: Fix typo in pci_scan_child_bus_extend()
>>>
>>>   drivers/iio/light/cm32181.c |  22 +++
>>>   drivers/pci/probe.c         |  16 +-
>>>   drivers/pci/setup-bus.c     | 290 ++++++++++++++++++++++--------------
>>>   3 files changed, 206 insertions(+), 122 deletions(-)
>>>
>> All cherry picks from upstream and linked to bugs. The question I 
>> would have is whether these are long enough in upstream that they 
>> naturally will be in lunar or have been added there already. So we 
>> will not loose things moving from lunar to the next series.
>>
>> Acked-by: Stefan Bader <stefan.bader@canonical.com>
> 
> Yeah absolutely, 1981173 and 1981773 are both in 6.0 and up, 1991366 is 
> in 6.1 and up.
> 
> thanks,
> 
Cool. Thanks!

- Stefan
Tim Gardner Feb. 10, 2023, 1:51 p.m. UTC | #4
On 2/10/23 1:50 AM, Timo Aaltonen wrote:
> From: Timo Aaltonen <timo.aaltonen@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1981173
> BugLink: https://bugs.launchpad.net/bugs/1981773
> BugLink: https://bugs.launchpad.net/bugs/1991366
> 
> Hi,
> 
> Here are all the remaining bugfixes from oem-5.17 that haven't been
> submitted for the kinetic kernel yet. They are all clean cherry-picks
> from mainline.
> 
> Dropped the commits that have landed or have been submitted separately.
> 
> Kai-Heng Feng (2):
>    PCI: Clear PCI_STATUS when setting up device
>    iio: light: cm32181: Add PM support
> 
> Mika Westerberg (6):
>    PCI: Fix used_buses calculation in pci_scan_child_bus_extend()
>    PCI: Pass available buses even if the bridge is already configured
>    PCI: Move pci_assign_unassigned_root_bus_resources()
>    PCI: Distribute available resources for root buses, too
>    PCI: Fix whitespace and indentation
>    PCI: Fix typo in pci_scan_child_bus_extend()
> 
>   drivers/iio/light/cm32181.c |  22 +++
>   drivers/pci/probe.c         |  16 +-
>   drivers/pci/setup-bus.c     | 290 ++++++++++++++++++++++--------------
>   3 files changed, 206 insertions(+), 122 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Luke Nowakowski-Krijger Feb. 16, 2023, 11:11 p.m. UTC | #5
Hey,

Looks like the patch "PCI: Clear PCI_STATUS when setting up device" got
reverted upstream due to some issues with virtualization on Apple devices.
That and Anthony Wong marked it Won't Fix in the launchpad bug, so I would
not apply that one

It also looks like "PCI: Distribute available resources for root buses,
too" was reverted upstream. How should we proceed with these patches?

Thanks,
- Luke


On Fri, Feb 10, 2023 at 12:51 AM Timo Aaltonen <tjaalton@ubuntu.com> wrote:

> From: Timo Aaltonen <timo.aaltonen@canonical.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1981173
> BugLink: https://bugs.launchpad.net/bugs/1981773
> BugLink: https://bugs.launchpad.net/bugs/1991366
>
> Hi,
>
> Here are all the remaining bugfixes from oem-5.17 that haven't been
> submitted for the kinetic kernel yet. They are all clean cherry-picks
> from mainline.
>
> Dropped the commits that have landed or have been submitted separately.
>
> Kai-Heng Feng (2):
>   PCI: Clear PCI_STATUS when setting up device
>   iio: light: cm32181: Add PM support
>
> Mika Westerberg (6):
>   PCI: Fix used_buses calculation in pci_scan_child_bus_extend()
>   PCI: Pass available buses even if the bridge is already configured
>   PCI: Move pci_assign_unassigned_root_bus_resources()
>   PCI: Distribute available resources for root buses, too
>   PCI: Fix whitespace and indentation
>   PCI: Fix typo in pci_scan_child_bus_extend()
>
>  drivers/iio/light/cm32181.c |  22 +++
>  drivers/pci/probe.c         |  16 +-
>  drivers/pci/setup-bus.c     | 290 ++++++++++++++++++++++--------------
>  3 files changed, 206 insertions(+), 122 deletions(-)
>
> --
> 2.37.2
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Timo Aaltonen Feb. 17, 2023, 7:49 a.m. UTC | #6
Luke Nowakowski-Krijger kirjoitti 17.2.2023 klo 1.11:
> Hey,
> 
> Looks like the patch "PCI: Clear PCI_STATUS when setting up device" got 
> reverted upstream due to some issues with virtualization on Apple 
> devices. That and Anthony Wong marked it Won't Fix in the launchpad bug, 
> so I would not apply that one
> 
> It also looks like "PCI: Distribute available resources for root buses, 
> too" was reverted upstream. How should we proceed with these patches?

Ah yes, both patches should be dropped, then it would match current 
upstream and oem-6.1 too.

> On Fri, Feb 10, 2023 at 12:51 AM Timo Aaltonen <tjaalton@ubuntu.com 
> <mailto:tjaalton@ubuntu.com>> wrote:
> 
>     From: Timo Aaltonen <timo.aaltonen@canonical.com
>     <mailto:timo.aaltonen@canonical.com>>
> 
>     BugLink: https://bugs.launchpad.net/bugs/1981173
>     <https://bugs.launchpad.net/bugs/1981173>
>     BugLink: https://bugs.launchpad.net/bugs/1981773
>     <https://bugs.launchpad.net/bugs/1981773>
>     BugLink: https://bugs.launchpad.net/bugs/1991366
>     <https://bugs.launchpad.net/bugs/1991366>
> 
>     Hi,
> 
>     Here are all the remaining bugfixes from oem-5.17 that haven't been
>     submitted for the kinetic kernel yet. They are all clean cherry-picks
>     from mainline.
> 
>     Dropped the commits that have landed or have been submitted separately.
> 
>     Kai-Heng Feng (2):
>        PCI: Clear PCI_STATUS when setting up device
>        iio: light: cm32181: Add PM support
> 
>     Mika Westerberg (6):
>        PCI: Fix used_buses calculation in pci_scan_child_bus_extend()
>        PCI: Pass available buses even if the bridge is already configured
>        PCI: Move pci_assign_unassigned_root_bus_resources()
>        PCI: Distribute available resources for root buses, too
>        PCI: Fix whitespace and indentation
>        PCI: Fix typo in pci_scan_child_bus_extend()
> 
>       drivers/iio/light/cm32181.c |  22 +++
>       drivers/pci/probe.c         |  16 +-
>       drivers/pci/setup-bus.c     | 290 ++++++++++++++++++++++--------------
>       3 files changed, 206 insertions(+), 122 deletions(-)
> 
>     -- 
>     2.37.2
> 
> 
>     -- 
>     kernel-team mailing list
>     kernel-team@lists.ubuntu.com <mailto:kernel-team@lists.ubuntu.com>
>     https://lists.ubuntu.com/mailman/listinfo/kernel-team
>     <https://lists.ubuntu.com/mailman/listinfo/kernel-team>
>
Luke Nowakowski-Krijger Feb. 21, 2023, 10:48 p.m. UTC | #7
Applied to kinetic:linux master-next, the two patches that were reverted
upstream
"PCI: Clear PCI_STATUS when setting up device"
and
"PCI: Distribute available resources for root buses, too"
were dropped as per an earlier email with Timo.

Thanks!
- Luke

On Fri, Feb 10, 2023 at 12:51 AM Timo Aaltonen <tjaalton@ubuntu.com> wrote:

> From: Timo Aaltonen <timo.aaltonen@canonical.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1981173
> BugLink: https://bugs.launchpad.net/bugs/1981773
> BugLink: https://bugs.launchpad.net/bugs/1991366
>
> Hi,
>
> Here are all the remaining bugfixes from oem-5.17 that haven't been
> submitted for the kinetic kernel yet. They are all clean cherry-picks
> from mainline.
>
> Dropped the commits that have landed or have been submitted separately.
>
> Kai-Heng Feng (2):
>   PCI: Clear PCI_STATUS when setting up device
>   iio: light: cm32181: Add PM support
>
> Mika Westerberg (6):
>   PCI: Fix used_buses calculation in pci_scan_child_bus_extend()
>   PCI: Pass available buses even if the bridge is already configured
>   PCI: Move pci_assign_unassigned_root_bus_resources()
>   PCI: Distribute available resources for root buses, too
>   PCI: Fix whitespace and indentation
>   PCI: Fix typo in pci_scan_child_bus_extend()
>
>  drivers/iio/light/cm32181.c |  22 +++
>  drivers/pci/probe.c         |  16 +-
>  drivers/pci/setup-bus.c     | 290 ++++++++++++++++++++++--------------
>  3 files changed, 206 insertions(+), 122 deletions(-)
>
> --
> 2.37.2
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>