mbox series

[0/3,SRU,J] Fix ACPI _CPC not found on dynamic loaded firmware

Message ID 20230206062712.10732-1-ivan.hu@canonical.com
Headers show
Series Fix ACPI _CPC not found on dynamic loaded firmware | expand

Message

Ivan Hu Feb. 6, 2023, 6:27 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2006077
[Impact]
Some machines which have dynamically loaded SSDT tables, will not be loaded and
get the CPPC not worked.

[Fix]
Fix the regression by some load supports for CPPC from an SSDT dynamically
when _OSC reports CPPC v2. And make the "[\_SB.PR00._CPC], AE_NOT_FOUND" gone.

[Test]
Verified all the OEM dynamic table loaded or the "[\_SB.PR00._CPC], AE_NOT_FOUND"
error exist or not on demesg .

[Where problems could occur]
Low risk, It only helps to CPPC support loaded.


Mario Limonciello (1):
  ACPI: CPPC: Only probe for _CPC if CPPC v2 is acked

Pierre Gondois (1):
  ACPI: bus: Set CPPC _OSC bits for all and when CPPC_LIB is supported

Rafael J. Wysocki (1):
  ACPI: bus: Avoid using CPPC if not supported by firmware

 drivers/acpi/bus.c       | 15 +++++++++++----
 drivers/acpi/cppc_acpi.c |  5 +++++
 include/linux/acpi.h     |  2 ++
 3 files changed, 18 insertions(+), 4 deletions(-)

Comments

Tim Gardner Feb. 8, 2023, 3:39 p.m. UTC | #1
On 2/5/23 11:27 PM, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2006077
> [Impact]
> Some machines which have dynamically loaded SSDT tables, will not be loaded and
> get the CPPC not worked.
> 
> [Fix]
> Fix the regression by some load supports for CPPC from an SSDT dynamically
> when _OSC reports CPPC v2. And make the "[\_SB.PR00._CPC], AE_NOT_FOUND" gone.
> 
> [Test]
> Verified all the OEM dynamic table loaded or the "[\_SB.PR00._CPC], AE_NOT_FOUND"
> error exist or not on demesg .
> 
> [Where problems could occur]
> Low risk, It only helps to CPPC support loaded.
> 
> 
> Mario Limonciello (1):
>    ACPI: CPPC: Only probe for _CPC if CPPC v2 is acked
> 
> Pierre Gondois (1):
>    ACPI: bus: Set CPPC _OSC bits for all and when CPPC_LIB is supported
> 
> Rafael J. Wysocki (1):
>    ACPI: bus: Avoid using CPPC if not supported by firmware
> 
>   drivers/acpi/bus.c       | 15 +++++++++++----
>   drivers/acpi/cppc_acpi.c |  5 +++++
>   include/linux/acpi.h     |  2 ++
>   3 files changed, 18 insertions(+), 4 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Stefan Bader Feb. 23, 2023, 11:16 a.m. UTC | #2
On 06.02.23 07:27, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2006077
> [Impact]
> Some machines which have dynamically loaded SSDT tables, will not be loaded and
> get the CPPC not worked.
> 
> [Fix]
> Fix the regression by some load supports for CPPC from an SSDT dynamically
> when _OSC reports CPPC v2. And make the "[\_SB.PR00._CPC], AE_NOT_FOUND" gone.
> 
> [Test]
> Verified all the OEM dynamic table loaded or the "[\_SB.PR00._CPC], AE_NOT_FOUND"
> error exist or not on demesg .
> 
> [Where problems could occur]
> Low risk, It only helps to CPPC support loaded.
> 
> 
> Mario Limonciello (1):
>    ACPI: CPPC: Only probe for _CPC if CPPC v2 is acked
> 
> Pierre Gondois (1):
>    ACPI: bus: Set CPPC _OSC bits for all and when CPPC_LIB is supported
> 
> Rafael J. Wysocki (1):
>    ACPI: bus: Avoid using CPPC if not supported by firmware
> 
>   drivers/acpi/bus.c       | 15 +++++++++++----
>   drivers/acpi/cppc_acpi.c |  5 +++++
>   include/linux/acpi.h     |  2 ++
>   3 files changed, 18 insertions(+), 4 deletions(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader Feb. 23, 2023, 11:21 a.m. UTC | #3
On 06.02.23 07:27, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2006077
> [Impact]
> Some machines which have dynamically loaded SSDT tables, will not be loaded and
> get the CPPC not worked.
> 
> [Fix]
> Fix the regression by some load supports for CPPC from an SSDT dynamically
> when _OSC reports CPPC v2. And make the "[\_SB.PR00._CPC], AE_NOT_FOUND" gone.
> 
> [Test]
> Verified all the OEM dynamic table loaded or the "[\_SB.PR00._CPC], AE_NOT_FOUND"
> error exist or not on demesg .
> 
> [Where problems could occur]
> Low risk, It only helps to CPPC support loaded.
> 
> 
> Mario Limonciello (1):
>    ACPI: CPPC: Only probe for _CPC if CPPC v2 is acked
> 
> Pierre Gondois (1):
>    ACPI: bus: Set CPPC _OSC bits for all and when CPPC_LIB is supported
> 
> Rafael J. Wysocki (1):
>    ACPI: bus: Avoid using CPPC if not supported by firmware
> 
>   drivers/acpi/bus.c       | 15 +++++++++++----
>   drivers/acpi/cppc_acpi.c |  5 +++++
>   include/linux/acpi.h     |  2 ++
>   3 files changed, 18 insertions(+), 4 deletions(-)
> 

Applied to jammy:linux/master-next. Thanks.

-Stefan