mbox series

[SRU,F,J,K,0/1] Fix selftest racing bug in udpgso_bench

Message ID 20230203195550.182433-1-andrei.gherzan@canonical.com
Headers show
Series Fix selftest racing bug in udpgso_bench | expand

Message

Andrei Gherzan Feb. 3, 2023, 7:55 p.m. UTC 
BugLink: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1951447

[Impact]

The udpgso_bench tests may fail due an unsynchronized producer/receiver
setup.

[Fix]

The test was introduced in 4.18, and it included the issue from the
initial submission[1]. The fix was merged in netdev, master branch[2].

[Potential regression]

None expected.

[Tests]

Tested in clean VMs and in some MAAS hosts.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=3a687bef148d94da13dc25981bb7b1e26a1ab125
[2] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=dafe93b9ee21028d625dce347118b82659652eff

Andrei Gherzan (1):
  selftests: net: udpgso_bench: Fix racing bug between the rx/tx
    programs

 tools/testing/selftests/net/udpgso_bench.sh | 24 +++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

Comments

Tim Gardner Feb. 8, 2023, 3:41 p.m. UTC | #1 
On 2/3/23 12:55 PM, Andrei Gherzan wrote:
> BugLink: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1951447
> 
> [Impact]
> 
> The udpgso_bench tests may fail due an unsynchronized producer/receiver
> setup.
> 
> [Fix]
> 
> The test was introduced in 4.18, and it included the issue from the
> initial submission[1]. The fix was merged in netdev, master branch[2].
> 
> [Potential regression]
> 
> None expected.
> 
> [Tests]
> 
> Tested in clean VMs and in some MAAS hosts.
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=3a687bef148d94da13dc25981bb7b1e26a1ab125
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=dafe93b9ee21028d625dce347118b82659652eff
> 
> Andrei Gherzan (1):
>    selftests: net: udpgso_bench: Fix racing bug between the rx/tx
>      programs
> 
>   tools/testing/selftests/net/udpgso_bench.sh | 24 +++++++++++++++++----
>   1 file changed, 20 insertions(+), 4 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

Adjust BugLink. Commit dafe93b9ee21028d625dce347118b82659652eff is also 
now upstream.
Luke Nowakowski-Krijger Feb. 10, 2023, 10:07 p.m. UTC | #2 
Applied to focal jammy kinetic linux master-next,

Adjusted Buglink to standard format.
Drop netdev in cherry-pick line as patch is now upstream, also added extra
signed-off-by and Link tidbits from patch upstream.

Thanks,
- Luke

On Fri, Feb 3, 2023 at 11:56 AM Andrei Gherzan <andrei.gherzan@canonical.com>
wrote:

> BugLink: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1951447
>
> [Impact]
>
> The udpgso_bench tests may fail due an unsynchronized producer/receiver
> setup.
>
> [Fix]
>
> The test was introduced in 4.18, and it included the issue from the
> initial submission[1]. The fix was merged in netdev, master branch[2].
>
> [Potential regression]
>
> None expected.
>
> [Tests]
>
> Tested in clean VMs and in some MAAS hosts.
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=3a687bef148d94da13dc25981bb7b1e26a1ab125
> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=dafe93b9ee21028d625dce347118b82659652eff
>
> Andrei Gherzan (1):
>   selftests: net: udpgso_bench: Fix racing bug between the rx/tx
>     programs
>
>  tools/testing/selftests/net/udpgso_bench.sh | 24 +++++++++++++++++----
>  1 file changed, 20 insertions(+), 4 deletions(-)
>
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>