mbox series

[0/3,SRU,U/K/J/OEM-6.0/OEM-5.17] Fix RPL-S support on powercap/intel_rapl

Message ID 20220919151751.1686149-1-koba.ko@canonical.com
Headers show
Series Fix RPL-S support on powercap/intel_rapl | expand

Message

Koba Ko Sept. 19, 2022, 3:17 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1990161

[Impact]
proc_thermal driver is not loaded

[Fix]
Add RPL-S id on device id table of powercap/intel_rapl.

[Test Case]
1. sudo checkbox-cli run com.canonical.certification::miscellanea/proc_thermal

[Where problems could occur]
Low, only add RPL-S id on powercap/intel_rap but may lack of RPL-S features.

George D Sworo (1):
  [SRU][K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
    RAPTORLAKE_P

Tony Luck (1):
  [SRU][K/J/OEM-6.0/OEM-5.17] x86/cpu: Add new Raptor Lake CPU model
    number

Zhang Rui (1):
  [SRU][U/K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
    RAPTORLAKE_S

 arch/x86/include/asm/intel-family.h  | 2 ++
 drivers/powercap/intel_rapl_common.c | 2 ++
 2 files changed, 4 insertions(+)

Comments

Tim Gardner Sept. 19, 2022, 3:22 p.m. UTC | #1
On 9/19/22 09:17, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/1990161
> 
> [Impact]
> proc_thermal driver is not loaded
> 
> [Fix]
> Add RPL-S id on device id table of powercap/intel_rapl.
> 
> [Test Case]
> 1. sudo checkbox-cli run com.canonical.certification::miscellanea/proc_thermal
> 
> [Where problems could occur]
> Low, only add RPL-S id on powercap/intel_rap but may lack of RPL-S features.
> 
> George D Sworo (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_P
> 
> Tony Luck (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] x86/cpu: Add new Raptor Lake CPU model
>      number
> 
> Zhang Rui (1):
>    [SRU][U/K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_S
> 
>   arch/x86/include/asm/intel-family.h  | 2 ++
>   drivers/powercap/intel_rapl_common.c | 2 ++
>   2 files changed, 4 insertions(+)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

Patch 3 is still linux-next
Paolo Pisati Sept. 20, 2022, 2:25 p.m. UTC | #2
On Mon, Sep 19, 2022 at 11:17:48PM +0800, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/1990161
Timo Aaltonen Sept. 21, 2022, 7:20 a.m. UTC | #3
Koba Ko kirjoitti 19.9.2022 klo 18.17:
> BugLink: https://bugs.launchpad.net/bugs/1990161
> 
> [Impact]
> proc_thermal driver is not loaded
> 
> [Fix]
> Add RPL-S id on device id table of powercap/intel_rapl.
> 
> [Test Case]
> 1. sudo checkbox-cli run com.canonical.certification::miscellanea/proc_thermal
> 
> [Where problems could occur]
> Low, only add RPL-S id on powercap/intel_rap but may lack of RPL-S features.
> 
> George D Sworo (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_P
> 
> Tony Luck (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] x86/cpu: Add new Raptor Lake CPU model
>      number
> 
> Zhang Rui (1):
>    [SRU][U/K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_S
> 
>   arch/x86/include/asm/intel-family.h  | 2 ++
>   drivers/powercap/intel_rapl_common.c | 2 ++
>   2 files changed, 4 insertions(+)
> 

applied to oem-5.17, thanks
Timo Aaltonen Sept. 21, 2022, 7:24 a.m. UTC | #4
Koba Ko kirjoitti 19.9.2022 klo 18.17:
> BugLink: https://bugs.launchpad.net/bugs/1990161
> 
> [Impact]
> proc_thermal driver is not loaded
> 
> [Fix]
> Add RPL-S id on device id table of powercap/intel_rapl.
> 
> [Test Case]
> 1. sudo checkbox-cli run com.canonical.certification::miscellanea/proc_thermal
> 
> [Where problems could occur]
> Low, only add RPL-S id on powercap/intel_rap but may lack of RPL-S features.
> 
> George D Sworo (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_P
> 
> Tony Luck (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] x86/cpu: Add new Raptor Lake CPU model
>      number
> 
> Zhang Rui (1):
>    [SRU][U/K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_S
> 
>   arch/x86/include/asm/intel-family.h  | 2 ++
>   drivers/powercap/intel_rapl_common.c | 2 ++
>   2 files changed, 4 insertions(+)
> 

be more careful when checking which kernels should have this; 6.0 
already has the first two and the last one doesn't apply
Timo Aaltonen Sept. 21, 2022, 10:33 a.m. UTC | #5
Koba Ko kirjoitti 19.9.2022 klo 18.17:
> BugLink: https://bugs.launchpad.net/bugs/1990161
> 
> [Impact]
> proc_thermal driver is not loaded
> 
> [Fix]
> Add RPL-S id on device id table of powercap/intel_rapl.
> 
> [Test Case]
> 1. sudo checkbox-cli run com.canonical.certification::miscellanea/proc_thermal
> 
> [Where problems could occur]
> Low, only add RPL-S id on powercap/intel_rap but may lack of RPL-S features.
> 
> George D Sworo (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_P
> 
> Tony Luck (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] x86/cpu: Add new Raptor Lake CPU model
>      number
> 
> Zhang Rui (1):
>    [SRU][U/K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_S
> 
>   arch/x86/include/asm/intel-family.h  | 2 ++
>   drivers/powercap/intel_rapl_common.c | 2 ++
>   2 files changed, 4 insertions(+)
> 

the last patch applied after some fuzz, so went ahead and pulled it 
after all
Stefan Bader Sept. 28, 2022, 8:47 a.m. UTC | #6
On 19.09.22 17:17, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/1990161
> 
> [Impact]
> proc_thermal driver is not loaded
> 
> [Fix]
> Add RPL-S id on device id table of powercap/intel_rapl.
> 
> [Test Case]
> 1. sudo checkbox-cli run com.canonical.certification::miscellanea/proc_thermal
> 
> [Where problems could occur]
> Low, only add RPL-S id on powercap/intel_rap but may lack of RPL-S features.
> 
> George D Sworo (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_P
> 
> Tony Luck (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] x86/cpu: Add new Raptor Lake CPU model
>      number
> 
> Zhang Rui (1):
>    [SRU][U/K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_S
> 
>   arch/x86/include/asm/intel-family.h  | 2 ++
>   drivers/powercap/intel_rapl_common.c | 2 ++
>   2 files changed, 4 insertions(+)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader Oct. 5, 2022, 1:34 p.m. UTC | #7
On 19.09.22 17:17, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/1990161
> 
> [Impact]
> proc_thermal driver is not loaded
> 
> [Fix]
> Add RPL-S id on device id table of powercap/intel_rapl.
> 
> [Test Case]
> 1. sudo checkbox-cli run com.canonical.certification::miscellanea/proc_thermal
> 
> [Where problems could occur]
> Low, only add RPL-S id on powercap/intel_rap but may lack of RPL-S features.
> 
> George D Sworo (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_P
> 
> Tony Luck (1):
>    [SRU][K/J/OEM-6.0/OEM-5.17] x86/cpu: Add new Raptor Lake CPU model
>      number
> 
> Zhang Rui (1):
>    [SRU][U/K/J/OEM-6.0/OEM-5.17] powercap: intel_rapl: Add support for
>      RAPTORLAKE_S
> 
>   arch/x86/include/asm/intel-family.h  | 2 ++
>   drivers/powercap/intel_rapl_common.c | 2 ++
>   2 files changed, 4 insertions(+)
> 

Patch #1 (x86/cpu addition) is at least missing 3 pre-req patches for Jammy. 
Re-submit this for Jammy once you have something that actually applies.

-Stefan