mbox series

[SRU,J/allwinner-5.17,v3,0/4] Fix more Allwinner D1 drivers

Message ID 20220711114951.99949-1-emil.renner.berthing@canonical.com
Headers show
Series Fix more Allwinner D1 drivers | expand

Message

Emil Renner Berthing July 11, 2022, 11:49 a.m. UTC 
[Impact]

 * The drivers for the display engine, crypto acceleration and USB
   don't probe because of missing dependencies.

[Test Plan]

 * Boot the kernel in linux-image-5.17.0-1002-allwinner and see
   /sys/kerne/debug/devices_deferred

[Where problems could occur]

 * Fixing this may introduce new bugs if the now probing drivers
   turn out to be buggy.

v3:
 - Use git cherry-pick -s -x for patch 1/4

v2:
 - s/(backport from/(cherry-pick from/ in patch 1/4
 - Add annotations in patch 4/4

Andre Przywara (1):
  phy: sun4i-usb: Rework HCI PHY (aka "pmu_unk1") handling

Emil Renner Berthing (1):
  UBUNTU: [Config] Enable additional Allwinner D1 options

Samuel Holland (2):
  UBUNTU: SAUCE: phy: sun4i-usb: Add D1 variant
  UBUNTU: SAUCE: PM / devfreq: Add dummy R329/D1 MBUS driver

 debian.allwinner/config/annotations          | 16 ++++++++
 debian.allwinner/config/config.common.ubuntu |  5 ++-
 drivers/devfreq/Kconfig                      |  6 +++
 drivers/devfreq/Makefile                     |  1 +
 drivers/devfreq/sun50i-r329-mbus.c           | 27 +++++++++++++
 drivers/phy/allwinner/phy-sun4i-usb.c        | 40 +++++++++++---------
 6 files changed, 76 insertions(+), 19 deletions(-)
 create mode 100644 drivers/devfreq/sun50i-r329-mbus.c

Comments

Tim Gardner July 11, 2022, 12:23 p.m. UTC | #1 
On 7/11/22 05:49, Emil Renner Berthing wrote:
> [Impact]
> 
>   * The drivers for the display engine, crypto acceleration and USB
>     don't probe because of missing dependencies.
> 
> [Test Plan]
> 
>   * Boot the kernel in linux-image-5.17.0-1002-allwinner and see
>     /sys/kerne/debug/devices_deferred
> 
> [Where problems could occur]
> 
>   * Fixing this may introduce new bugs if the now probing drivers
>     turn out to be buggy.
> 
> v3:
>   - Use git cherry-pick -s -x for patch 1/4
> 
> v2:
>   - s/(backport from/(cherry-pick from/ in patch 1/4
>   - Add annotations in patch 4/4
> 
> Andre Przywara (1):
>    phy: sun4i-usb: Rework HCI PHY (aka "pmu_unk1") handling
> 
> Emil Renner Berthing (1):
>    UBUNTU: [Config] Enable additional Allwinner D1 options
> 
> Samuel Holland (2):
>    UBUNTU: SAUCE: phy: sun4i-usb: Add D1 variant
>    UBUNTU: SAUCE: PM / devfreq: Add dummy R329/D1 MBUS driver
> 
>   debian.allwinner/config/annotations          | 16 ++++++++
>   debian.allwinner/config/config.common.ubuntu |  5 ++-
>   drivers/devfreq/Kconfig                      |  6 +++
>   drivers/devfreq/Makefile                     |  1 +
>   drivers/devfreq/sun50i-r329-mbus.c           | 27 +++++++++++++
>   drivers/phy/allwinner/phy-sun4i-usb.c        | 40 +++++++++++---------
>   6 files changed, 76 insertions(+), 19 deletions(-)
>   create mode 100644 drivers/devfreq/sun50i-r329-mbus.c
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Stefan Bader Aug. 5, 2022, 9:40 a.m. UTC | #2 
On 11.07.22 13:49, Emil Renner Berthing wrote:
> [Impact]
> 
>   * The drivers for the display engine, crypto acceleration and USB
>     don't probe because of missing dependencies.
> 
> [Test Plan]
> 
>   * Boot the kernel in linux-image-5.17.0-1002-allwinner and see
>     /sys/kerne/debug/devices_deferred
> 
> [Where problems could occur]
> 
>   * Fixing this may introduce new bugs if the now probing drivers
>     turn out to be buggy.
> 
> v3:
>   - Use git cherry-pick -s -x for patch 1/4
> 
> v2:
>   - s/(backport from/(cherry-pick from/ in patch 1/4
>   - Add annotations in patch 4/4
> 
> Andre Przywara (1):
>    phy: sun4i-usb: Rework HCI PHY (aka "pmu_unk1") handling
> 
> Emil Renner Berthing (1):
>    UBUNTU: [Config] Enable additional Allwinner D1 options
> 
> Samuel Holland (2):
>    UBUNTU: SAUCE: phy: sun4i-usb: Add D1 variant
>    UBUNTU: SAUCE: PM / devfreq: Add dummy R329/D1 MBUS driver
> 
>   debian.allwinner/config/annotations          | 16 ++++++++
>   debian.allwinner/config/config.common.ubuntu |  5 ++-
>   drivers/devfreq/Kconfig                      |  6 +++
>   drivers/devfreq/Makefile                     |  1 +
>   drivers/devfreq/sun50i-r329-mbus.c           | 27 +++++++++++++
>   drivers/phy/allwinner/phy-sun4i-usb.c        | 40 +++++++++++---------
>   6 files changed, 76 insertions(+), 19 deletions(-)
>   create mode 100644 drivers/devfreq/sun50i-r329-mbus.c
> 

??? The referred bug is fix released...
Kleber Souza Aug. 17, 2022, 9:53 a.m. UTC | #3 
On 11.07.22 13:49, Emil Renner Berthing wrote:
> [Impact]
> 
>   * The drivers for the display engine, crypto acceleration and USB
>     don't probe because of missing dependencies.
> 
> [Test Plan]
> 
>   * Boot the kernel in linux-image-5.17.0-1002-allwinner and see
>     /sys/kerne/debug/devices_deferred
> 
> [Where problems could occur]
> 
>   * Fixing this may introduce new bugs if the now probing drivers
>     turn out to be buggy.
> 
> v3:
>   - Use git cherry-pick -s -x for patch 1/4
> 
> v2:
>   - s/(backport from/(cherry-pick from/ in patch 1/4
>   - Add annotations in patch 4/4
> 
> Andre Przywara (1):
>    phy: sun4i-usb: Rework HCI PHY (aka "pmu_unk1") handling
> 
> Emil Renner Berthing (1):
>    UBUNTU: [Config] Enable additional Allwinner D1 options
> 
> Samuel Holland (2):
>    UBUNTU: SAUCE: phy: sun4i-usb: Add D1 variant
>    UBUNTU: SAUCE: PM / devfreq: Add dummy R329/D1 MBUS driver
> 
>   debian.allwinner/config/annotations          | 16 ++++++++
>   debian.allwinner/config/config.common.ubuntu |  5 ++-
>   drivers/devfreq/Kconfig                      |  6 +++
>   drivers/devfreq/Makefile                     |  1 +
>   drivers/devfreq/sun50i-r329-mbus.c           | 27 +++++++++++++
>   drivers/phy/allwinner/phy-sun4i-usb.c        | 40 +++++++++++---------
>   6 files changed, 76 insertions(+), 19 deletions(-)
>   create mode 100644 drivers/devfreq/sun50i-r329-mbus.c
> 

These patches were already applied to jammy:linux-allwinner-5.17 but
the second ACK and the APPLIED msg weren't sent to the ML.

Thanks,
Kleber