| Message ID | 20220517082831.30516-1-koba.ko@canonical.com |
|---|---|
| Headers | show |
| Series | Fix REG_WAIT timeout for Yellow Carp | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> Clean cherry-picks On 5/17/22 02:28, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/1971417 > > [Impact] > During hotplug built-in hdmi, the error message show up. > #REG_WAIT timeout for yellow Carp > > [Fix] > This tends to take miliseconds in certain scenarios and we'd rather not > wait that long. Due to how this interacts with det size update and > locking waiting should not be necessary as compbuf updates before > unlock. > > Add a watch for config error instead as that is something we actually do > care about. > > [Test Case] > 1. Plug and unplug hdmi > 2. cant get the error message in dmesg. > > [Where problems could occur] > Low > > V2: Fix the conflicts on J and add more AMD suggested > > Dmytro Laktyushkin (1): > [SRU][OEM-5.14] drm/amd/display: remove compbuf size wait > > Jimmy Kizito (3): > [SRU][OEM-5.14] drm/amd/display: Clear encoder assignments when state > cleared. > [SRU][OEM-5.14] drm/amd/display: Query all entries in assignment table > during updates. > [SRU][OEM-5.14] drm/amd/display: Initialise encoder assignment when > initialising dc_state > > Roy Chan (1): > [SRU][OEM-5.14] drm/amd/display: fix stale info in link encoder > assignment > > drivers/gpu/drm/amd/display/dc/core/dc.c | 5 +-- > .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 39 +++++++++++++++---- > .../gpu/drm/amd/display/dc/core/dc_resource.c | 3 ++ > .../drm/amd/display/dc/dcn10/dcn10_hubbub.h | 1 + > .../drm/amd/display/dc/dcn31/dcn31_hubbub.c | 2 +- > .../drm/amd/display/dc/dcn31/dcn31_hubbub.h | 1 + > .../gpu/drm/amd/display/dc/inc/link_enc_cfg.h | 2 +- > 7 files changed, 40 insertions(+), 13 deletions(-) >
Koba Ko kirjoitti 17.5.2022 klo 11.28: > BugLink: https://bugs.launchpad.net/bugs/1971417 > > [Impact] > During hotplug built-in hdmi, the error message show up. > #REG_WAIT timeout for yellow Carp > > [Fix] > This tends to take miliseconds in certain scenarios and we'd rather not > wait that long. Due to how this interacts with det size update and > locking waiting should not be necessary as compbuf updates before > unlock. > > Add a watch for config error instead as that is something we actually do > care about. > > [Test Case] > 1. Plug and unplug hdmi > 2. cant get the error message in dmesg. > > [Where problems could occur] > Low > > V2: Fix the conflicts on J and add more AMD suggested > > Dmytro Laktyushkin (1): > [SRU][OEM-5.14] drm/amd/display: remove compbuf size wait > > Jimmy Kizito (3): > [SRU][OEM-5.14] drm/amd/display: Clear encoder assignments when state > cleared. > [SRU][OEM-5.14] drm/amd/display: Query all entries in assignment table > during updates. > [SRU][OEM-5.14] drm/amd/display: Initialise encoder assignment when > initialising dc_state > > Roy Chan (1): > [SRU][OEM-5.14] drm/amd/display: fix stale info in link encoder > assignment > > drivers/gpu/drm/amd/display/dc/core/dc.c | 5 +-- > .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 39 +++++++++++++++---- > .../gpu/drm/amd/display/dc/core/dc_resource.c | 3 ++ > .../drm/amd/display/dc/dcn10/dcn10_hubbub.h | 1 + > .../drm/amd/display/dc/dcn31/dcn31_hubbub.c | 2 +- > .../drm/amd/display/dc/dcn31/dcn31_hubbub.h | 1 + > .../gpu/drm/amd/display/dc/inc/link_enc_cfg.h | 2 +- > 7 files changed, 40 insertions(+), 13 deletions(-) > applied to oem-5.14, thanks
On 17.05.22 10:28, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/1971417 > > [Impact] > During hotplug built-in hdmi, the error message show up. > #REG_WAIT timeout for yellow Carp > > [Fix] > This tends to take miliseconds in certain scenarios and we'd rather not > wait that long. Due to how this interacts with det size update and > locking waiting should not be necessary as compbuf updates before > unlock. > > Add a watch for config error instead as that is something we actually do > care about. > > [Test Case] > 1. Plug and unplug hdmi > 2. cant get the error message in dmesg. > > [Where problems could occur] > Low > > V2: Fix the conflicts on J and add more AMD suggested > > Dmytro Laktyushkin (1): > [SRU][OEM-5.14] drm/amd/display: remove compbuf size wait > > Jimmy Kizito (3): > [SRU][OEM-5.14] drm/amd/display: Clear encoder assignments when state > cleared. > [SRU][OEM-5.14] drm/amd/display: Query all entries in assignment table > during updates. > [SRU][OEM-5.14] drm/amd/display: Initialise encoder assignment when > initialising dc_state > > Roy Chan (1): > [SRU][OEM-5.14] drm/amd/display: fix stale info in link encoder > assignment > > drivers/gpu/drm/amd/display/dc/core/dc.c | 5 +-- > .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 39 +++++++++++++++---- > .../gpu/drm/amd/display/dc/core/dc_resource.c | 3 ++ > .../drm/amd/display/dc/dcn10/dcn10_hubbub.h | 1 + > .../drm/amd/display/dc/dcn31/dcn31_hubbub.c | 2 +- > .../drm/amd/display/dc/dcn31/dcn31_hubbub.h | 1 + > .../gpu/drm/amd/display/dc/inc/link_enc_cfg.h | 2 +- > 7 files changed, 40 insertions(+), 13 deletions(-) > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> Thanks
On 17.05.22 10:28, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/1971417 > > [Impact] > During hotplug built-in hdmi, the error message show up. > #REG_WAIT timeout for yellow Carp > > [Fix] > This tends to take miliseconds in certain scenarios and we'd rather not > wait that long. Due to how this interacts with det size update and > locking waiting should not be necessary as compbuf updates before > unlock. > > Add a watch for config error instead as that is something we actually do > care about. > > [Test Case] > 1. Plug and unplug hdmi > 2. cant get the error message in dmesg. > > [Where problems could occur] > Low > > V2: Fix the conflicts on J and add more AMD suggested > > Dmytro Laktyushkin (1): > [SRU][OEM-5.14] drm/amd/display: remove compbuf size wait > > Jimmy Kizito (3): > [SRU][OEM-5.14] drm/amd/display: Clear encoder assignments when state > cleared. > [SRU][OEM-5.14] drm/amd/display: Query all entries in assignment table > during updates. > [SRU][OEM-5.14] drm/amd/display: Initialise encoder assignment when > initialising dc_state > > Roy Chan (1): > [SRU][OEM-5.14] drm/amd/display: fix stale info in link encoder > assignment > > drivers/gpu/drm/amd/display/dc/core/dc.c | 5 +-- > .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 39 +++++++++++++++---- > .../gpu/drm/amd/display/dc/core/dc_resource.c | 3 ++ > .../drm/amd/display/dc/dcn10/dcn10_hubbub.h | 1 + > .../drm/amd/display/dc/dcn31/dcn31_hubbub.c | 2 +- > .../drm/amd/display/dc/dcn31/dcn31_hubbub.h | 1 + > .../gpu/drm/amd/display/dc/inc/link_enc_cfg.h | 2 +- > 7 files changed, 40 insertions(+), 13 deletions(-) > Applied to jammy:linux. Thanks, Kleber
BugLink: https://bugs.launchpad.net/bugs/1971417 [Impact] During hotplug built-in hdmi, the error message show up. #REG_WAIT timeout for yellow Carp [Fix] This tends to take miliseconds in certain scenarios and we'd rather not wait that long. Due to how this interacts with det size update and locking waiting should not be necessary as compbuf updates before unlock. Add a watch for config error instead as that is something we actually do care about. [Test Case] 1. Plug and unplug hdmi 2. cant get the error message in dmesg. [Where problems could occur] Low V2: Fix the conflicts on J and add more AMD suggested Dmytro Laktyushkin (1): [SRU][OEM-5.14] drm/amd/display: remove compbuf size wait Jimmy Kizito (3): [SRU][OEM-5.14] drm/amd/display: Clear encoder assignments when state cleared. [SRU][OEM-5.14] drm/amd/display: Query all entries in assignment table during updates. [SRU][OEM-5.14] drm/amd/display: Initialise encoder assignment when initialising dc_state Roy Chan (1): [SRU][OEM-5.14] drm/amd/display: fix stale info in link encoder assignment drivers/gpu/drm/amd/display/dc/core/dc.c | 5 +-- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 39 +++++++++++++++---- .../gpu/drm/amd/display/dc/core/dc_resource.c | 3 ++ .../drm/amd/display/dc/dcn10/dcn10_hubbub.h | 1 + .../drm/amd/display/dc/dcn31/dcn31_hubbub.c | 2 +- .../drm/amd/display/dc/dcn31/dcn31_hubbub.h | 1 + .../gpu/drm/amd/display/dc/inc/link_enc_cfg.h | 2 +- 7 files changed, 40 insertions(+), 13 deletions(-)