| Message ID | 20220414155756.249769-1-andrea.righi@canonical.com |
|---|---|
| Headers | show |
| Series | re-apply missing overlayfs SAUCE patch | expand |
On Thu, Apr 14, 2022 at 05:57:55PM +0200, Andrea Righi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1967924
...
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 4/14/22 09:57, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/1967924 > > [Impact] > > Starting with 5.13 we've incorrectly dropped the following sauce patch: > > UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files > > This patch seems to be required to use overlayfs on top of shiftfs and > without this patch we may break containers that rely on shiftfs (using > zfs/ceph as storage pool w/ shiftfs enabled). > > [Test case] > > No specific test case provided. > > [Fix] > > The original SAUCE patch relies on AUFS in order to use vma->vm_prfile, > but we're not providing AUFS anymore in jammy,. > > The fix consists of re-apply this patch with a little refactoring to be > dependent on CONFIG_AUFS_FS. > > [Regression potential] > > This patch is touching overlayfs, so we may see potential regressions in > overlayfs. > > ChangeLog (v1 -> v2): > - missing cover letter email > >
On 14.04.22 17:57, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/1967924 The bug report is against linux-azure and without any series nomination. The submission against linux. What is that meant to be for? -Stefan > > [Impact] > > Starting with 5.13 we've incorrectly dropped the following sauce patch: > > UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files > > This patch seems to be required to use overlayfs on top of shiftfs and > without this patch we may break containers that rely on shiftfs (using > zfs/ceph as storage pool w/ shiftfs enabled). > > [Test case] > > No specific test case provided. > > [Fix] > > The original SAUCE patch relies on AUFS in order to use vma->vm_prfile, > but we're not providing AUFS anymore in jammy,. > > The fix consists of re-apply this patch with a little refactoring to be > dependent on CONFIG_AUFS_FS. > > [Regression potential] > > This patch is touching overlayfs, so we may see potential regressions in > overlayfs. > > ChangeLog (v1 -> v2): > - missing cover letter email > >
On Tue, Apr 19, 2022 at 09:22:27AM +0200, Stefan Bader wrote: > On 14.04.22 17:57, Andrea Righi wrote: > > BugLink: https://bugs.launchpad.net/bugs/1967924 > > The bug report is against linux-azure and without any series nomination. The > submission against linux. What is that meant to be for? > > -Stefan Tracking bug fixed, that was obviously incorrect. Thanks for noticing it, Stefan, the bug is against jammy/linux and impish/linux, in practice this patch should be applied to all kernels >= 5.13. -Andrea > > > > > [Impact] > > > > Starting with 5.13 we've incorrectly dropped the following sauce patch: > > > > UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files > > > > This patch seems to be required to use overlayfs on top of shiftfs and > > without this patch we may break containers that rely on shiftfs (using > > zfs/ceph as storage pool w/ shiftfs enabled). > > > > [Test case] > > > > No specific test case provided. > > > > [Fix] > > > > The original SAUCE patch relies on AUFS in order to use vma->vm_prfile, > > but we're not providing AUFS anymore in jammy,. > > > > The fix consists of re-apply this patch with a little refactoring to be > > dependent on CONFIG_AUFS_FS. > > > > [Regression potential] > > > > This patch is touching overlayfs, so we may see potential regressions in > > overlayfs. > > > > ChangeLog (v1 -> v2): > > - missing cover letter email > > > > >
On 14.04.22 17:57, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/1967924 > > [Impact] > > Starting with 5.13 we've incorrectly dropped the following sauce patch: > > UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files > > This patch seems to be required to use overlayfs on top of shiftfs and > without this patch we may break containers that rely on shiftfs (using > zfs/ceph as storage pool w/ shiftfs enabled). > > [Test case] > > No specific test case provided. > > [Fix] > > The original SAUCE patch relies on AUFS in order to use vma->vm_prfile, > but we're not providing AUFS anymore in jammy,. > > The fix consists of re-apply this patch with a little refactoring to be > dependent on CONFIG_AUFS_FS. > > [Regression potential] > > This patch is touching overlayfs, so we may see potential regressions in > overlayfs. > > ChangeLog (v1 -> v2): > - missing cover letter email > > Applied to impish:linux/master-next (dropping one bug reference which had no impish target). Thanks. -Stefan
BugLink: https://bugs.launchpad.net/bugs/1967924 [Impact] Starting with 5.13 we've incorrectly dropped the following sauce patch: UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files This patch seems to be required to use overlayfs on top of shiftfs and without this patch we may break containers that rely on shiftfs (using zfs/ceph as storage pool w/ shiftfs enabled). [Test case] No specific test case provided. [Fix] The original SAUCE patch relies on AUFS in order to use vma->vm_prfile, but we're not providing AUFS anymore in jammy,. The fix consists of re-apply this patch with a little refactoring to be dependent on CONFIG_AUFS_FS. [Regression potential] This patch is touching overlayfs, so we may see potential regressions in overlayfs. ChangeLog (v1 -> v2): - missing cover letter email