mbox series

[0/1,SRU,OEM-5.14] Fix for rare suspend (s0ix) failures on AMD systems

Message ID 20220104193811.1506192-1-alex.hung@canonical.com
Headers show
Series Fix for rare suspend (s0ix) failures on AMD systems | expand

Message

Alex Hung Jan. 4, 2022, 7:38 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1956373

[Impact]

  A rare (~1%) failure has been reported in the community for a period of time
  on Renoir platforms with s0ix. This failure was also corroborated once by
  a Cezanne user.

[Fix]

  In the s0ix entry need retain gfx in the gfxoff state, so skipping setting
  gfx cgpg in the S0ix suspend-resume process.

  The fix was cherry-picked from 5.16-rc8.

[Test]

  This is requested by AMD.

[Where problems could occur]

  Low risk. This only affects AMD systems that support s0ix.

Prike Liang (1):
  drm/amd/pm: skip setting gfx cgpg in the s0ix suspend-resume

 drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c      | 7 ++-----
 drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 ++-
 2 files changed, 4 insertions(+), 6 deletions(-)

Comments

Tim Gardner Jan. 12, 2022, 4:55 p.m. UTC | #1 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 1/4/22 12:38 PM, Alex Hung wrote:
> BugLink: https://bugs.launchpad.net/bugs/1956373
> 
> [Impact]
> 
>    A rare (~1%) failure has been reported in the community for a period of time
>    on Renoir platforms with s0ix. This failure was also corroborated once by
>    a Cezanne user.
> 
> [Fix]
> 
>    In the s0ix entry need retain gfx in the gfxoff state, so skipping setting
>    gfx cgpg in the S0ix suspend-resume process.
> 
>    The fix was cherry-picked from 5.16-rc8.
> 
> [Test]
> 
>    This is requested by AMD.
> 
> [Where problems could occur]
> 
>    Low risk. This only affects AMD systems that support s0ix.
> 
> Prike Liang (1):
>    drm/amd/pm: skip setting gfx cgpg in the s0ix suspend-resume
> 
>   drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c      | 7 ++-----
>   drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 ++-
>   2 files changed, 4 insertions(+), 6 deletions(-)
>
Timo Aaltonen Jan. 17, 2022, 10:34 a.m. UTC | #2 
On 4.1.2022 21.38, Alex Hung wrote:
> BugLink: https://bugs.launchpad.net/bugs/1956373
> 
> [Impact]
> 
>    A rare (~1%) failure has been reported in the community for a period of time
>    on Renoir platforms with s0ix. This failure was also corroborated once by
>    a Cezanne user.
> 
> [Fix]
> 
>    In the s0ix entry need retain gfx in the gfxoff state, so skipping setting
>    gfx cgpg in the S0ix suspend-resume process.
> 
>    The fix was cherry-picked from 5.16-rc8.
> 
> [Test]
> 
>    This is requested by AMD.
> 
> [Where problems could occur]
> 
>    Low risk. This only affects AMD systems that support s0ix.
> 
> Prike Liang (1):
>    drm/amd/pm: skip setting gfx cgpg in the s0ix suspend-resume
> 
>   drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c      | 7 ++-----
>   drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 ++-
>   2 files changed, 4 insertions(+), 6 deletions(-)
> 

applied to oem-5.14, thanks

what about jammy?