mbox series

[0/2,SRU,OEM-5.13] intel/ipu6: fix the brightness using HIMX11B1 sensor

Message ID 20210819153718.1094711-1-vicamo.yang@canonical.com
Headers show
Series intel/ipu6: fix the brightness using HIMX11B1 sensor | expand

Message

You-Sheng Yang Aug. 19, 2021, 3:37 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1939539

[Impact]

Brightness settings for HIMX11B1 sensor were not correctly set so the
video output stream is almost completely dark.

[Fix]

Two commits from https://github.com/intel/ipu6-drivers are required to
fix this. Actually the second one is to correct the compiling errors
against 5.13 kernel that was introduced accidentally in the first commit.

[Test Case]

Run cheese on supported platform to grap video output stream for check.

[Where problems could occur]

This is the first time we have this sensor up and running with
meaningful output on real hardware. Expecting possible quality
adjustments and so on.

[Other Info]

While Intel doesn't officially commit the plan to upstream IPU6 driver,
we will only carry this on oem kernels. And since IPU6 oem-5.10
platforms are migrating to oem-5.13 as well, and we have neither 5.10
platforms with hm11b1 sensor previously, we're skipping oem-5.10 here.

Wang Yating (2):
  UBUNTU: SAUCE: sensor HM11b1 brightness bugfix
  UBUNTU: SAUCE: Fix build error on Kernel 5.13

 drivers/media/i2c/hm11b1.c | 329 ++++---------------------------------
 1 file changed, 32 insertions(+), 297 deletions(-)

Comments

Timo Aaltonen Aug. 20, 2021, 7:59 a.m. UTC | #1 
On 19.8.2021 18.37, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939539
> 
> [Impact]
> 
> Brightness settings for HIMX11B1 sensor were not correctly set so the
> video output stream is almost completely dark.
> 
> [Fix]
> 
> Two commits from https://github.com/intel/ipu6-drivers are required to
> fix this. Actually the second one is to correct the compiling errors
> against 5.13 kernel that was introduced accidentally in the first commit.
> 
> [Test Case]
> 
> Run cheese on supported platform to grap video output stream for check.
> 
> [Where problems could occur]
> 
> This is the first time we have this sensor up and running with
> meaningful output on real hardware. Expecting possible quality
> adjustments and so on.
> 
> [Other Info]
> 
> While Intel doesn't officially commit the plan to upstream IPU6 driver,
> we will only carry this on oem kernels. And since IPU6 oem-5.10
> platforms are migrating to oem-5.13 as well, and we have neither 5.10
> platforms with hm11b1 sensor previously, we're skipping oem-5.10 here.
> 
> Wang Yating (2):
>    UBUNTU: SAUCE: sensor HM11b1 brightness bugfix
>    UBUNTU: SAUCE: Fix build error on Kernel 5.13
> 
>   drivers/media/i2c/hm11b1.c | 329 ++++---------------------------------
>   1 file changed, 32 insertions(+), 297 deletions(-)
> 

applied to oem-5.13, thanks