mbox series

[0/3,SRU,OEM-5.13,I,U] Improve the Corp ME + S0ix support on e1000e

Message ID 20210818071049.561626-1-vicamo.yang@canonical.com
Headers show
Series Improve the Corp ME + S0ix support on e1000e | expand

Message

You-Sheng Yang Aug. 18, 2021, 7:10 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1937252

[Impact]

These improves power consumption on some e1000e platforms.

[Fix]

3 fixes in thread https://www.spinics.net/lists/netdev/msg755279.html
(now in netdev/net-next.git).

[Test Case]

These fixes solves two issues that the first one is the power
consumption would be lower to 1.651W from 2.032W when device enters
sleep state. The second is I219 may now enter ultra lower power mode
after resumed from s2idle.

[Where problems could occur]

While these fixes are still not in mainline but net-next, expecting some
more stability fix when necessary.

Sasha Neftin (3):
  e1000e: Add handshake with the CSME to support S0ix
  e1000e: Add polling mechanism to indicate CSME DPG exit
  e1000e: Additional PHY power saving in S0ix

 drivers/net/ethernet/intel/e1000e/ich8lan.h |   3 +
 drivers/net/ethernet/intel/e1000e/netdev.c  | 358 +++++++++++---------
 drivers/net/ethernet/intel/e1000e/regs.h    |   1 +
 3 files changed, 208 insertions(+), 154 deletions(-)

Comments

Tim Gardner Aug. 18, 2021, 11:32 a.m. UTC | #1 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

These patches aren't "UBUNTU: SAUCE:", which can be fixed when they are 
applied. They are also already in linux-next, so the provenance is well 
known.

rtg

On 8/18/21 1:10 AM, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1937252
> 
> [Impact]
> 
> These improves power consumption on some e1000e platforms.
> 
> [Fix]
> 
> 3 fixes in thread https://www.spinics.net/lists/netdev/msg755279.html
> (now in netdev/net-next.git).
> 
> [Test Case]
> 
> These fixes solves two issues that the first one is the power
> consumption would be lower to 1.651W from 2.032W when device enters
> sleep state. The second is I219 may now enter ultra lower power mode
> after resumed from s2idle.
> 
> [Where problems could occur]
> 
> While these fixes are still not in mainline but net-next, expecting some
> more stability fix when necessary.
> 
> Sasha Neftin (3):
>    e1000e: Add handshake with the CSME to support S0ix
>    e1000e: Add polling mechanism to indicate CSME DPG exit
>    e1000e: Additional PHY power saving in S0ix
> 
>   drivers/net/ethernet/intel/e1000e/ich8lan.h |   3 +
>   drivers/net/ethernet/intel/e1000e/netdev.c  | 358 +++++++++++---------
>   drivers/net/ethernet/intel/e1000e/regs.h    |   1 +
>   3 files changed, 208 insertions(+), 154 deletions(-)
>
Timo Aaltonen Aug. 18, 2021, 1:54 p.m. UTC | #2 
On 18.8.2021 10.10, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1937252
> 
> [Impact]
> 
> These improves power consumption on some e1000e platforms.
> 
> [Fix]
> 
> 3 fixes in thread https://www.spinics.net/lists/netdev/msg755279.html
> (now in netdev/net-next.git).
> 
> [Test Case]
> 
> These fixes solves two issues that the first one is the power
> consumption would be lower to 1.651W from 2.032W when device enters
> sleep state. The second is I219 may now enter ultra lower power mode
> after resumed from s2idle.
> 
> [Where problems could occur]
> 
> While these fixes are still not in mainline but net-next, expecting some
> more stability fix when necessary.
> 
> Sasha Neftin (3):
>    e1000e: Add handshake with the CSME to support S0ix
>    e1000e: Add polling mechanism to indicate CSME DPG exit
>    e1000e: Additional PHY power saving in S0ix
> 
>   drivers/net/ethernet/intel/e1000e/ich8lan.h |   3 +
>   drivers/net/ethernet/intel/e1000e/netdev.c  | 358 +++++++++++---------
>   drivers/net/ethernet/intel/e1000e/regs.h    |   1 +
>   3 files changed, 208 insertions(+), 154 deletions(-)
> 

applied to oem-5.13, thanks
Paolo Pisati Aug. 18, 2021, 2:05 p.m. UTC | #3 
On Wed, Aug 18, 2021 at 03:10:46PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1937252