| Message ID | 20210720133107.99079-1-dimitri.ledkov@canonical.com |
|---|---|
| Headers | show |
| Series | snapcraft.yaml specify build base core20 | expand |
On 20.07.21 15:31, Dimitri John Ledkov wrote: > Set `build-base: core20` on focal based kernel snaps in > snapcraft.yaml. This will allow both local snapcraft & launchpad > auto-detect and select focal as the build host for our kernel > snaps. This will also allow to remove "focal" series override from > /+snap/ LP objects, making the /+snap/ settings modifyable with web-ui > once again (as focal series option was only available over the API, > not web-ui). > > Providing patches for pc, pc-low-latency, pi, pi-test snaps. The most > recently introduced intel snap already has this change applied. > > Dimitri John Ledkov (1): > snapcraft.yaml: specify build-base core20 > > snapcraft.yaml | 1 + > 1 file changed, 1 insertion(+) > I would omit *-test from patching. Those branches are meant to try out something (I believe they do not do automatic builds). Instead I would hope (not sure the ACL allows) that whoever has need of a test branch first moves it to the tip of the related real branch. So any updates land there. But for the other changes: Acked-by: Stefan Bader <stefan.bader@canonical.com>
On Wed, Jul 21, 2021 at 8:43 AM Stefan Bader <stefan.bader@canonical.com> wrote: > > On 20.07.21 15:31, Dimitri John Ledkov wrote: > > Set `build-base: core20` on focal based kernel snaps in > > snapcraft.yaml. This will allow both local snapcraft & launchpad > > auto-detect and select focal as the build host for our kernel > > snaps. This will also allow to remove "focal" series override from > > /+snap/ LP objects, making the /+snap/ settings modifyable with web-ui > > once again (as focal series option was only available over the API, > > not web-ui). > > > > Providing patches for pc, pc-low-latency, pi, pi-test snaps. The most > > recently introduced intel snap already has this change applied. > > > > Dimitri John Ledkov (1): > > snapcraft.yaml: specify build-base core20 > > > > snapcraft.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > I would omit *-test from patching. Those branches are meant to try out something > (I believe they do not do automatic builds). Instead I would hope (not sure the > ACL allows) that whoever has need of a test branch first moves it to the tip of > the related real branch. So any updates land there. > But for the other changes: Noted for the future.
These were applied to all active snaps at the time that I had access to a while ago. Some more obscure snaps that I don't have ACL access may still need fixing. It is left as an exercise for the maintainers of those.