| Message ID | 20210603122759.26149-1-jeremy.szu@canonical.com |
|---|---|
| Headers | show |
| Series | Mic-mute/mute LEDs not work on some HP platforms | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 6/3/21 6:27 AM, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1930707 > > [Impact] > The mic mute/audio mute LEDS are not work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > The right channel of internal speaker doesn't work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > > [Fix] > These four platforms need specific quirk for different hardware layout. > Thus, add the quirks for them. > > [Test] > After applying the quirk, the LEDs/function are work good on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > > [Where problems could occur] > If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/function will not work when muting audio-output or microphone). > > Jeremy Szu (4): > ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 15 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 17 G8 > > sound/pci/hda/patch_realtek.c | 4 ++++ > 1 file changed, 4 insertions(+) >
On 03.06.21 14:27, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1930707 > > [Impact] > The mic mute/audio mute LEDS are not work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > The right channel of internal speaker doesn't work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > > [Fix] > These four platforms need specific quirk for different hardware layout. > Thus, add the quirks for them. > > [Test] > After applying the quirk, the LEDs/function are work good on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > > [Where problems could occur] > If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/function will not work when muting audio-output or microphone). > > Jeremy Szu (4): > ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 15 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 17 G8 > > sound/pci/hda/patch_realtek.c | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Stefan Bader <stefan.bader@canonical.com>
On Thu, Jun 03, 2021 at 08:27:55PM +0800, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1930707
We got these patches as part of v5.13-rc4, so NAKing here.
On 03.06.21 14:27, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1930707 > > [Impact] > The mic mute/audio mute LEDS are not work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > The right channel of internal speaker doesn't work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > > [Fix] > These four platforms need specific quirk for different hardware layout. > Thus, add the quirks for them. > > [Test] > After applying the quirk, the LEDs/function are work good on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > > [Where problems could occur] > If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/function will not work when muting audio-output or microphone). > > Jeremy Szu (4): > ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 15 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 17 G8 > > sound/pci/hda/patch_realtek.c | 4 ++++ > 1 file changed, 4 insertions(+) > Applied to hirsute:linux/master-next. Thanks. -Stefan
On 3.6.2021 15.27, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1930707 > > [Impact] > The mic mute/audio mute LEDS are not work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > The right channel of internal speaker doesn't work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > > [Fix] > These four platforms need specific quirk for different hardware layout. > Thus, add the quirks for them. > > [Test] > After applying the quirk, the LEDs/function are work good on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > > [Where problems could occur] > If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/function will not work when muting audio-output or microphone). > > Jeremy Szu (4): > ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 15 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 17 G8 > > sound/pci/hda/patch_realtek.c | 4 ++++ > 1 file changed, 4 insertions(+) > applied to oem-5.10, thanks
Hi Stefan, Would you please help to check whether these patches will be landed in impish? I didn't see the impish series on Launchpad bug https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1930707 I'm preparing the other SRU which will get conflict because these patches are missing in impish. On Thu, Jun 3, 2021 at 8:28 PM Jeremy Szu <jeremy.szu@canonical.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/1930707 > > [Impact] > The mic mute/audio mute LEDS are not work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > The right channel of internal speaker doesn't work on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > > [Fix] > These four platforms need specific quirk for different hardware layout. > Thus, add the quirks for them. > > [Test] > After applying the quirk, the LEDs/function are work good on > 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC > 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC > 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC > 4) HP EliteBook 855 G8 Notebook PC > > [Where problems could occur] > If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/function will not work when muting audio-output or microphone). > > Jeremy Szu (4): > ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 15 G8 > ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury > 17 G8 > > sound/pci/hda/patch_realtek.c | 4 ++++ > 1 file changed, 4 insertions(+) > > -- > 2.25.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 15.06.21 14:09, Jeremy Szu wrote: > Hi Stefan, > > Would you please help to check whether these patches will be landed in impish? > I didn't see the impish series on Launchpad bug > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1930707 > > I'm preparing the other SRU which will get conflict because these > patches are missing in impish. Which Impish do you mean? The 5.11 forward-ports there will get updated once they get cranked in the upcoming cycle. The unstable kernel got the patch from upstream. But while the Impish kernel remains at 5.11 it mirrors the Hirsute kernel. -Stefan > > On Thu, Jun 3, 2021 at 8:28 PM Jeremy Szu <jeremy.szu@canonical.com> wrote: >> >> BugLink: https://bugs.launchpad.net/bugs/1930707 >> >> [Impact] >> The mic mute/audio mute LEDS are not work on >> 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC >> 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC >> 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC >> 4) HP EliteBook 855 G8 Notebook PC >> The right channel of internal speaker doesn't work on >> 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC >> 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC >> 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC >> >> [Fix] >> These four platforms need specific quirk for different hardware layout. >> Thus, add the quirks for them. >> >> [Test] >> After applying the quirk, the LEDs/function are work good on >> 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC >> 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC >> 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC >> 4) HP EliteBook 855 G8 Notebook PC >> >> [Where problems could occur] >> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/function will not work when muting audio-output or microphone). >> >> Jeremy Szu (4): >> ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 >> ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook G8 >> ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury >> 15 G8 >> ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury >> 17 G8 >> >> sound/pci/hda/patch_realtek.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> -- >> 2.25.1 >> >> >> -- >> kernel-team mailing list >> kernel-team@lists.ubuntu.com >> https://lists.ubuntu.com/mailman/listinfo/kernel-team > > >
BugLink: https://bugs.launchpad.net/bugs/1930707 [Impact] The mic mute/audio mute LEDS are not work on 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC 4) HP EliteBook 855 G8 Notebook PC The right channel of internal speaker doesn't work on 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC [Fix] These four platforms need specific quirk for different hardware layout. Thus, add the quirks for them. [Test] After applying the quirk, the LEDs/function are work good on 1) HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC 2) HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC 3) HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC 4) HP EliteBook 855 G8 Notebook PC [Where problems could occur] If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/function will not work when muting audio-output or microphone). Jeremy Szu (4): ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook G8 ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury 15 G8 ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury 17 G8 sound/pci/hda/patch_realtek.c | 4 ++++ 1 file changed, 4 insertions(+)