| Message ID | 20210312143537.63316-1-krzysztof.kozlowski@canonical.com |
|---|---|
| Headers | show |
| Series | CVE-2019-19061 | expand |
On 12/03/2021 14:35, Krzysztof Kozlowski wrote: > CVE-2019-19061 > > [Impact] > A memory leak in adis16400 IIO IMU driver could cause excessive memory > usage via the IIO interface. > > [Fix] > Upstream commit 9c0530e898f384c5d279bfcebd8bb17af1105873 with > adjustement: it applies to drivers/iio/imu/adis16400_buffer.c instead of > drivers/iio/imu/adis_buffer.c (because later that code was moved from > adis16400_buffer.c to adis_buffer.c). > > [Test Case] > None. > > [Regression Potential] FYI, this has been renamed to [Where problems could occur] and [Test Case] to [Test Plan], see: https://wiki.ubuntu.com/StableReleaseUpdates But we can let that slip for this fix. > Patch touches error path for memory allocation failure so that code > won't be called too much. > Exact backport is also in linux-4.19.y commit > c57c213538156bff971aa352d9d7749196dfbfd8. > > Best regards, > Krzysztof > > > Navid Emamdoost (1): > iio: imu: adis16400: fix memory leak > > drivers/iio/imu/adis16400_buffer.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Looks good to me. Acked-by: Colin Ian King <colin.king@canonical.com>
On 12/03/2021 15:42, Colin Ian King wrote: > On 12/03/2021 14:35, Krzysztof Kozlowski wrote: >> CVE-2019-19061 >> >> [Impact] >> A memory leak in adis16400 IIO IMU driver could cause excessive memory >> usage via the IIO interface. >> >> [Fix] >> Upstream commit 9c0530e898f384c5d279bfcebd8bb17af1105873 with >> adjustement: it applies to drivers/iio/imu/adis16400_buffer.c instead of >> drivers/iio/imu/adis_buffer.c (because later that code was moved from >> adis16400_buffer.c to adis_buffer.c). >> >> [Test Case] >> None. >> >> [Regression Potential] > > FYI, this has been renamed to [Where problems could occur] and [Test > Case] to [Test Plan], see: > > https://wiki.ubuntu.com/StableReleaseUpdates I took it from https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat. I'll update my bookmarks, thanks! Best regards, Krzysztof
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 3/12/21 7:35 AM, Krzysztof Kozlowski wrote: > CVE-2019-19061 > > [Impact] > A memory leak in adis16400 IIO IMU driver could cause excessive memory > usage via the IIO interface. > > [Fix] > Upstream commit 9c0530e898f384c5d279bfcebd8bb17af1105873 with > adjustement: it applies to drivers/iio/imu/adis16400_buffer.c instead of > drivers/iio/imu/adis_buffer.c (because later that code was moved from > adis16400_buffer.c to adis_buffer.c). > > [Test Case] > None. > > [Regression Potential] > Patch touches error path for memory allocation failure so that code > won't be called too much. > Exact backport is also in linux-4.19.y commit > c57c213538156bff971aa352d9d7749196dfbfd8. > > Best regards, > Krzysztof > > > Navid Emamdoost (1): > iio: imu: adis16400: fix memory leak > > drivers/iio/imu/adis16400_buffer.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >
Applied to xenial/master-next. Thanks. I modified the commit log slightly to indicate backported instead of cherry-picked since the upstream patch applies to a different file per your description. -rtg On 3/12/21 7:35 AM, Krzysztof Kozlowski wrote: > CVE-2019-19061 > > [Impact] > A memory leak in adis16400 IIO IMU driver could cause excessive memory > usage via the IIO interface. > > [Fix] > Upstream commit 9c0530e898f384c5d279bfcebd8bb17af1105873 with > adjustement: it applies to drivers/iio/imu/adis16400_buffer.c instead of > drivers/iio/imu/adis_buffer.c (because later that code was moved from > adis16400_buffer.c to adis_buffer.c). > > [Test Case] > None. > > [Regression Potential] > Patch touches error path for memory allocation failure so that code > won't be called too much. > Exact backport is also in linux-4.19.y commit > c57c213538156bff971aa352d9d7749196dfbfd8. > > Best regards, > Krzysztof > > > Navid Emamdoost (1): > iio: imu: adis16400: fix memory leak > > drivers/iio/imu/adis16400_buffer.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >