| Message ID | 20201130081302.372240-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Refresh ACPI wakeup power to make Thunderbolt hotplug detection work | expand |
On 30.11.20 09:13, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1906229 > > [Impact] > Dell Precision 5550 cannot detect Thunderbolt device hotplug. > > [Fix] > Refresh ACPI wakeup power if it's already enabled to make GPE work. > > [Test] > Make sure the root port of TBT hierachy is in D3cold. > Plug a Thunderbolt Dock or Thunderbolt Disk, the system cannot detect > anything. > > With the patch applied, OS can always detect hotplugged Thunderbolt > devices. > > [Where problems could occur] > Though we refresh the wakeup device power, we didn't disable/enable ACPI > GPEs, so we won't miss any GPE event from this fix. > > Rafael J. Wysocki (2): > PM: ACPI: PCI: Drop acpi_pm_set_bridge_wakeup() > PM: ACPI: Refresh wakeup device power configuration every time > > drivers/acpi/device_pm.c | 62 +++++++++++++++++++--------------------- > drivers/pci/pci-acpi.c | 4 +-- > include/acpi/acpi_bus.h | 5 ---- > 3 files changed, 31 insertions(+), 40 deletions(-) > Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 30.11.20 09:13, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1906229 > > [Impact] > Dell Precision 5550 cannot detect Thunderbolt device hotplug. > > [Fix] > Refresh ACPI wakeup power if it's already enabled to make GPE work. > > [Test] > Make sure the root port of TBT hierachy is in D3cold. > Plug a Thunderbolt Dock or Thunderbolt Disk, the system cannot detect > anything. > > With the patch applied, OS can always detect hotplugged Thunderbolt > devices. > > [Where problems could occur] > Though we refresh the wakeup device power, we didn't disable/enable ACPI > GPEs, so we won't miss any GPE event from this fix. > > Rafael J. Wysocki (2): > PM: ACPI: PCI: Drop acpi_pm_set_bridge_wakeup() > PM: ACPI: Refresh wakeup device power configuration every time > > drivers/acpi/device_pm.c | 62 +++++++++++++++++++--------------------- > drivers/pci/pci-acpi.c | 4 +-- > include/acpi/acpi_bus.h | 5 ---- > 3 files changed, 31 insertions(+), 40 deletions(-) > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 30.11.2020 10.13, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1906229 > > [Impact] > Dell Precision 5550 cannot detect Thunderbolt device hotplug. > > [Fix] > Refresh ACPI wakeup power if it's already enabled to make GPE work. > > [Test] > Make sure the root port of TBT hierachy is in D3cold. > Plug a Thunderbolt Dock or Thunderbolt Disk, the system cannot detect > anything. > > With the patch applied, OS can always detect hotplugged Thunderbolt > devices. > > [Where problems could occur] > Though we refresh the wakeup device power, we didn't disable/enable ACPI > GPEs, so we won't miss any GPE event from this fix. > > Rafael J. Wysocki (2): > PM: ACPI: PCI: Drop acpi_pm_set_bridge_wakeup() > PM: ACPI: Refresh wakeup device power configuration every time > > drivers/acpi/device_pm.c | 62 +++++++++++++++++++--------------------- > drivers/pci/pci-acpi.c | 4 +-- > include/acpi/acpi_bus.h | 5 ---- > 3 files changed, 31 insertions(+), 40 deletions(-) > applied to oem-5.6, thanks
Applied to focal/linux Applied to groovy/linux Thanks, Ian On 2020-11-30 16:13:00 , Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1906229 > > [Impact] > Dell Precision 5550 cannot detect Thunderbolt device hotplug. > > [Fix] > Refresh ACPI wakeup power if it's already enabled to make GPE work. > > [Test] > Make sure the root port of TBT hierachy is in D3cold. > Plug a Thunderbolt Dock or Thunderbolt Disk, the system cannot detect > anything. > > With the patch applied, OS can always detect hotplugged Thunderbolt > devices. > > [Where problems could occur] > Though we refresh the wakeup device power, we didn't disable/enable ACPI > GPEs, so we won't miss any GPE event from this fix. > > Rafael J. Wysocki (2): > PM: ACPI: PCI: Drop acpi_pm_set_bridge_wakeup() > PM: ACPI: Refresh wakeup device power configuration every time > > drivers/acpi/device_pm.c | 62 +++++++++++++++++++--------------------- > drivers/pci/pci-acpi.c | 4 +-- > include/acpi/acpi_bus.h | 5 ---- > 3 files changed, 31 insertions(+), 40 deletions(-) > > -- > 2.29.2 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On Mon, Nov 30, 2020 at 04:13:00PM +0800, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1906229 > > [Impact] > Dell Precision 5550 cannot detect Thunderbolt device hotplug. > > [Fix] > Refresh ACPI wakeup power if it's already enabled to make GPE work. > > [Test] > Make sure the root port of TBT hierachy is in D3cold. > Plug a Thunderbolt Dock or Thunderbolt Disk, the system cannot detect > anything. > > With the patch applied, OS can always detect hotplugged Thunderbolt > devices. > > [Where problems could occur] > Though we refresh the wakeup device power, we didn't disable/enable ACPI > GPEs, so we won't miss any GPE event from this fix. Applied to unstable/master, thanks!