mbox series

[0/3,B,SRU] hns3: add hns3_gro_complete for HW GRO process

Message ID 20201008053159.12336-1-ike.pan@canonical.com
Headers show
Series hns3: add hns3_gro_complete for HW GRO process | expand

Message

Ike Panhc Oct. 8, 2020, 5:31 a.m. UTC 
BugLink: https://launchpad.net/bugs/1893711

We get report that kernel oops when hardware GRO enabled on hns3
interfaces. Cherry-picking patches from upstream can solve this issue.

The patches needed are
 d474d88f8826 ("net: hns3: add hns3_gro_complete for HW GRO process")
 a4d2cdcbb878 ("net: hns3: minor refactor for hns3_rx_checksum")
and they depend on
 c376fa1aae63 ("net: hns3: add rx multicast packets statistic")

e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path") is also
needed but since there is no function changes, to backport patch for
hns3_gro_complete is an easier and simpler solution.

Jian Shen (1):
  net: hns3: add rx multicast packets statistic

Yunsheng Lin (2):
  net: hns3: minor refactor for hns3_rx_checksum
  net: hns3: add hns3_gro_complete for HW GRO process

 .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 203 +++++++++++-------
 .../net/ethernet/hisilicon/hns3/hns3_enet.h   |   8 +
 .../ethernet/hisilicon/hns3/hns3_ethtool.c    |   1 +
 3 files changed, 133 insertions(+), 79 deletions(-)

Comments

Stefan Bader Oct. 8, 2020, 9:36 a.m. UTC | #1 
On 08.10.20 07:31, Ike Panhc wrote:
> BugLink: https://launchpad.net/bugs/1893711
> 
> We get report that kernel oops when hardware GRO enabled on hns3
> interfaces. Cherry-picking patches from upstream can solve this issue.
> 
> The patches needed are
>  d474d88f8826 ("net: hns3: add hns3_gro_complete for HW GRO process")
>  a4d2cdcbb878 ("net: hns3: minor refactor for hns3_rx_checksum")
> and they depend on
>  c376fa1aae63 ("net: hns3: add rx multicast packets statistic")
> 
> e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path") is also
> needed but since there is no function changes, to backport patch for
> hns3_gro_complete is an easier and simpler solution.
> 
> Jian Shen (1):
>   net: hns3: add rx multicast packets statistic
> 
> Yunsheng Lin (2):
>   net: hns3: minor refactor for hns3_rx_checksum
>   net: hns3: add hns3_gro_complete for HW GRO process
> 
>  .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 203 +++++++++++-------
>  .../net/ethernet/hisilicon/hns3/hns3_enet.h   |   8 +
>  .../ethernet/hisilicon/hns3/hns3_ethtool.c    |   1 +
>  3 files changed, 133 insertions(+), 79 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza Oct. 8, 2020, 1:37 p.m. UTC | #2 
On 08.10.20 07:31, Ike Panhc wrote:
> BugLink: https://launchpad.net/bugs/1893711
> 
> We get report that kernel oops when hardware GRO enabled on hns3
> interfaces. Cherry-picking patches from upstream can solve this issue.
> 
> The patches needed are
>  d474d88f8826 ("net: hns3: add hns3_gro_complete for HW GRO process")
>  a4d2cdcbb878 ("net: hns3: minor refactor for hns3_rx_checksum")
> and they depend on
>  c376fa1aae63 ("net: hns3: add rx multicast packets statistic")
> 
> e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path") is also
> needed but since there is no function changes, to backport patch for
> hns3_gro_complete is an easier and simpler solution.
> 
> Jian Shen (1):
>   net: hns3: add rx multicast packets statistic
> 
> Yunsheng Lin (2):
>   net: hns3: minor refactor for hns3_rx_checksum
>   net: hns3: add hns3_gro_complete for HW GRO process
> 
>  .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 203 +++++++++++-------
>  .../net/ethernet/hisilicon/hns3/hns3_enet.h   |   8 +
>  .../ethernet/hisilicon/hns3/hns3_ethtool.c    |   1 +
>  3 files changed, 133 insertions(+), 79 deletions(-)
> 


Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Ian May Oct. 8, 2020, 10:39 p.m. UTC | #3 
Applied to Bionic/master-next.  

Thanks!
Ian

On 2020-10-08 13:31:59 , Ike Panhc wrote:
> BugLink: https://launchpad.net/bugs/1893711
> 
> We get report that kernel oops when hardware GRO enabled on hns3
> interfaces. Cherry-picking patches from upstream can solve this issue.
> 
> The patches needed are
>  d474d88f8826 ("net: hns3: add hns3_gro_complete for HW GRO process")
>  a4d2cdcbb878 ("net: hns3: minor refactor for hns3_rx_checksum")
> and they depend on
>  c376fa1aae63 ("net: hns3: add rx multicast packets statistic")
> 
> e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path") is also
> needed but since there is no function changes, to backport patch for
> hns3_gro_complete is an easier and simpler solution.
> 
> Jian Shen (1):
>   net: hns3: add rx multicast packets statistic
> 
> Yunsheng Lin (2):
>   net: hns3: minor refactor for hns3_rx_checksum
>   net: hns3: add hns3_gro_complete for HW GRO process
> 
>  .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 203 +++++++++++-------
>  .../net/ethernet/hisilicon/hns3/hns3_enet.h   |   8 +
>  .../ethernet/hisilicon/hns3/hns3_ethtool.c    |   1 +
>  3 files changed, 133 insertions(+), 79 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team