mbox series

[G,SRU,0/1] Remove duplicated code in ip_defrag.sh of kselftests/net

Message ID 20200903082813.25646-1-po-hsu.lin@canonical.com
Headers show
Series Remove duplicated code in ip_defrag.sh of kselftests/net | expand

Message

Po-Hsu Lin Sept. 3, 2020, 8:28 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1894062

== SRU Justification ==
In Groovy, patch 6c6ab1256 "UBUNTU: SAUCE: selftests: net: ip_defrag:
modprobe missing nf_defrag_ipv6 support" has been applied again with
commit aba69d49

Therefore there are two lines with:
modprobe -q nf_defrag_ipv6

== Fix ==
Revert the SAUCE patch can correct this, and it can make our code
matches with the one upstream.

== Regression Potential ==
Low, change limited to testing tools and it's only removing the
duplicated code.

Po-Hsu Lin (1):
  Revert "UBUNTU: SAUCE: selftests: net: ip_defrag: modprobe missing
    nf_defrag_ipv6 support"

 tools/testing/selftests/net/ip_defrag.sh | 2 --
 1 file changed, 2 deletions(-)

Comments

Paolo Pisati Sept. 3, 2020, 8:54 a.m. UTC | #1 
On Thu, Sep 03, 2020 at 04:28:12PM +0800, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1894062

Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
Seth Forshee Sept. 22, 2020, 3:35 p.m. UTC | #2 
On Thu, Sep 03, 2020 at 04:28:12PM +0800, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1894062
> 
> == SRU Justification ==
> In Groovy, patch 6c6ab1256 "UBUNTU: SAUCE: selftests: net: ip_defrag:
> modprobe missing nf_defrag_ipv6 support" has been applied again with
> commit aba69d49
> 
> Therefore there are two lines with:
> modprobe -q nf_defrag_ipv6
> 
> == Fix ==
> Revert the SAUCE patch can correct this, and it can make our code
> matches with the one upstream.
> 
> == Regression Potential ==
> Low, change limited to testing tools and it's only removing the
> duplicated code.

Applied to groovy/master-next, thanks!