mbox series

[FOCAL/linux-azure,BIONIC/linux-azure-4.15,0/3] SF Case 276849 speed for CX4 VF showing as unknown in ethtool output

Message ID 20200817123740.6938-1-william.gray@canonical.com
Headers show
Series SF Case 276849 speed for CX4 VF showing as unknown in ethtool output | expand

Message

William Breathitt Gray Aug. 17, 2020, 12:37 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1876770

The FOCAL/linux-azure patches are simpl cherry picks, but the
BIONIC/linux-azure-4.15 patches required backports. In particular, the
"[BIONIC/linux-azure-4.15][PATCH 2/3] net/mlx5: Expose port speed when
possible" patch required a refactoring to the data_rate_oper check for
get_speed_duplex() in order to work with the 4.15 version of the code.

Mark Bloch (3):
  net/mlx5: Expose link speed directly
  net/mlx5: Expose port speed when possible
  net/mlx5: Tidy up and fix reverse christmas ordring

 .../ethernet/mellanox/mlx5/core/en_ethtool.c  | 24 ++++++++++++-------
 include/linux/mlx5/mlx5_ifc.h                 |  3 ++-
 2 files changed, 17 insertions(+), 10 deletions(-)

Comments

Stefan Bader Aug. 18, 2020, 8:18 a.m. UTC | #1 
On 17.08.20 14:37, William Breathitt Gray wrote:
> BugLink: https://bugs.launchpad.net/bugs/1876770
> 
> The FOCAL/linux-azure patches are simpl cherry picks, but the
> BIONIC/linux-azure-4.15 patches required backports. In particular, the
> "[BIONIC/linux-azure-4.15][PATCH 2/3] net/mlx5: Expose port speed when
> possible" patch required a refactoring to the data_rate_oper check for
> get_speed_duplex() in order to work with the 4.15 version of the code.
> 
> Mark Bloch (3):
>   net/mlx5: Expose link speed directly
>   net/mlx5: Expose port speed when possible
>   net/mlx5: Tidy up and fix reverse christmas ordring
> 
>  .../ethernet/mellanox/mlx5/core/en_ethtool.c  | 24 ++++++++++++-------
>  include/linux/mlx5/mlx5_ifc.h                 |  3 ++-
>  2 files changed, 17 insertions(+), 10 deletions(-)
> 
Fixed up bug report nominations.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Colin Ian King Aug. 18, 2020, 8:23 a.m. UTC | #2 
On 17/08/2020 13:37, William Breathitt Gray wrote:
> BugLink: https://bugs.launchpad.net/bugs/1876770
> 
> The FOCAL/linux-azure patches are simpl cherry picks, but the
> BIONIC/linux-azure-4.15 patches required backports. In particular, the
> "[BIONIC/linux-azure-4.15][PATCH 2/3] net/mlx5: Expose port speed when
> possible" patch required a refactoring to the data_rate_oper check for
> get_speed_duplex() in order to work with the 4.15 version of the code.
> 
> Mark Bloch (3):
>   net/mlx5: Expose link speed directly
>   net/mlx5: Expose port speed when possible
>   net/mlx5: Tidy up and fix reverse christmas ordring
> 
>  .../ethernet/mellanox/mlx5/core/en_ethtool.c  | 24 ++++++++++++-------
>  include/linux/mlx5/mlx5_ifc.h                 |  3 ++-
>  2 files changed, 17 insertions(+), 10 deletions(-)
> 

Focal: clean cherry picks,
Bionic: backport looks good.

Thanks William

Acked-by: Colin Ian King <colin.king@canonical.com>
Khalid Elmously Aug. 28, 2020, 4:16 a.m. UTC | #3 
On 2020-08-17 08:37:34 , William Breathitt Gray wrote:
> BugLink: https://bugs.launchpad.net/bugs/1876770
> 
> The FOCAL/linux-azure patches are simpl cherry picks, but the
> BIONIC/linux-azure-4.15 patches required backports. In particular, the
> "[BIONIC/linux-azure-4.15][PATCH 2/3] net/mlx5: Expose port speed when
> possible" patch required a refactoring to the data_rate_oper check for
> get_speed_duplex() in order to work with the 4.15 version of the code.
> 
> Mark Bloch (3):
>   net/mlx5: Expose link speed directly
>   net/mlx5: Expose port speed when possible
>   net/mlx5: Tidy up and fix reverse christmas ordring
> 
>  .../ethernet/mellanox/mlx5/core/en_ethtool.c  | 24 ++++++++++++-------
>  include/linux/mlx5/mlx5_ifc.h                 |  3 ++-
>  2 files changed, 17 insertions(+), 10 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team