mbox series

[SRU,F,v2,00/18] ASoC/amd: add audio driver for amd renoir

Message ID 20200601021846.20490-1-hui.wang@canonical.com
Headers show
Series ASoC/amd: add audio driver for amd renoir | expand

Message

Hui Wang June 1, 2020, 2:18 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1881046

The SRU of v1 is only for oem-5.6 and unstable, it has some problem for
focal, so I did some change for focal and sent this v2 for focal only.

v1 is for oem-5.6 and unstable
v2 is for focal


[Impact]
We have a couple of LENOVO machines which has amd renoir audio on
them, our kernel doesn't have the driver for it yet.

[Fix]
amd just upstreamed the driver, it is for kernel-5.8, we backport
them to ubunt kernel.

[Test Case]
boot the kernel with those patches, we could see a sound card named
"acp" and the dmic on it could record sound via arecord.

[Regression Risk]
Low, just adding a new driver, no change to existing drivers.


Hui Wang (1):
  UBUNTU: [Config]: enable amd renoir ASoC audio

Vijendar Mukunda (17):
  ASoC: amd: add Renoir ACP3x IP register header
  ASoC: amd: add Renoir ACP PCI driver
  ASoC: amd: add acp init/de-init functions
  ASoC: amd: create acp3x pdm platform device
  ASoC: amd: add ACP3x PDM platform driver
  ASoC: amd: irq handler changes for ACP3x PDM dma driver
  ASoC: amd: add acp3x pdm driver dma ops
  ASoC: amd: add ACP PDM DMA driver dai ops
  ASoC: amd: add Renoir ACP PCI driver PM ops
  ASoC: amd: add ACP PDM DMA driver pm ops
  ASoC: amd: enable Renoir acp3x drivers build
  ASoC: amd: create platform devices for Renoir
  ASoC: amd: RN machine driver using dmic
  ASoC: amd: enable build for RN machine driver
  ASoC: amd: fix kernel warning
  ASoC: amd: refactoring dai_hw_params() callback
  ASoC: amd: return error when acp de-init fails

 debian.master/config/annotations           |   4 +
 debian.master/config/config.common.ubuntu  |   2 +
 sound/soc/amd/Kconfig                      |  13 +
 sound/soc/amd/Makefile                     |   1 +
 sound/soc/amd/renoir/Makefile              |   7 +
 sound/soc/amd/renoir/acp3x-pdm-dma.c       | 549 +++++++++++++++++++++
 sound/soc/amd/renoir/acp3x-rn.c            |  77 +++
 sound/soc/amd/renoir/rn-pci-acp3x.c        | 344 +++++++++++++
 sound/soc/amd/renoir/rn_acp3x.h            |  88 ++++
 sound/soc/amd/renoir/rn_chip_offset_byte.h | 349 +++++++++++++
 10 files changed, 1434 insertions(+)
 create mode 100644 sound/soc/amd/renoir/Makefile
 create mode 100644 sound/soc/amd/renoir/acp3x-pdm-dma.c
 create mode 100644 sound/soc/amd/renoir/acp3x-rn.c
 create mode 100644 sound/soc/amd/renoir/rn-pci-acp3x.c
 create mode 100644 sound/soc/amd/renoir/rn_acp3x.h
 create mode 100644 sound/soc/amd/renoir/rn_chip_offset_byte.h

Comments

Kleber Sacilotto de Souza June 4, 2020, 8:54 a.m. UTC | #1 
On 2020-06-01 04:18, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1881046
> 
> The SRU of v1 is only for oem-5.6 and unstable, it has some problem for
> focal, so I did some change for focal and sent this v2 for focal only.
> 
> v1 is for oem-5.6 and unstable
> v2 is for focal
> 
> 
> [Impact]
> We have a couple of LENOVO machines which has amd renoir audio on
> them, our kernel doesn't have the driver for it yet.
> 
> [Fix]
> amd just upstreamed the driver, it is for kernel-5.8, we backport
> them to ubunt kernel.
> 
> [Test Case]
> boot the kernel with those patches, we could see a sound card named
> "acp" and the dmic on it could record sound via arecord.
> 
> [Regression Risk]
> Low, just adding a new driver, no change to existing drivers.

Thanks for squashing the backport changes in the original patches.

However, the provenance is still mentioning the sound subsystem maintainer
tree instead of linux-next. This can be fixed when applying though.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>


> 
> 
> Hui Wang (1):
>   UBUNTU: [Config]: enable amd renoir ASoC audio
> 
> Vijendar Mukunda (17):
>   ASoC: amd: add Renoir ACP3x IP register header
>   ASoC: amd: add Renoir ACP PCI driver
>   ASoC: amd: add acp init/de-init functions
>   ASoC: amd: create acp3x pdm platform device
>   ASoC: amd: add ACP3x PDM platform driver
>   ASoC: amd: irq handler changes for ACP3x PDM dma driver
>   ASoC: amd: add acp3x pdm driver dma ops
>   ASoC: amd: add ACP PDM DMA driver dai ops
>   ASoC: amd: add Renoir ACP PCI driver PM ops
>   ASoC: amd: add ACP PDM DMA driver pm ops
>   ASoC: amd: enable Renoir acp3x drivers build
>   ASoC: amd: create platform devices for Renoir
>   ASoC: amd: RN machine driver using dmic
>   ASoC: amd: enable build for RN machine driver
>   ASoC: amd: fix kernel warning
>   ASoC: amd: refactoring dai_hw_params() callback
>   ASoC: amd: return error when acp de-init fails
> 
>  debian.master/config/annotations           |   4 +
>  debian.master/config/config.common.ubuntu  |   2 +
>  sound/soc/amd/Kconfig                      |  13 +
>  sound/soc/amd/Makefile                     |   1 +
>  sound/soc/amd/renoir/Makefile              |   7 +
>  sound/soc/amd/renoir/acp3x-pdm-dma.c       | 549 +++++++++++++++++++++
>  sound/soc/amd/renoir/acp3x-rn.c            |  77 +++
>  sound/soc/amd/renoir/rn-pci-acp3x.c        | 344 +++++++++++++
>  sound/soc/amd/renoir/rn_acp3x.h            |  88 ++++
>  sound/soc/amd/renoir/rn_chip_offset_byte.h | 349 +++++++++++++
>  10 files changed, 1434 insertions(+)
>  create mode 100644 sound/soc/amd/renoir/Makefile
>  create mode 100644 sound/soc/amd/renoir/acp3x-pdm-dma.c
>  create mode 100644 sound/soc/amd/renoir/acp3x-rn.c
>  create mode 100644 sound/soc/amd/renoir/rn-pci-acp3x.c
>  create mode 100644 sound/soc/amd/renoir/rn_acp3x.h
>  create mode 100644 sound/soc/amd/renoir/rn_chip_offset_byte.h
>
Sultan Alsawaf June 4, 2020, 5:11 p.m. UTC | #2 
I want a Lenovo machine with renoir...

Acked-by: Sultan Alsawaf <sultan.alsawaf@canonical.com>

On Mon, Jun 01, 2020 at 10:18:28AM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1881046
> 
> The SRU of v1 is only for oem-5.6 and unstable, it has some problem for
> focal, so I did some change for focal and sent this v2 for focal only.
> 
> v1 is for oem-5.6 and unstable
> v2 is for focal
> 
> 
> [Impact]
> We have a couple of LENOVO machines which has amd renoir audio on
> them, our kernel doesn't have the driver for it yet.
> 
> [Fix]
> amd just upstreamed the driver, it is for kernel-5.8, we backport
> them to ubunt kernel.
> 
> [Test Case]
> boot the kernel with those patches, we could see a sound card named
> "acp" and the dmic on it could record sound via arecord.
> 
> [Regression Risk]
> Low, just adding a new driver, no change to existing drivers.
> 
> 
> Hui Wang (1):
>   UBUNTU: [Config]: enable amd renoir ASoC audio
> 
> Vijendar Mukunda (17):
>   ASoC: amd: add Renoir ACP3x IP register header
>   ASoC: amd: add Renoir ACP PCI driver
>   ASoC: amd: add acp init/de-init functions
>   ASoC: amd: create acp3x pdm platform device
>   ASoC: amd: add ACP3x PDM platform driver
>   ASoC: amd: irq handler changes for ACP3x PDM dma driver
>   ASoC: amd: add acp3x pdm driver dma ops
>   ASoC: amd: add ACP PDM DMA driver dai ops
>   ASoC: amd: add Renoir ACP PCI driver PM ops
>   ASoC: amd: add ACP PDM DMA driver pm ops
>   ASoC: amd: enable Renoir acp3x drivers build
>   ASoC: amd: create platform devices for Renoir
>   ASoC: amd: RN machine driver using dmic
>   ASoC: amd: enable build for RN machine driver
>   ASoC: amd: fix kernel warning
>   ASoC: amd: refactoring dai_hw_params() callback
>   ASoC: amd: return error when acp de-init fails
> 
>  debian.master/config/annotations           |   4 +
>  debian.master/config/config.common.ubuntu  |   2 +
>  sound/soc/amd/Kconfig                      |  13 +
>  sound/soc/amd/Makefile                     |   1 +
>  sound/soc/amd/renoir/Makefile              |   7 +
>  sound/soc/amd/renoir/acp3x-pdm-dma.c       | 549 +++++++++++++++++++++
>  sound/soc/amd/renoir/acp3x-rn.c            |  77 +++
>  sound/soc/amd/renoir/rn-pci-acp3x.c        | 344 +++++++++++++
>  sound/soc/amd/renoir/rn_acp3x.h            |  88 ++++
>  sound/soc/amd/renoir/rn_chip_offset_byte.h | 349 +++++++++++++
>  10 files changed, 1434 insertions(+)
>  create mode 100644 sound/soc/amd/renoir/Makefile
>  create mode 100644 sound/soc/amd/renoir/acp3x-pdm-dma.c
>  create mode 100644 sound/soc/amd/renoir/acp3x-rn.c
>  create mode 100644 sound/soc/amd/renoir/rn-pci-acp3x.c
>  create mode 100644 sound/soc/amd/renoir/rn_acp3x.h
>  create mode 100644 sound/soc/amd/renoir/rn_chip_offset_byte.h
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Khalid Elmously June 5, 2020, 5:35 a.m. UTC | #3 
Replaced the URL of the source repo with 'linux-next'

On 2020-06-01 10:18:28 , Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1881046
> 
> The SRU of v1 is only for oem-5.6 and unstable, it has some problem for
> focal, so I did some change for focal and sent this v2 for focal only.
> 
> v1 is for oem-5.6 and unstable
> v2 is for focal
> 
> 
> [Impact]
> We have a couple of LENOVO machines which has amd renoir audio on
> them, our kernel doesn't have the driver for it yet.
> 
> [Fix]
> amd just upstreamed the driver, it is for kernel-5.8, we backport
> them to ubunt kernel.
> 
> [Test Case]
> boot the kernel with those patches, we could see a sound card named
> "acp" and the dmic on it could record sound via arecord.
> 
> [Regression Risk]
> Low, just adding a new driver, no change to existing drivers.
> 
> 
> Hui Wang (1):
>   UBUNTU: [Config]: enable amd renoir ASoC audio
> 
> Vijendar Mukunda (17):
>   ASoC: amd: add Renoir ACP3x IP register header
>   ASoC: amd: add Renoir ACP PCI driver
>   ASoC: amd: add acp init/de-init functions
>   ASoC: amd: create acp3x pdm platform device
>   ASoC: amd: add ACP3x PDM platform driver
>   ASoC: amd: irq handler changes for ACP3x PDM dma driver
>   ASoC: amd: add acp3x pdm driver dma ops
>   ASoC: amd: add ACP PDM DMA driver dai ops
>   ASoC: amd: add Renoir ACP PCI driver PM ops
>   ASoC: amd: add ACP PDM DMA driver pm ops
>   ASoC: amd: enable Renoir acp3x drivers build
>   ASoC: amd: create platform devices for Renoir
>   ASoC: amd: RN machine driver using dmic
>   ASoC: amd: enable build for RN machine driver
>   ASoC: amd: fix kernel warning
>   ASoC: amd: refactoring dai_hw_params() callback
>   ASoC: amd: return error when acp de-init fails
> 
>  debian.master/config/annotations           |   4 +
>  debian.master/config/config.common.ubuntu  |   2 +
>  sound/soc/amd/Kconfig                      |  13 +
>  sound/soc/amd/Makefile                     |   1 +
>  sound/soc/amd/renoir/Makefile              |   7 +
>  sound/soc/amd/renoir/acp3x-pdm-dma.c       | 549 +++++++++++++++++++++
>  sound/soc/amd/renoir/acp3x-rn.c            |  77 +++
>  sound/soc/amd/renoir/rn-pci-acp3x.c        | 344 +++++++++++++
>  sound/soc/amd/renoir/rn_acp3x.h            |  88 ++++
>  sound/soc/amd/renoir/rn_chip_offset_byte.h | 349 +++++++++++++
>  10 files changed, 1434 insertions(+)
>  create mode 100644 sound/soc/amd/renoir/Makefile
>  create mode 100644 sound/soc/amd/renoir/acp3x-pdm-dma.c
>  create mode 100644 sound/soc/amd/renoir/acp3x-rn.c
>  create mode 100644 sound/soc/amd/renoir/rn-pci-acp3x.c
>  create mode 100644 sound/soc/amd/renoir/rn_acp3x.h
>  create mode 100644 sound/soc/amd/renoir/rn_chip_offset_byte.h
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team