| Message ID | 20200406055745.11164-1-po-hsu.lin@canonical.com |
|---|---|
| Headers | show |
| Series | selftests/powerpc: Turn off timeout setting for benchmarks, dscr, signal, tm | expand |
On Mon, Apr 06, 2020 at 01:57:43PM +0800, Po-Hsu Lin wrote: > == SRU Justification == > Some specific tests in powerpc can take longer than the default 45 > seconds that added in commit 852c8cbf34d3 ("selftests/kselftest/runner.sh: > Add 45 second timeout per test") to run, the following test result was > collected across 2 Power8 nodes and 1 Power9 node in our pool: > powerpc/benchmarks/futex_bench - 52s > powerpc/dscr/dscr_sysfs_test - 116s > powerpc/signal/signal_fuzzer - 88s > powerpc/tm/tm_unavailable_test - 168s > powerpc/tm/tm-poison - 240s > > Thus they will fail with TIMEOUT error. > > == Fix == > * 850507f3 ("selftests/powerpc: Turn off timeout setting for benchmarks, dscr, signal, tm") > > Only Eoan and newer kernel will need this fix. > For Eoan, this patch can be applied with some context adjustment. > For Focal, there is a SAUCE patch which turned off timeout setting for > benchmarks and tm that needs to be reverted first, and this patch can > be applied with some context adjustment too > > == Test == > Patch tested on PowerPC and it works as expected. > > == Regression Potential == > Low, changes limited to testing tools for PowerPC. You forgot your sign-off on the first patch. I added it when applying. Applied to focal/master-next and unstable/master, thanks!
Oh indeed I forgot to add -s when reverting that patch. Thank you! Sam On Wed, Apr 8, 2020 at 3:44 AM Seth Forshee <seth.forshee@canonical.com> wrote: > > On Mon, Apr 06, 2020 at 01:57:43PM +0800, Po-Hsu Lin wrote: > > == SRU Justification == > > Some specific tests in powerpc can take longer than the default 45 > > seconds that added in commit 852c8cbf34d3 ("selftests/kselftest/runner.sh: > > Add 45 second timeout per test") to run, the following test result was > > collected across 2 Power8 nodes and 1 Power9 node in our pool: > > powerpc/benchmarks/futex_bench - 52s > > powerpc/dscr/dscr_sysfs_test - 116s > > powerpc/signal/signal_fuzzer - 88s > > powerpc/tm/tm_unavailable_test - 168s > > powerpc/tm/tm-poison - 240s > > > > Thus they will fail with TIMEOUT error. > > > > == Fix == > > * 850507f3 ("selftests/powerpc: Turn off timeout setting for benchmarks, dscr, signal, tm") > > > > Only Eoan and newer kernel will need this fix. > > For Eoan, this patch can be applied with some context adjustment. > > For Focal, there is a SAUCE patch which turned off timeout setting for > > benchmarks and tm that needs to be reverted first, and this patch can > > be applied with some context adjustment too > > > > == Test == > > Patch tested on PowerPC and it works as expected. > > > > == Regression Potential == > > Low, changes limited to testing tools for PowerPC. > > You forgot your sign-off on the first patch. I added it when applying. > > Applied to focal/master-next and unstable/master, thanks!
== SRU Justification == Some specific tests in powerpc can take longer than the default 45 seconds that added in commit 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test") to run, the following test result was collected across 2 Power8 nodes and 1 Power9 node in our pool: powerpc/benchmarks/futex_bench - 52s powerpc/dscr/dscr_sysfs_test - 116s powerpc/signal/signal_fuzzer - 88s powerpc/tm/tm_unavailable_test - 168s powerpc/tm/tm-poison - 240s Thus they will fail with TIMEOUT error. == Fix == * 850507f3 ("selftests/powerpc: Turn off timeout setting for benchmarks, dscr, signal, tm") Only Eoan and newer kernel will need this fix. For Eoan, this patch can be applied with some context adjustment. For Focal, there is a SAUCE patch which turned off timeout setting for benchmarks and tm that needs to be reverted first, and this patch can be applied with some context adjustment too == Test == Patch tested on PowerPC and it works as expected. == Regression Potential == Low, changes limited to testing tools for PowerPC. Po-Hsu Lin (2): Revert "UBUNTU: SAUCE: selftests/powerpc -- Disable timeout for benchmark and tm tests" selftests/powerpc: Turn off timeout setting for benchmarks, dscr, signal, tm tools/testing/selftests/powerpc/dscr/Makefile | 2 ++ tools/testing/selftests/powerpc/dscr/settings | 1 + tools/testing/selftests/powerpc/signal/Makefile | 2 ++ tools/testing/selftests/powerpc/signal/settings | 1 + 4 files changed, 6 insertions(+) create mode 100644 tools/testing/selftests/powerpc/dscr/settings create mode 100644 tools/testing/selftests/powerpc/signal/settings