mbox series

[0/1,SRU,B] LP#1860320 -- Fix hns3 driver by padding the short frame before sending to the hardware

Message ID 20200224164724.26030-1-taihsiang.ho@canonical.com
Headers show
Series LP#1860320 -- Fix hns3 driver by padding the short frame before sending to the hardware | expand

Message

Taihsiang Ho (tai271828) Feb. 24, 2020, 4:47 p.m. UTC 
The hardware can not handle short frames below or equal to 32
bytes.

[Impact]
The system may hang or endless event log in /var/log/syslog

[Fix]
Cherry-pick or backport the upstream fix
36c67349a1a1c88b9cf11d7ca7762ababdb38867 net: hns3: pad the short frame
before sending to the hardware

[Test Case]
Send a frame less than 33 bytes.

[Regression Risk]
Low, the patch is only specific to the hns3 driver.

Yunsheng Lin (1):
  net: hns3: pad the short frame before sending to the hardware

 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Andrea Righi Feb. 27, 2020, 8:37 a.m. UTC | #1 
On Tue, Feb 25, 2020 at 12:47:23AM +0800, Taihsiang Ho (tai271828) wrote:
> The hardware can not handle short frames below or equal to 32
> bytes.
> 
> [Impact]
> The system may hang or endless event log in /var/log/syslog
> 
> [Fix]
> Cherry-pick or backport the upstream fix
> 36c67349a1a1c88b9cf11d7ca7762ababdb38867 net: hns3: pad the short frame
> before sending to the hardware
> 
> [Test Case]
> Send a frame less than 33 bytes.
> 
> [Regression Risk]
> Low, the patch is only specific to the hns3 driver.
> 
> Yunsheng Lin (1):
>   net: hns3: pad the short frame before sending to the hardware
> 
>  drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Looks good to me.

Acked-by: Andrea Righi <andrea.righi@canonical.com>
Khalid Elmously March 11, 2020, 6:02 a.m. UTC | #2 
Applied to Bionic, fixed the BugLink to use https.


On 2020-02-25 00:47:23 , Taihsiang Ho (tai271828) wrote:
> The hardware can not handle short frames below or equal to 32
> bytes.
> 
> [Impact]
> The system may hang or endless event log in /var/log/syslog
> 
> [Fix]
> Cherry-pick or backport the upstream fix
> 36c67349a1a1c88b9cf11d7ca7762ababdb38867 net: hns3: pad the short frame
> before sending to the hardware
> 
> [Test Case]
> Send a frame less than 33 bytes.
> 
> [Regression Risk]
> Low, the patch is only specific to the hns3 driver.
> 
> Yunsheng Lin (1):
>   net: hns3: pad the short frame before sending to the hardware
> 
>  drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team