mbox series

[Eoan,0/2] Fixes boot problem

Message ID 20191128135422.18160-1-cascardo@canonical.com
Headers show
Series Fixes boot problem | expand

Message

Thadeu Lima de Souza Cascardo Nov. 28, 2019, 1:54 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1852586

Multiple reports for boot problems have been sent for linux
5.3.0-23-generic. The suspicion was around either dm-crypt and TPM. At
least one user has reported that these reverts have fixed the boot issue.

These patches were applied recently, so the regression potential would be
the previous status quo regarding TPM support. TPM failures have been seen
before, but they seemed to be more about log failures, but no boot issues.

Thadeu Lima de Souza Cascardo (2):
  Revert "tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for
    interrupts"
  Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"

 drivers/char/tpm/tpm_tis_core.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Stefan Bader Nov. 29, 2019, 9:55 a.m. UTC | #1
On 28.11.19 14:54, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1852586
> 
> Multiple reports for boot problems have been sent for linux
> 5.3.0-23-generic. The suspicion was around either dm-crypt and TPM. At
> least one user has reported that these reverts have fixed the boot issue.
> 
> These patches were applied recently, so the regression potential would be
> the previous status quo regarding TPM support. TPM failures have been seen
> before, but they seemed to be more about log failures, but no boot issues.
> 
> Thadeu Lima de Souza Cascardo (2):
>   Revert "tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for
>     interrupts"
>   Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"
> 
>  drivers/char/tpm/tpm_tis_core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Paolo Pisati Nov. 29, 2019, 10:05 a.m. UTC | #2
Makes sense.

Acked-by: Paolo Pisati <paolo.pisati@canonical.com>

On Thu, Nov 28, 2019 at 2:54 PM Thadeu Lima de Souza Cascardo
<cascardo@canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1852586
>
> Multiple reports for boot problems have been sent for linux
> 5.3.0-23-generic. The suspicion was around either dm-crypt and TPM. At
> least one user has reported that these reverts have fixed the boot issue.
>
> These patches were applied recently, so the regression potential would be
> the previous status quo regarding TPM support. TPM failures have been seen
> before, but they seemed to be more about log failures, but no boot issues.
>
> Thadeu Lima de Souza Cascardo (2):
>   Revert "tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for
>     interrupts"
>   Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"
>
>  drivers/char/tpm/tpm_tis_core.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> --
> 2.20.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Sacilotto de Souza Nov. 29, 2019, 5:01 p.m. UTC | #3
On 28.11.19 14:54, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1852586
> 
> Multiple reports for boot problems have been sent for linux
> 5.3.0-23-generic. The suspicion was around either dm-crypt and TPM. At
> least one user has reported that these reverts have fixed the boot issue.
> 
> These patches were applied recently, so the regression potential would be
> the previous status quo regarding TPM support. TPM failures have been seen
> before, but they seemed to be more about log failures, but no boot issues.
> 
> Thadeu Lima de Souza Cascardo (2):
>   Revert "tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for
>     interrupts"
>   Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"
> 
>  drivers/char/tpm/tpm_tis_core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 

Applied to eoan/master-next branch, adding the prefix 'UBUNTU: SAUCE:' to
the patches subject and a reference to the upstream commit sha1 being reverted.

Thanks,
Kleber