| Message ID | 20191009080838.5246-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | drm/i915: Fix the issue of "azx_get_response timeout" for hdmi audio on ICL platforms | expand |
On 09.10.19 10:08, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1847192 > > In the V2, I dropped the Disco, so these two patches will not be > merged to Disco since Disco kernel doesn't support ICL graphic, > these two patches are useless to Disco kernel. > > > > Since Bionic kernel doesn't support ICL platforms (i915), so these two > patches will not be sent to Bionic kernel. > > [Impact] > On the ICL platforms, the hdmi can't work well, the audio driver > will print "azx_get_response timeout" randomly, then the whole > audio doesn't work anymore. > > [Fix] > Intel provide these two fixes to us, and we tested these two > patches, it really fixed the issue. > > [Test Case] > Boot and check the hdmi audio, then suspend and resume, check > the hdmi audio, all work well. > > [Regression Risk] > Low, Only enable the audio PIN and enable the clock for ICL. we > tested on both ICL and non-ICL, all worked well as before. > > > Kai Vehmanen (2): > UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+ > display > UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more > platforms > > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++--- > 2 files changed, 11 insertions(+), 3 deletions(-) > Hrm, this sounds like for the initial submission for Disco nobody actually bothered to even test compile. If that is the new level of quality there might be a mandatory build log for every series requested in the future... For now, but rather grumpy, Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 9.10.2019 11.08, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1847192 > > In the V2, I dropped the Disco, so these two patches will not be > merged to Disco since Disco kernel doesn't support ICL graphic, > these two patches are useless to Disco kernel. > > > > Since Bionic kernel doesn't support ICL platforms (i915), so these two > patches will not be sent to Bionic kernel. > > [Impact] > On the ICL platforms, the hdmi can't work well, the audio driver > will print "azx_get_response timeout" randomly, then the whole > audio doesn't work anymore. > > [Fix] > Intel provide these two fixes to us, and we tested these two > patches, it really fixed the issue. > > [Test Case] > Boot and check the hdmi audio, then suspend and resume, check > the hdmi audio, all work well. > > [Regression Risk] > Low, Only enable the audio PIN and enable the clock for ICL. we > tested on both ICL and non-ICL, all worked well as before. > > > Kai Vehmanen (2): > UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+ > display > UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more > platforms > > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++--- > 2 files changed, 11 insertions(+), 3 deletions(-) > applied to osp1 oem-next, thanks
On 09.10.19 10:08, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1847192 > > In the V2, I dropped the Disco, so these two patches will not be > merged to Disco since Disco kernel doesn't support ICL graphic, > these two patches are useless to Disco kernel. > > > > Since Bionic kernel doesn't support ICL platforms (i915), so these two > patches will not be sent to Bionic kernel. > > [Impact] > On the ICL platforms, the hdmi can't work well, the audio driver > will print "azx_get_response timeout" randomly, then the whole > audio doesn't work anymore. > > [Fix] > Intel provide these two fixes to us, and we tested these two > patches, it really fixed the issue. > > [Test Case] > Boot and check the hdmi audio, then suspend and resume, check > the hdmi audio, all work well. > > [Regression Risk] > Low, Only enable the audio PIN and enable the clock for ICL. we > tested on both ICL and non-ICL, all worked well as before. > > > Kai Vehmanen (2): > UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+ > display > UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more > platforms > > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++--- > 2 files changed, 11 insertions(+), 3 deletions(-) > For Eoan: Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 09.10.19 10:08, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1847192 > > In the V2, I dropped the Disco, so these two patches will not be > merged to Disco since Disco kernel doesn't support ICL graphic, > these two patches are useless to Disco kernel. > > > > Since Bionic kernel doesn't support ICL platforms (i915), so these two > patches will not be sent to Bionic kernel. > > [Impact] > On the ICL platforms, the hdmi can't work well, the audio driver > will print "azx_get_response timeout" randomly, then the whole > audio doesn't work anymore. > > [Fix] > Intel provide these two fixes to us, and we tested these two > patches, it really fixed the issue. > > [Test Case] > Boot and check the hdmi audio, then suspend and resume, check > the hdmi audio, all work well. > > [Regression Risk] > Low, Only enable the audio PIN and enable the clock for ICL. we > tested on both ICL and non-ICL, all worked well as before. > > > Kai Vehmanen (2): > UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+ > display > UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more > platforms > > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++--- > 2 files changed, 11 insertions(+), 3 deletions(-) > Applied to eoan/master-next branch. Thanks, Kleber
On Wed, Oct 09, 2019 at 04:08:34PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1847192 > > In the V2, I dropped the Disco, so these two patches will not be > merged to Disco since Disco kernel doesn't support ICL graphic, > these two patches are useless to Disco kernel. > > > > Since Bionic kernel doesn't support ICL platforms (i915), so these two > patches will not be sent to Bionic kernel. > > [Impact] > On the ICL platforms, the hdmi can't work well, the audio driver > will print "azx_get_response timeout" randomly, then the whole > audio doesn't work anymore. > > [Fix] > Intel provide these two fixes to us, and we tested these two > patches, it really fixed the issue. > > [Test Case] > Boot and check the hdmi audio, then suspend and resume, check > the hdmi audio, all work well. > > [Regression Risk] > Low, Only enable the audio PIN and enable the clock for ICL. we > tested on both ICL and non-ICL, all worked well as before. Applied to unstable/master, thanks!
BugLink: https://bugs.launchpad.net/bugs/1847192 In the V2, I dropped the Disco, so these two patches will not be merged to Disco since Disco kernel doesn't support ICL graphic, these two patches are useless to Disco kernel. Since Bionic kernel doesn't support ICL platforms (i915), so these two patches will not be sent to Bionic kernel. [Impact] On the ICL platforms, the hdmi can't work well, the audio driver will print "azx_get_response timeout" randomly, then the whole audio doesn't work anymore. [Fix] Intel provide these two fixes to us, and we tested these two patches, it really fixed the issue. [Test Case] Boot and check the hdmi audio, then suspend and resume, check the hdmi audio, all work well. [Regression Risk] Low, Only enable the audio PIN and enable the clock for ICL. we tested on both ICL and non-ICL, all worked well as before. Kai Vehmanen (2): UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+ display UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more platforms drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++--- 2 files changed, 11 insertions(+), 3 deletions(-)