mbox series

[RFC,b/azure,0/3] azure XDP generic fixes - option 2

Message ID 20190613202401.1628-1-ioanna-maria.alifieraki@canonical.com
Headers show
Series azure XDP generic fixes - option 2 | expand

Message

Ioanna Alifieraki June 13, 2019, 8:23 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1831254

As per lp #1831254 to backport commits:
996ed04741467 ("netvsc: unshare skb in VF rx handler")
458bf2f224f04 ("net: core: support XDP generic on stacked devices.")

PATCH 1/3 : cherry-picks 996ed04741467
PATCH 2/3 : backports dc05360fee660 needed for 458bf2f224f04
PATCH 3/3 : backports 458bf2f224f04
Both pathces (2,3) backport relevant commits by not including the
modifications done on netif_receive_skb_list_internal function which is
not present.

Eric Dumazet (1):
  net: convert rps_needed and rfs_needed to new static branch api

Stephen Hemminger (2):
  netvsc: unshare skb in VF rx handler
  net: core: support XDP generic on stacked devices.

 drivers/net/hyperv/netvsc_drv.c |  6 ++++
 drivers/net/tun.c               |  2 +-
 include/linux/netdevice.h       |  4 +--
 include/net/sock.h              |  2 +-
 net/core/dev.c                  | 50 +++++++++++----------------------
 net/core/net-sysfs.c            |  4 +--
 net/core/sysctl_net_core.c      |  8 +++---
 7 files changed, 32 insertions(+), 44 deletions(-)

Comments

Marcelo Henrique Cerri June 19, 2019, 12:57 p.m. UTC | #1
Upstream backport and Microsoft has provided positive test results for
this patch set.

Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
Marcelo Henrique Cerri June 19, 2019, 3:35 p.m. UTC | #2
Just a comment for reviewers and appliers, this patch set is intended
to cosmic/linux-azure, bionic/linux-azure will receive it indirectly
since it's a backport of cosmic/linux-azure.

On Thu, Jun 13, 2019 at 09:23:58PM +0100, Ioanna Alifieraki wrote:
> BugLink: https://bugs.launchpad.net/bugs/1831254
> 
> As per lp #1831254 to backport commits:
> 996ed04741467 ("netvsc: unshare skb in VF rx handler")
> 458bf2f224f04 ("net: core: support XDP generic on stacked devices.")
> 
> PATCH 1/3 : cherry-picks 996ed04741467
> PATCH 2/3 : backports dc05360fee660 needed for 458bf2f224f04
> PATCH 3/3 : backports 458bf2f224f04
> Both pathces (2,3) backport relevant commits by not including the
> modifications done on netif_receive_skb_list_internal function which is
> not present.
> 
> Eric Dumazet (1):
>   net: convert rps_needed and rfs_needed to new static branch api
> 
> Stephen Hemminger (2):
>   netvsc: unshare skb in VF rx handler
>   net: core: support XDP generic on stacked devices.
> 
>  drivers/net/hyperv/netvsc_drv.c |  6 ++++
>  drivers/net/tun.c               |  2 +-
>  include/linux/netdevice.h       |  4 +--
>  include/net/sock.h              |  2 +-
>  net/core/dev.c                  | 50 +++++++++++----------------------
>  net/core/net-sysfs.c            |  4 +--
>  net/core/sysctl_net_core.c      |  8 +++---
>  7 files changed, 32 insertions(+), 44 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Andrea Righi June 19, 2019, 6:36 p.m. UTC | #3
On Thu, Jun 13, 2019 at 09:23:58PM +0100, Ioanna Alifieraki wrote:
> BugLink: https://bugs.launchpad.net/bugs/1831254
> 
> As per lp #1831254 to backport commits:
> 996ed04741467 ("netvsc: unshare skb in VF rx handler")
> 458bf2f224f04 ("net: core: support XDP generic on stacked devices.")
> 
> PATCH 1/3 : cherry-picks 996ed04741467
> PATCH 2/3 : backports dc05360fee660 needed for 458bf2f224f04
> PATCH 3/3 : backports 458bf2f224f04
> Both pathces (2,3) backport relevant commits by not including the
> modifications done on netif_receive_skb_list_internal function which is
> not present.
> 
> Eric Dumazet (1):
>   net: convert rps_needed and rfs_needed to new static branch api
> 
> Stephen Hemminger (2):
>   netvsc: unshare skb in VF rx handler
>   net: core: support XDP generic on stacked devices.
> 

All upstream fixes, backport changes are minimal and straightforward.
Everything looks reasonable to me.

Acked-by: Andrea Righi <andrea.righi@canonical.com>
Connor Kuehl June 19, 2019, 6:59 p.m. UTC | #4
On 6/13/19 1:23 PM, Ioanna Alifieraki wrote:
> BugLink: https://bugs.launchpad.net/bugs/1831254
> 
> As per lp #1831254 to backport commits:
> 996ed04741467 ("netvsc: unshare skb in VF rx handler")
> 458bf2f224f04 ("net: core: support XDP generic on stacked devices.")
> 
> PATCH 1/3 : cherry-picks 996ed04741467
> PATCH 2/3 : backports dc05360fee660 needed for 458bf2f224f04
> PATCH 3/3 : backports 458bf2f224f04
> Both pathces (2,3) backport relevant commits by not including the
> modifications done on netif_receive_skb_list_internal function which is
> not present.
> 
> Eric Dumazet (1):
>   net: convert rps_needed and rfs_needed to new static branch api
> 
> Stephen Hemminger (2):
>   netvsc: unshare skb in VF rx handler
>   net: core: support XDP generic on stacked devices.
> 
>  drivers/net/hyperv/netvsc_drv.c |  6 ++++
>  drivers/net/tun.c               |  2 +-
>  include/linux/netdevice.h       |  4 +--
>  include/net/sock.h              |  2 +-
>  net/core/dev.c                  | 50 +++++++++++----------------------
>  net/core/net-sysfs.c            |  4 +--
>  net/core/sysctl_net_core.c      |  8 +++---
>  7 files changed, 32 insertions(+), 44 deletions(-)
> 

I just had a quick question about the phrasing in the backport context
message for patch 3 but aside from that these changes look good with
positive test results.

Acked-by: Connor Kuehl <connor.kuehl@canonical.com>
Khalid Elmously June 19, 2019, 9:45 p.m. UTC | #5
Applied to cosmic/azure as Marcelo said. bionic/azure will get it when it's rebased.


On 2019-06-13 21:23:58 , Ioanna Alifieraki wrote:
> BugLink: https://bugs.launchpad.net/bugs/1831254
> 
> As per lp #1831254 to backport commits:
> 996ed04741467 ("netvsc: unshare skb in VF rx handler")
> 458bf2f224f04 ("net: core: support XDP generic on stacked devices.")
> 
> PATCH 1/3 : cherry-picks 996ed04741467
> PATCH 2/3 : backports dc05360fee660 needed for 458bf2f224f04
> PATCH 3/3 : backports 458bf2f224f04
> Both pathces (2,3) backport relevant commits by not including the
> modifications done on netif_receive_skb_list_internal function which is
> not present.
> 
> Eric Dumazet (1):
>   net: convert rps_needed and rfs_needed to new static branch api
> 
> Stephen Hemminger (2):
>   netvsc: unshare skb in VF rx handler
>   net: core: support XDP generic on stacked devices.
> 
>  drivers/net/hyperv/netvsc_drv.c |  6 ++++
>  drivers/net/tun.c               |  2 +-
>  include/linux/netdevice.h       |  4 +--
>  include/net/sock.h              |  2 +-
>  net/core/dev.c                  | 50 +++++++++++----------------------
>  net/core/net-sysfs.c            |  4 +--
>  net/core/sysctl_net_core.c      |  8 +++---
>  7 files changed, 32 insertions(+), 44 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team