| Message ID | 20190514105654.11369-1-po-hsu.lin@canonical.com |
|---|---|
| Headers | show |
| Series | POSIX fix for ftrace test inubuntu_kernel_selftests | expand |
On 14.05.19 12:56, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1828995 > > == Justification == > There are some non-POSIX implementations in the test script, which will > generate some noise in the test reports like: > -e -n [1] Basic trace file check > -e [PASS] > -e -n [2] Basic test for tracers > -e [PASS] > > == Fix == > * 4ce55a9c (selftests/ftrace: Replace \e with \033) > * 37fb665b (selftests/ftrace: Replace echo -e with printf) > > These two patches can be cherry-picked into D/E > > == Test == > Tested on a P8 box with Disco, the patched test will print the report in > a proper format: > [1] Basic trace file check [PASS] > [2] Basic test for tracers [PASS] > > == Regression Potential == > No regression is expected. This patchset just make sure this test comply > with POSIX standard. > > Juerg Haefliger (2): > selftests/ftrace: Replace \e with \033 > selftests/ftrace: Replace echo -e with printf > > tools/testing/selftests/ftrace/ftracetest | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > Acked-by: Stefan Bader <stefan.bader@canonical.com>
On Tue, May 14, 2019 at 06:56:52PM +0800, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1828995 > > == Justification == > There are some non-POSIX implementations in the test script, which will > generate some noise in the test reports like: > -e -n [1] Basic trace file check > -e [PASS] > -e -n [2] Basic test for tracers > -e [PASS] > > == Fix == > * 4ce55a9c (selftests/ftrace: Replace \e with \033) > * 37fb665b (selftests/ftrace: Replace echo -e with printf) > > These two patches can be cherry-picked into D/E > > == Test == > Tested on a P8 box with Disco, the patched test will print the report in > a proper format: > [1] Basic trace file check [PASS] > [2] Basic test for tracers [PASS] > > == Regression Potential == > No regression is expected. This patchset just make sure this test comply > with POSIX standard. Acked-by: Seth Forshee <seth.forshee@canonical.com> The eoan kernel is currently copied forward from disco, and unstable already has the patches. Thanks!
On 5/14/19 12:56 PM, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1828995 > > == Justification == > There are some non-POSIX implementations in the test script, which will > generate some noise in the test reports like: > -e -n [1] Basic trace file check > -e [PASS] > -e -n [2] Basic test for tracers > -e [PASS] > > == Fix == > * 4ce55a9c (selftests/ftrace: Replace \e with \033) > * 37fb665b (selftests/ftrace: Replace echo -e with printf) > > These two patches can be cherry-picked into D/E > > == Test == > Tested on a P8 box with Disco, the patched test will print the report in > a proper format: > [1] Basic trace file check [PASS] > [2] Basic test for tracers [PASS] > > == Regression Potential == > No regression is expected. This patchset just make sure this test comply > with POSIX standard. > > Juerg Haefliger (2): > selftests/ftrace: Replace \e with \033 > selftests/ftrace: Replace echo -e with printf > > tools/testing/selftests/ftrace/ftracetest | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > Applied to disco/master-next branch. Thanks, Kleber