mbox series

[SRU,Xenial,0/1] btrfs: fallocate: fix memory leak

Message ID 20190403123857.1420-1-andrea.righi@canonical.com
Headers show
Series btrfs: fallocate: fix memory leak | expand

Message

Andrea Righi April 3, 2019, 12:38 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1822579

[Impact]

 * If fallocate() is failing on a btrfs subvolume when its qgroup quota
   limit exceeded, a previously allocated extent map isn't correctly
   released, causing a memory leak from the pool btrfs_extent_map

 * Fix by correctly deallocating the object in case of failure

[Test Case]

 * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1822579/+attachment/5252459/+files/btrfs-fallocate-test.sh

[Fix]

 * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be2d253cc98244765323a7c94cc1ac5cd5a17072

Fix the memory leak by adding the proper free_extent_map() call to the
failure path.

[Regression Potential]

 * This is an upstream fix, tested on the affected platform. The patch
   is really small, backport changes are minimal. All the other Ubuntu
   releases are including this fix already.

Filipe Manana (1):
 Btrfs: fix extent map leak during fallocate error path

 fs/btrfs/file.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Khalid Elmously April 15, 2019, 3:49 a.m. UTC | #1 
On 2019-04-03 14:38:57 , Andrea Righi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1822579
> 
> [Impact]
> 
>  * If fallocate() is failing on a btrfs subvolume when its qgroup quota
>    limit exceeded, a previously allocated extent map isn't correctly
>    released, causing a memory leak from the pool btrfs_extent_map
> 
>  * Fix by correctly deallocating the object in case of failure
> 
> [Test Case]
> 
>  * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1822579/+attachment/5252459/+files/btrfs-fallocate-test.sh
> 
> [Fix]
> 
>  * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be2d253cc98244765323a7c94cc1ac5cd5a17072
> 
> Fix the memory leak by adding the proper free_extent_map() call to the
> failure path.
> 
> [Regression Potential]
> 
>  * This is an upstream fix, tested on the affected platform. The patch
>    is really small, backport changes are minimal. All the other Ubuntu
>    releases are including this fix already.
> 
> Filipe Manana (1):
>  Btrfs: fix extent map leak during fallocate error path
> 
>  fs/btrfs/file.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team