| Message ID | 20190322061358.31550-1-jesse.sung@canonical.com |
|---|---|
| Headers | show |
| Series | Add support for MAC address pass through on RTL8153-BD | expand |
Acked-By: You-Sheng Yang <vicamo.yang@canonical.com> On 2019/3/22 2:13 PM, Wen-chien Jesse Sung wrote: > BugLink: https://launchpad.net/bugs/1821276 > > == SRU Justification == > > * Impact: > RTL8153-BD is used in Dell DA300 type-C dongle and should be added to > the whitelist of devices to activate MAC address passthrough. > > * Fix: > Two commits in upstream need to be applied in order to support this > feature. Both of them are in 5.0. > > commit 8e29d23e28ee7fb995a00c1ca7e1a4caf5070b12 > Author: David Chen david.chen7@dell.com > Date: Sat Feb 16 17:16:42 2019 +0800 > > r8152: Add support for MAC address pass through on RTL8153-BD > > commit c286909fe5458f69e533c845b757fd2c35064d26 > Author: David Chen david.chen7@dell.com > Date: Wed Feb 20 13:47:19 2019 +0800 > > r8152: Fix an error on RTL8153-BD MAC Address Passthrough support > > * Testcase: > BIOS settings must be properly set before verifying. > 1. [Settings][POST Behavior][MAC Address Pass-Through]: > Passthrough MAC Address > 2. There should be two MAC addresses in BIOS settings, > ex: [Settings][General][System Information] > Attach the dongle and see if MAC passthrough works. > > * Risk of Regression: > Clean cherry-pick from mainline, and only add specific hardware to > the whitelist. Risk is low. > > > David Chen (2): > r8152: Add support for MAC address pass through on RTL8153-BD > r8152: Fix an error on RTL8153-BD MAC Address Passthrough support > > drivers/net/usb/r8152.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >
On 2019-03-22 14:13:56 , Wen-chien Jesse Sung wrote: > BugLink: https://launchpad.net/bugs/1821276 > > == SRU Justification == > > * Impact: > RTL8153-BD is used in Dell DA300 type-C dongle and should be added to > the whitelist of devices to activate MAC address passthrough. > > * Fix: > Two commits in upstream need to be applied in order to support this > feature. Both of them are in 5.0. > > commit 8e29d23e28ee7fb995a00c1ca7e1a4caf5070b12 > Author: David Chen david.chen7@dell.com > Date: Sat Feb 16 17:16:42 2019 +0800 > > r8152: Add support for MAC address pass through on RTL8153-BD > > commit c286909fe5458f69e533c845b757fd2c35064d26 > Author: David Chen david.chen7@dell.com > Date: Wed Feb 20 13:47:19 2019 +0800 > > r8152: Fix an error on RTL8153-BD MAC Address Passthrough support > > * Testcase: > BIOS settings must be properly set before verifying. > 1. [Settings][POST Behavior][MAC Address Pass-Through]: > Passthrough MAC Address > 2. There should be two MAC addresses in BIOS settings, > ex: [Settings][General][System Information] > Attach the dongle and see if MAC passthrough works. > > * Risk of Regression: > Clean cherry-pick from mainline, and only add specific hardware to > the whitelist. Risk is low. > > > David Chen (2): > r8152: Add support for MAC address pass through on RTL8153-BD > r8152: Fix an error on RTL8153-BD MAC Address Passthrough support > > drivers/net/usb/r8152.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
On 3/22/19 7:13 AM, Wen-chien Jesse Sung wrote: > BugLink: https://launchpad.net/bugs/1821276 > > == SRU Justification == > > * Impact: > RTL8153-BD is used in Dell DA300 type-C dongle and should be added to > the whitelist of devices to activate MAC address passthrough. > > * Fix: > Two commits in upstream need to be applied in order to support this > feature. Both of them are in 5.0. > > commit 8e29d23e28ee7fb995a00c1ca7e1a4caf5070b12 > Author: David Chen david.chen7@dell.com > Date: Sat Feb 16 17:16:42 2019 +0800 > > r8152: Add support for MAC address pass through on RTL8153-BD > > commit c286909fe5458f69e533c845b757fd2c35064d26 > Author: David Chen david.chen7@dell.com > Date: Wed Feb 20 13:47:19 2019 +0800 > > r8152: Fix an error on RTL8153-BD MAC Address Passthrough support > > * Testcase: > BIOS settings must be properly set before verifying. > 1. [Settings][POST Behavior][MAC Address Pass-Through]: > Passthrough MAC Address > 2. There should be two MAC addresses in BIOS settings, > ex: [Settings][General][System Information] > Attach the dongle and see if MAC passthrough works. > > * Risk of Regression: > Clean cherry-pick from mainline, and only add specific hardware to > the whitelist. Risk is low. > > > David Chen (2): > r8152: Add support for MAC address pass through on RTL8153-BD > r8152: Fix an error on RTL8153-BD MAC Address Passthrough support > > drivers/net/usb/r8152.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > These patches were applied to bionic/master-next and cosmic/master-next branches. Thanks, Kleber