mbox series

[Cosmic,0/4] tcmu reset_netlink feature

Message ID 20190318173228.28563-1-kamal@canonical.com
Headers show
Series tcmu reset_netlink feature | expand

Message

Kamal Mostafa March 18, 2019, 5:32 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1819504

As requested by Google, please support the tcmu block and reset_netlink
methods.  The following four commits from mainline (cherry picks and
light backports) implement the needed features.  Only the tcmu driver is
affected.

 -Kamal


Mike Christie (4):
  scsi: tcmu: delete unused __wait
  scsi: tcmu: track nl commands
  scsi: tcmu: simplify nl interface
  scsi: tcmu: add module wide block/reset_netlink support

 drivers/target/target_core_user.c | 191 +++++++++++++++++++++++-------
 1 file changed, 146 insertions(+), 45 deletions(-)

Comments

Kleber Sacilotto de Souza March 26, 2019, 12:02 p.m. UTC | #1
On 3/18/19 6:32 PM, Kamal Mostafa wrote:
> BugLink: http://bugs.launchpad.net/bugs/1819504
> 
> As requested by Google, please support the tcmu block and reset_netlink
> methods.  The following four commits from mainline (cherry picks and
> light backports) implement the needed features.  Only the tcmu driver is
> affected.
> 
>  -Kamal
> 
> 
> Mike Christie (4):
>   scsi: tcmu: delete unused __wait
>   scsi: tcmu: track nl commands
>   scsi: tcmu: simplify nl interface
>   scsi: tcmu: add module wide block/reset_netlink support
> 
>  drivers/target/target_core_user.c | 191 +++++++++++++++++++++++-------
>  1 file changed, 146 insertions(+), 45 deletions(-)
> 

Same feedback as for the series for Bionic, the correct provenance line
for backported patches is:

"(backported from commit ...)"

without the dash ("-"). This can be fixed when applying though.

Apart from that they look good. Scope limited to tcmu and tested.


Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Khalid Elmously March 27, 2019, 6:18 a.m. UTC | #2
On 2019-03-18 10:32:24 , Kamal Mostafa wrote:
> BugLink: http://bugs.launchpad.net/bugs/1819504
> 
> As requested by Google, please support the tcmu block and reset_netlink
> methods.  The following four commits from mainline (cherry picks and
> light backports) implement the needed features.  Only the tcmu driver is
> affected.
> 
>  -Kamal
> 
> 
> Mike Christie (4):
>   scsi: tcmu: delete unused __wait
>   scsi: tcmu: track nl commands
>   scsi: tcmu: simplify nl interface
>   scsi: tcmu: add module wide block/reset_netlink support
> 
>  drivers/target/target_core_user.c | 191 +++++++++++++++++++++++-------
>  1 file changed, 146 insertions(+), 45 deletions(-)
> 

Also the BugLink should use https://

Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Khalid Elmously March 27, 2019, 6:25 a.m. UTC | #3
On 2019-03-18 10:32:24 , Kamal Mostafa wrote:
> BugLink: http://bugs.launchpad.net/bugs/1819504
> 
> As requested by Google, please support the tcmu block and reset_netlink
> methods.  The following four commits from mainline (cherry picks and
> light backports) implement the needed features.  Only the tcmu driver is
> affected.
> 
>  -Kamal
> 
> 
> Mike Christie (4):
>   scsi: tcmu: delete unused __wait
>   scsi: tcmu: track nl commands
>   scsi: tcmu: simplify nl interface
>   scsi: tcmu: add module wide block/reset_netlink support
> 
>  drivers/target/target_core_user.c | 191 +++++++++++++++++++++++-------
>  1 file changed, 146 insertions(+), 45 deletions(-)
>

Applied, after fixing the commits messages to use https:// and 'backported'.

The bug is nominated for both linux (B and C) and linux-gcp (B and C). Do the linux-gcp nominations need to be invalidated?