mbox series

[RESEND,SRU,B/C/D/Unstable,0/1] Fix not working Goodix touchpad

Message ID 20190116071948.18491-1-kai.heng.feng@canonical.com
Headers show
Series Fix not working Goodix touchpad | expand

Message

Kai-Heng Feng Jan. 16, 2019, 7:19 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1811929

[Impact]
Goodix I2C PTP touchpad doesn't work.

[Fix]
Disable runtime PM can fix it.

[Test]
I verified the touchpad starts working with the fix.

[Regression Potential]
Low. The fix limits to a specific device which doesn't work without it.

Kai-Heng Feng (1):
  HID: i2c-hid: Disable runtime PM on Goodix touchpad

 drivers/hid/hid-ids.h         | 3 +++
 drivers/hid/i2c-hid/i2c-hid.c | 2 ++
 2 files changed, 5 insertions(+)

Comments

Po-Hsu Lin Jan. 16, 2019, 8:41 a.m. UTC | #1 
Changes to enable a specific hardware.
Backport looks ok.
Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
AceLan Kao Jan. 16, 2019, 9:38 a.m. UTC | #2 
Applied on OEM kernel 4.15.0-1032.37

Acked-By: AceLan Kao <acelan.kao@canonical.com>
Seth Forshee Jan. 18, 2019, 6:40 p.m. UTC | #3 
On Wed, Jan 16, 2019 at 03:19:44PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1811929
> 
> [Impact]
> Goodix I2C PTP touchpad doesn't work.
> 
> [Fix]
> Disable runtime PM can fix it.
> 
> [Test]
> I verified the touchpad starts working with the fix.
> 
> [Regression Potential]
> Low. The fix limits to a specific device which doesn't work without it.
> 
> Kai-Heng Feng (1):
>   HID: i2c-hid: Disable runtime PM on Goodix touchpad

Scope limited to specific hardware, positive testing.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to disco/master-next and unstable/master, thanks!
Stefan Bader Jan. 21, 2019, 2:44 p.m. UTC | #4 
On 16.01.19 08:19, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1811929
> 
> [Impact]
> Goodix I2C PTP touchpad doesn't work.
> 
> [Fix]
> Disable runtime PM can fix it.
> 
> [Test]
> I verified the touchpad starts working with the fix.
> 
> [Regression Potential]
> Low. The fix limits to a specific device which doesn't work without it.
> 
> Kai-Heng Feng (1):
>   HID: i2c-hid: Disable runtime PM on Goodix touchpad
> 
>  drivers/hid/hid-ids.h         | 3 +++
>  drivers/hid/i2c-hid/i2c-hid.c | 2 ++
>  2 files changed, 5 insertions(+)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Khalid Elmously Jan. 28, 2019, 1:08 a.m. UTC | #5 
On 2019-01-16 15:19:44 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1811929
> 
> [Impact]
> Goodix I2C PTP touchpad doesn't work.
> 
> [Fix]
> Disable runtime PM can fix it.
> 
> [Test]
> I verified the touchpad starts working with the fix.
> 
> [Regression Potential]
> Low. The fix limits to a specific device which doesn't work without it.
> 
> Kai-Heng Feng (1):
>   HID: i2c-hid: Disable runtime PM on Goodix touchpad
> 
>  drivers/hid/hid-ids.h         | 3 +++
>  drivers/hid/i2c-hid/i2c-hid.c | 2 ++
>  2 files changed, 5 insertions(+)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team