mbox series

[SRU,C/D/Unstable,0/1] Fix new hid-steam driver that breaks some Steam games

Message ID 20181208072524.19211-1-kai.heng.feng@canonical.com
Headers show
Series Fix new hid-steam driver that breaks some Steam games | expand

Message

Kai-Heng Feng Dec. 8, 2018, 7:25 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1798583

[Impact]
New steam-hid driver breaks Unity games.

[Fix]
Quote from the commit message:
"With this commit, when a HID client starts, the input device is removed;
when the HID client ends the input device is recreated."

[Test]
A guy from Valve comfirms the backport works.

[Regression Potential]
Low. This fix is specific to hid-steam, which is a new driver introduced
in v4.18.

Rodrigo Rivas Costa (1):
  HID: steam: remove input device when a hid client is running.

 drivers/hid/hid-steam.c | 154 +++++++++++++++++++++++-----------------
 1 file changed, 90 insertions(+), 64 deletions(-)

Comments

Seth Forshee Dec. 10, 2018, 9:47 p.m. UTC | #1 
On Sat, Dec 08, 2018 at 03:25:23PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1798583
> 
> [Impact]
> New steam-hid driver breaks Unity games.
> 
> [Fix]
> Quote from the commit message:
> "With this commit, when a HID client starts, the input device is removed;
> when the HID client ends the input device is recreated."
> 
> [Test]
> A guy from Valve comfirms the backport works.
> 
> [Regression Potential]
> Low. This fix is specific to hid-steam, which is a new driver introduced
> in v4.18.

Upstream cherry pick, limited impact.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

This is already present in unstable and disco (via upstream stable).
Thanks!
Khalid Elmously Dec. 28, 2018, 9:20 a.m. UTC | #2 
Applied to cosmic.

This patch already exists in Disco (which is unstable)


On 2018-12-08 15:25:23 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1798583
> 
> [Impact]
> New steam-hid driver breaks Unity games.
> 
> [Fix]
> Quote from the commit message:
> "With this commit, when a HID client starts, the input device is removed;
> when the HID client ends the input device is recreated."
> 
> [Test]
> A guy from Valve comfirms the backport works.
> 
> [Regression Potential]
> Low. This fix is specific to hid-steam, which is a new driver introduced
> in v4.18.
> 
> Rodrigo Rivas Costa (1):
>   HID: steam: remove input device when a hid client is running.
> 
>  drivers/hid/hid-steam.c | 154 +++++++++++++++++++++++-----------------
>  1 file changed, 90 insertions(+), 64 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Khalid Elmously Dec. 29, 2018, 4:03 a.m. UTC | #3 
On 2018-12-28 04:20:44 , Khaled Elmously wrote:
> Applied to cosmic.
> 
> This patch already exists in Disco (which is unstable)

Correction: Disco is not unstable - but it also already has this patch.


> 
> 
> On 2018-12-08 15:25:23 , Kai-Heng Feng wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1798583
> > 
> > [Impact]
> > New steam-hid driver breaks Unity games.
> > 
> > [Fix]
> > Quote from the commit message:
> > "With this commit, when a HID client starts, the input device is removed;
> > when the HID client ends the input device is recreated."
> > 
> > [Test]
> > A guy from Valve comfirms the backport works.
> > 
> > [Regression Potential]
> > Low. This fix is specific to hid-steam, which is a new driver introduced
> > in v4.18.
> > 
> > Rodrigo Rivas Costa (1):
> >   HID: steam: remove input device when a hid client is running.
> > 
> >  drivers/hid/hid-steam.c | 154 +++++++++++++++++++++++-----------------
> >  1 file changed, 90 insertions(+), 64 deletions(-)
> > 
> > -- 
> > 2.17.1
> > 
> > 
> > -- 
> > kernel-team mailing list
> > kernel-team@lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team