mbox series

[B/C/D,v2,0/1] Support Edge Gateway's Bluetooth LED

Message ID 20181017114210.30774-1-jesse.sung@canonical.com
Headers show
Series Support Edge Gateway's Bluetooth LED | expand

Message

Wen-chien Jesse Sung Oct. 17, 2018, 11:42 a.m. UTC 
BugLink: https://launchpad.net/bugs/1798332

== Impact ==
The Bluetooth LED of Marvell 88W8897 is not enabled by default
(there's no code for controlling LED). It is requested to be ON
and OFF when the radio is on and off accordingly.

== Fix ==
The LEDs are connected to GPIO pins on the Marvell WiFi/Bluetooth
combo module, thus they can only be controlled via firmware.

== Test Case ==
# hciconfig hci0 [on|off]
and see if the LEDs work properly.

== Risk of Regression ==
PCI sub IDs of the host bridge are used to determine if we're really
running on an Edge Gateway, and we already have these patches in Xenial
kernels quite a while. Risk should be reasonably low.


Wen-chien Jesse Sung (1):
  UBUNTU: SAUCE: Bluetooth: Support for LED on Edge Gateways

 drivers/bluetooth/btusb.c | 42 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 41 insertions(+), 1 deletion(-)

Comments

Seth Forshee Oct. 17, 2018, 6:45 p.m. UTC | #1 
On Wed, Oct 17, 2018 at 07:42:09PM +0800, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1798332
> 
> == Impact ==
> The Bluetooth LED of Marvell 88W8897 is not enabled by default
> (there's no code for controlling LED). It is requested to be ON
> and OFF when the radio is on and off accordingly.
> 
> == Fix ==
> The LEDs are connected to GPIO pins on the Marvell WiFi/Bluetooth
> combo module, thus they can only be controlled via firmware.
> 
> == Test Case ==
> # hciconfig hci0 [on|off]
> and see if the LEDs work properly.
> 
> == Risk of Regression ==
> PCI sub IDs of the host bridge are used to determine if we're really
> running on an Edge Gateway, and we already have these patches in Xenial
> kernels quite a while. Risk should be reasonably low.

Applied to unstable/master, thanks!
Khalid Elmously Oct. 22, 2018, 7:18 a.m. UTC | #2 
On 2018-10-17 19:42:09 , Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1798332
> 
> == Impact ==
> The Bluetooth LED of Marvell 88W8897 is not enabled by default
> (there's no code for controlling LED). It is requested to be ON
> and OFF when the radio is on and off accordingly.
> 
> == Fix ==
> The LEDs are connected to GPIO pins on the Marvell WiFi/Bluetooth
> combo module, thus they can only be controlled via firmware.
> 
> == Test Case ==
> # hciconfig hci0 [on|off]
> and see if the LEDs work properly.
> 
> == Risk of Regression ==
> PCI sub IDs of the host bridge are used to determine if we're really
> running on an Edge Gateway, and we already have these patches in Xenial
> kernels quite a while. Risk should be reasonably low.
> 
> 
> Wen-chien Jesse Sung (1):
>   UBUNTU: SAUCE: Bluetooth: Support for LED on Edge Gateways
> 
>  drivers/bluetooth/btusb.c | 42 ++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 41 insertions(+), 1 deletion(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team