mbox series

[SRU,Bionic,0/1] Add missing firmware info for Intel GLK

Message ID 20181008053558.17552-1-kai.heng.feng@canonical.com
Headers show
Series Add missing firmware info for Intel GLK | expand

Message

Kai-Heng Feng Oct. 8, 2018, 5:35 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1760545

[Impact]
i915 lacks information about the glk_dmc_ver1_04.bin firmware file in
modinfo, so it is not included in the initrd along with the i915 driver.
Thus the firmware does not get loaded. Loading the firmware is said to
prevent a hang.

In addition to that, this also causes GLK's HDMI audio codec stops
working after S3.

[Fix]
Add a MODULE_FIRMWARE statement for the firmware.

This information is required to let initramfs-tools includes the
firmware.

[Test Case]
Without the firmware there will be a "Direct firmware load for
i915/glk_dmc_ver1_04.bin failed with error -2" line in dmesg. With the
firmware there is no such message.

I can confirm the GLK HDMI audio issue is gone when firmware is loaded.

[Regression Potential]
Minimal. Will only be loaded by i915 for specific hardware, and loading
the firmware is known to fix a hang.

Ian W MORRISON (1):
  drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

 drivers/gpu/drm/i915/intel_csr.c | 1 +
 1 file changed, 1 insertion(+)

Comments

AceLan Kao Oct. 8, 2018, 6:41 a.m. UTC | #1 
Acked-By: AceLan Kao <acelan.kao@canonical.com>
Kleber Sacilotto de Souza Oct. 19, 2018, 2:48 p.m. UTC | #2 
On 10/08/18 07:35, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1760545
> 
> [Impact]
> i915 lacks information about the glk_dmc_ver1_04.bin firmware file in
> modinfo, so it is not included in the initrd along with the i915 driver.
> Thus the firmware does not get loaded. Loading the firmware is said to
> prevent a hang.
> 
> In addition to that, this also causes GLK's HDMI audio codec stops
> working after S3.
> 
> [Fix]
> Add a MODULE_FIRMWARE statement for the firmware.
> 
> This information is required to let initramfs-tools includes the
> firmware.
> 
> [Test Case]
> Without the firmware there will be a "Direct firmware load for
> i915/glk_dmc_ver1_04.bin failed with error -2" line in dmesg. With the
> firmware there is no such message.
> 
> I can confirm the GLK HDMI audio issue is gone when firmware is loaded.
> 
> [Regression Potential]
> Minimal. Will only be loaded by i915 for specific hardware, and loading
> the firmware is known to fix a hang.
> 
> Ian W MORRISON (1):
>   drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
> 
>  drivers/gpu/drm/i915/intel_csr.c | 1 +
>  1 file changed, 1 insertion(+)
> 


Applied to bionic/master-next branch.

Thanks,
Kleber