| Message ID | 20181002141106.1646-1-kleber.souza@canonical.com |
|---|---|
| Headers | show |
| Series | Linux 4.4.155 stable release build is broken on ppc64 | expand |
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
On 10/02/18 16:11, Kleber Sacilotto de Souza wrote: > BugLink: https://bugs.launchpad.net/bugs/1795662 > > == SRU Justification == > The 4.4.y stable backport c9fadf27006b for upstream commit 1bd6a1c4b80a > ("powerpc/fadump: handle crash memory ranges array index overflow"), > cherry-picked for Xenial as part of bug 1792419, introduces a build failure > on ppc by returning a int in a void function. In 4.4.y register_fadump() > returns void because 98b8cd7f7564 ("powerpc/fadump: Return error when fadump > registration fails") hasn't been backported for this stable release. > > == Fix == > 98b8cd7f7564 ("powerpc/fadump: Return error when fadump registration fails") > > Backport needed only for context adjustment. > > == Regression Potential == > Low. The patch only handles the error return by some function and adds an > additional error message. Limited to powerpc. > > == Test Case == > Compile the kernel for powerpc (tested with ppc64el). > > Michal Suchanek (1): > powerpc/fadump: Return error when fadump registration fails > > arch/powerpc/kernel/fadump.c | 23 +++++++++++++++-------- > 1 file changed, 15 insertions(+), 8 deletions(-) > Applied to xenial/master-next branch. Thanks, Kleber
BugLink: https://bugs.launchpad.net/bugs/1795662 == SRU Justification == The 4.4.y stable backport c9fadf27006b for upstream commit 1bd6a1c4b80a ("powerpc/fadump: handle crash memory ranges array index overflow"), cherry-picked for Xenial as part of bug 1792419, introduces a build failure on ppc by returning a int in a void function. In 4.4.y register_fadump() returns void because 98b8cd7f7564 ("powerpc/fadump: Return error when fadump registration fails") hasn't been backported for this stable release. == Fix == 98b8cd7f7564 ("powerpc/fadump: Return error when fadump registration fails") Backport needed only for context adjustment. == Regression Potential == Low. The patch only handles the error return by some function and adds an additional error message. Limited to powerpc. == Test Case == Compile the kernel for powerpc (tested with ppc64el). Michal Suchanek (1): powerpc/fadump: Return error when fadump registration fails arch/powerpc/kernel/fadump.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-)