mbox series

[SRU,Bionic,linux/linux-gcp,0/1] Fix xfs build error

Message ID 20180913165616.20361-1-kleber.souza@canonical.com
Headers show
Series Fix xfs build error | expand

Message

Kleber Sacilotto de Souza Sept. 13, 2018, 4:56 p.m. UTC 
This issue has real impact only on linux-gcp, which is the only kernel
that enables CONFIG_XFS_ONLINE_SCRUB. So I'm proposing the fix for
bionic/linux-gcp to be applied to the current cycle, and for
bionic/linux to fix it on the main kernel on a following cycle.
The patch applied for gcp will be gone away on the next rebase.

SRU Justification:

Impact:
The backport of a78ee256c325 ("xfs: convert XFS_AGFL_SIZE to a helper function")
done as part of "Bionic update: upstream stable patchset 2018-08-24"
(bug 1788897) is incomplete, causing the build to fail if
CONFIG_XFS_ONLINE_SCRUB is selected.

/tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c: In function 'xfs_scrub_walk_agfl':
/tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c:96:24: error: implicit declaration of function 'XFS_AGFL_SIZE'; did you mean 'XFS_ACL_SIZE'? [-Werror=implicit-function-declaration]
  for (i = flfirst; i < XFS_AGFL_SIZE(mp); i++) {
                        ^~~~~~~~~~~~~
                        XFS_ACL_SIZE

The backport didn't replace all the occurrences of the XFS_AGFL_SIZE macro
by the xfs_agfl_size function.

Fix:
A SAUCE patch is needed to fix the backport, given that the problem doesn't
exist with mainline.

Testcase:
Enable CONFIG_XFS_ONLINE_SCRUB and compile the kernel.


Kleber Sacilotto de Souza (1):
  UBUNTU: SAUCE: xfs: fix build error with CONFIG_XFS_ONLINE_SCRUB
    enabled

 fs/xfs/scrub/agheader.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Kamal Mostafa Sept. 13, 2018, 5:06 p.m. UTC | #1 
Acked-by: Kamal Mostafa <kamal@canonical.com>

On Thu, Sep 13, 2018 at 06:56:15PM +0200, Kleber Sacilotto de Souza wrote:
> This issue has real impact only on linux-gcp, which is the only kernel
> that enables CONFIG_XFS_ONLINE_SCRUB. So I'm proposing the fix for
> bionic/linux-gcp to be applied to the current cycle, and for
> bionic/linux to fix it on the main kernel on a following cycle.
> The patch applied for gcp will be gone away on the next rebase.
> 
> SRU Justification:
> 
> Impact:
> The backport of a78ee256c325 ("xfs: convert XFS_AGFL_SIZE to a helper function")
> done as part of "Bionic update: upstream stable patchset 2018-08-24"
> (bug 1788897) is incomplete, causing the build to fail if
> CONFIG_XFS_ONLINE_SCRUB is selected.
> 
> /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c: In function 'xfs_scrub_walk_agfl':
> /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c:96:24: error: implicit declaration of function 'XFS_AGFL_SIZE'; did you mean 'XFS_ACL_SIZE'? [-Werror=implicit-function-declaration]
>   for (i = flfirst; i < XFS_AGFL_SIZE(mp); i++) {
>                         ^~~~~~~~~~~~~
>                         XFS_ACL_SIZE
> 
> The backport didn't replace all the occurrences of the XFS_AGFL_SIZE macro
> by the xfs_agfl_size function.
> 
> Fix:
> A SAUCE patch is needed to fix the backport, given that the problem doesn't
> exist with mainline.
> 
> Testcase:
> Enable CONFIG_XFS_ONLINE_SCRUB and compile the kernel.
> 
> 
> Kleber Sacilotto de Souza (1):
>   UBUNTU: SAUCE: xfs: fix build error with CONFIG_XFS_ONLINE_SCRUB
>     enabled
> 
>  fs/xfs/scrub/agheader.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Sacilotto de Souza Sept. 13, 2018, 5:22 p.m. UTC | #2 
On 09/13/18 18:56, Kleber Sacilotto de Souza wrote:
> This issue has real impact only on linux-gcp, which is the only kernel
> that enables CONFIG_XFS_ONLINE_SCRUB. So I'm proposing the fix for
> bionic/linux-gcp to be applied to the current cycle, and for
> bionic/linux to fix it on the main kernel on a following cycle.
> The patch applied for gcp will be gone away on the next rebase.
> 
> SRU Justification:
> 
> Impact:
> The backport of a78ee256c325 ("xfs: convert XFS_AGFL_SIZE to a helper function")
> done as part of "Bionic update: upstream stable patchset 2018-08-24"
> (bug 1788897) is incomplete, causing the build to fail if
> CONFIG_XFS_ONLINE_SCRUB is selected.
> 
> /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c: In function 'xfs_scrub_walk_agfl':
> /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c:96:24: error: implicit declaration of function 'XFS_AGFL_SIZE'; did you mean 'XFS_ACL_SIZE'? [-Werror=implicit-function-declaration]
>   for (i = flfirst; i < XFS_AGFL_SIZE(mp); i++) {
>                         ^~~~~~~~~~~~~
>                         XFS_ACL_SIZE
> 
> The backport didn't replace all the occurrences of the XFS_AGFL_SIZE macro
> by the xfs_agfl_size function.
> 
> Fix:
> A SAUCE patch is needed to fix the backport, given that the problem doesn't
> exist with mainline.
> 
> Testcase:
> Enable CONFIG_XFS_ONLINE_SCRUB and compile the kernel.
> 
> 
> Kleber Sacilotto de Souza (1):
>   UBUNTU: SAUCE: xfs: fix build error with CONFIG_XFS_ONLINE_SCRUB
>     enabled
> 
>  fs/xfs/scrub/agheader.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Applied to bionic/linux-gcp/master-next branch.

NOTE: not applied to bionic/linux/master-next.

Thanks,
Kleber
Kleber Sacilotto de Souza Sept. 14, 2018, 8:35 a.m. UTC | #3 
On 09/13/18 18:56, Kleber Sacilotto de Souza wrote:
> This issue has real impact only on linux-gcp, which is the only kernel
> that enables CONFIG_XFS_ONLINE_SCRUB. So I'm proposing the fix for
> bionic/linux-gcp to be applied to the current cycle, and for
> bionic/linux to fix it on the main kernel on a following cycle.
> The patch applied for gcp will be gone away on the next rebase.
> 
> SRU Justification:
> 
> Impact:
> The backport of a78ee256c325 ("xfs: convert XFS_AGFL_SIZE to a helper function")
> done as part of "Bionic update: upstream stable patchset 2018-08-24"
> (bug 1788897) is incomplete, causing the build to fail if
> CONFIG_XFS_ONLINE_SCRUB is selected.
> 
> /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c: In function 'xfs_scrub_walk_agfl':
> /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c:96:24: error: implicit declaration of function 'XFS_AGFL_SIZE'; did you mean 'XFS_ACL_SIZE'? [-Werror=implicit-function-declaration]
>   for (i = flfirst; i < XFS_AGFL_SIZE(mp); i++) {
>                         ^~~~~~~~~~~~~
>                         XFS_ACL_SIZE
> 
> The backport didn't replace all the occurrences of the XFS_AGFL_SIZE macro
> by the xfs_agfl_size function.
> 
> Fix:
> A SAUCE patch is needed to fix the backport, given that the problem doesn't
> exist with mainline.
> 
> Testcase:
> Enable CONFIG_XFS_ONLINE_SCRUB and compile the kernel.
> 
> 
> Kleber Sacilotto de Souza (1):
>   UBUNTU: SAUCE: xfs: fix build error with CONFIG_XFS_ONLINE_SCRUB
>     enabled
> 
>  fs/xfs/scrub/agheader.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Applied to bionic/linux/master-next branch.

Thanks,
Kleber