mbox series

[SRU,Bionic,0/3] Fix for r8169 connection issue

Message ID 20180827043638.4279-1-kai.heng.feng@canonical.com
Headers show
Series Fix for r8169 connection issue | expand

Message

Kai-Heng Feng Aug. 27, 2018, 4:36 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1779817

[Impact]
r8169 failed to establish connection after the fix for LP: #1752772
landed.

[Fix]
Accepts BIOS WoL settings again, and disables MSI-X for certain chip
revisions.

[Test]
Users confirmed the fix worked for them.

[Regression Potential]
Low. This brings back the old behavior for both WoL and MSI.

Heiner Kallweit (2):
  r8169: restore previous behavior to accept BIOS WoL settings
  r8169: don't use MSI-X on RTL8168g

Jian-Hong Pan (1):
  r8169: don't use MSI-X on RTL8106e

 drivers/net/ethernet/realtek/r8169.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

Comments

Stefan Bader Aug. 27, 2018, 1:20 p.m. UTC | #1 
On 27.08.2018 06:36, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1779817
> 
> [Impact]
> r8169 failed to establish connection after the fix for LP: #1752772
> landed.
> 
> [Fix]
> Accepts BIOS WoL settings again, and disables MSI-X for certain chip
> revisions.
> 
> [Test]
> Users confirmed the fix worked for them.
> 
> [Regression Potential]
> Low. This brings back the old behavior for both WoL and MSI.
> 
> Heiner Kallweit (2):
>   r8169: restore previous behavior to accept BIOS WoL settings
>   r8169: don't use MSI-X on RTL8168g
> 
> Jian-Hong Pan (1):
>   r8169: don't use MSI-X on RTL8106e
> 
>  drivers/net/ethernet/realtek/r8169.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 

Patches look ok to me. But patches #2 and #3 are from 4.19-rc1, so there is a
chance that they also should be picked up for Cosmic/unstable in order to avoid
regressions there.

I added Thadeu and Seth to cc. Apart from this,

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Seth Forshee Aug. 29, 2018, 9:08 p.m. UTC | #2 
On Mon, Aug 27, 2018 at 12:36:35PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1779817
> 
> [Impact]
> r8169 failed to establish connection after the fix for LP: #1752772
> landed.
> 
> [Fix]
> Accepts BIOS WoL settings again, and disables MSI-X for certain chip
> revisions.
> 
> [Test]
> Users confirmed the fix worked for them.
> 
> [Regression Potential]
> Low. This brings back the old behavior for both WoL and MSI.

Cherry-picked the last two commits directly to cosmic/master-next.
Unstable already received these from upstream stable updates. Thanks!
Anthony Wong Aug. 30, 2018, 9:53 a.m. UTC | #3 
On Mon, Aug 27, 2018 at 12:36:35PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1779817
> 
> [Impact]
> r8169 failed to establish connection after the fix for LP: #1752772
> landed.
> 
> [Fix]
> Accepts BIOS WoL settings again, and disables MSI-X for certain chip
> revisions.
> 
> [Test]
> Users confirmed the fix worked for them.
> 
> [Regression Potential]
> Low. This brings back the old behavior for both WoL and MSI.
> 
> Heiner Kallweit (2):
>   r8169: restore previous behavior to accept BIOS WoL settings
>   r8169: don't use MSI-X on RTL8168g
> 
> Jian-Hong Pan (1):
>   r8169: don't use MSI-X on RTL8106e
> 
>  drivers/net/ethernet/realtek/r8169.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)

Acked-by: Anthony Wong <anthony.wong@canonical.com>
Kleber Sacilotto de Souza Sept. 4, 2018, 3:04 p.m. UTC | #4 
On 08/27/18 06:36, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1779817
> 
> [Impact]
> r8169 failed to establish connection after the fix for LP: #1752772
> landed.
> 
> [Fix]
> Accepts BIOS WoL settings again, and disables MSI-X for certain chip
> revisions.
> 
> [Test]
> Users confirmed the fix worked for them.
> 
> [Regression Potential]
> Low. This brings back the old behavior for both WoL and MSI.
> 
> Heiner Kallweit (2):
>   r8169: restore previous behavior to accept BIOS WoL settings
>   r8169: don't use MSI-X on RTL8168g
> 
> Jian-Hong Pan (1):
>   r8169: don't use MSI-X on RTL8106e
> 
>  drivers/net/ethernet/realtek/r8169.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 

Applied to bionic/master-next branch.

Thanks,
Kleber