| Message ID | 20180719101932.23954-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Enable AMD PCIe MP2 for AMDI0011 | expand |
The drivers are for new devices, should be pretty safe to have them.
And after discussed with KaiHeng, the 2 drivers won't work if be
compiled as modules.
Acked-By: AceLan Kao <acelan.kao@canonical.com>
On Thu, Jul 19, 2018 at 06:19:28PM +0800, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1773940 > > [Impact] > Touchpad doesn't work on Latitude 5495. > > [Test] > I can confirm the driver from AMD works. > With patch 2/3, no issues found so far. > > [Fix] > The touchpad connects to AMDI0011, which doesn't have any driver until > now. > > The original plan is to use an upstream version for this driver, but the > review process took longer than anticipated, and the driver is really in > need as the Latitude 5495 is about to hit the market. I'll replace this > patch set with upstream version once it's in mainline. > > v2: Fix build for architectures don't support ACPI. > > [Regression Potential] > Low. It's a new driver, shouldn't affect any other device. Applied to cosmic/master-next and unstable/master, with Stefan's version of patch 4 (adjusted for context, etc.). Thanks!
On 07/19/18 12:19, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1773940 > > [Impact] > Touchpad doesn't work on Latitude 5495. > > [Test] > I can confirm the driver from AMD works. > With patch 2/3, no issues found so far. > > [Fix] > The touchpad connects to AMDI0011, which doesn't have any driver until > now. > > The original plan is to use an upstream version for this driver, but the > review process took longer than anticipated, and the driver is really in > need as the Latitude 5495 is about to hit the market. I'll replace this > patch set with upstream version once it's in mainline. > > v2: Fix build for architectures don't support ACPI. > > [Regression Potential] > Low. It's a new driver, shouldn't affect any other device. > > Kai-Heng Feng (3): > UBUNTU: SAUCE: i2c:amd move out pointer in union i2c_event_base > UBUNTU: SAUCE: i2c:amd Depends on ACPI > UBUNTU: [Config] i2c: CONFIG_I2C_AMD_MP2=y > > Nehal-bakulchandra Shah (1): > UBUNTU: SAUCE: i2c:amd I2C Driver based on PCI Interface for upcoming > platform > > debian.master/config/config.common.ubuntu | 1 + > drivers/i2c/busses/Kconfig | 10 + > drivers/i2c/busses/Makefile | 2 + > drivers/i2c/busses/i2c-amd-pci-mp2.c | 625 ++++++++++++++++++++++ > drivers/i2c/busses/i2c-amd-pci-mp2.h | 253 +++++++++ > drivers/i2c/busses/i2c-amd-platdrv.c | 335 ++++++++++++ > 6 files changed, 1226 insertions(+) > create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.c > create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.h > create mode 100644 drivers/i2c/busses/i2c-amd-platdrv.c > Applied to bionic/master-next branch, with Stefan's version for patch 4/4. Thanks, Kleber
BugLink: https://bugs.launchpad.net/bugs/1773940 [Impact] Touchpad doesn't work on Latitude 5495. [Test] I can confirm the driver from AMD works. With patch 2/3, no issues found so far. [Fix] The touchpad connects to AMDI0011, which doesn't have any driver until now. The original plan is to use an upstream version for this driver, but the review process took longer than anticipated, and the driver is really in need as the Latitude 5495 is about to hit the market. I'll replace this patch set with upstream version once it's in mainline. v2: Fix build for architectures don't support ACPI. [Regression Potential] Low. It's a new driver, shouldn't affect any other device. Kai-Heng Feng (3): UBUNTU: SAUCE: i2c:amd move out pointer in union i2c_event_base UBUNTU: SAUCE: i2c:amd Depends on ACPI UBUNTU: [Config] i2c: CONFIG_I2C_AMD_MP2=y Nehal-bakulchandra Shah (1): UBUNTU: SAUCE: i2c:amd I2C Driver based on PCI Interface for upcoming platform debian.master/config/config.common.ubuntu | 1 + drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 2 + drivers/i2c/busses/i2c-amd-pci-mp2.c | 625 ++++++++++++++++++++++ drivers/i2c/busses/i2c-amd-pci-mp2.h | 253 +++++++++ drivers/i2c/busses/i2c-amd-platdrv.c | 335 ++++++++++++ 6 files changed, 1226 insertions(+) create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.c create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.h create mode 100644 drivers/i2c/busses/i2c-amd-platdrv.c